OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 4
Total Committers: 73
Last Commit: 26 Dec
Commits this week: 4
Total Lines of Code (LoC): 74,843
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 27 Aug
3:55 pm

gustafn

reduce verbosity during regression test

Options
    • -1
    • +5
    ./tcl/test/acs-tcl-test-procs.tcl
    • -6
    • +4
    ./tcl/test/ad-proc-test-procs.tcl
3:37 pm

gustafn

do not complain about expected behavior

Options
    • -7
    • +7
    ./tcl/apm-install-procs.tcl
3:22 pm

gustafn

silence regression test

Options
    • -5
    • +32
    ./tcl/test/ad-proc-test-procs.tcl
    • -4
    • +9
    ./tcl/test/datamodel-test-procs.tcl
3:21 pm

gustafn

don't expect that invalid input becomes magically valid

Options
    • -2
    • +2
    ./tcl/test/html-conversion-procs.tcl
3:20 pm

gustafn

reduce verbosity

Options
    • -18
    • +1
    ./tcl/community-core-procs.tcl
    • -2
    • +2
    ./tcl/test/text-html-procs.tcl
3:01 pm

gustafn

align nameing with 'resource_info_procs'

Options
    • -4
    • +4
    ./tcl/utilities-procs.tcl
  2. … 7 more files in changeset.
2:14 pm

gustafn

silence test cases

Options
    • -2
    • +4
    ./tcl/test/acs-tcl-test-procs.tcl
2:13 pm

gustafn

claim test coverage

Options
    • -0
    • +2
    ./tcl/test/apm-file-procs.tcl
    • -1
    • +3
    ./tcl/test/community-core-test-procs.tcl
2:12 pm

gustafn

fixed old bug via regression test in page contract filters

The binding variable for "min_length" and others was not passed correctly.

We saw unexpected warning of the following form during regression test:

Warning: Message contains a variable named 'min_length' which doesn't exist in the caller's environment:

Options
    • -4
    • +4
    ./tcl/tcl-documentation-procs.tcl
1:29 pm

gustafn

handle cases in the page contract, when not connected (used this way in the regression test)

Options
    • -5
    • +9
    ./tcl/tcl-documentation-procs.tcl
1:27 pm

gustafn

keep log file viewable (don't add too many entries)

Options
    • -2
    • +8
    ./tcl/test/file-test-procs.tcl
1:24 pm

gustafn

remove leftover files after run, silence regression test run

Options
    • -4
    • +6
    ./tcl/test/defs-procs.tcl
12:06 pm

gustafn

whitespace changes

Options
    • -73
    • +73
    ./tcl/aolserver-3-procs.tcl
    • -17
    • +16
    ./tcl/user-extensions-procs.tcl
    • -974
    • +974
    ./tcl/xml-1-dom-procs.tcl
    • -69
    • +69
    ./tcl/xml-2-procs.tcl
    • -52
    • +52
    ./tcl/tcltrace-procs.tcl
    • -10
    • +10
    ./tcl/tdom-procs.tcl
  7. … 10 more files in changeset.
12:06 pm

gustafn

silence test cases

Options
    • -3
    • +5
    ./tcl/test/community-core-test-procs.tcl
    • -1
    • +3
    ./tcl/test/utilities-procs.tcl
11:52 am

gustafn

removed progress bar from curl output

Options
    • -2
    • +2
    ./tcl/test/http-client-procs.tcl
11:21 am

gustafn

wget is not used anymore

Options
    • -1
    • +0
    ./tcl/test/acs-tcl-test-procs.tcl
11:20 am

gustafn

silence regression test run

Options
    • -36
    • +59
    ./tcl/test/db-proc-test-procs.tcl
10:49 am

gustafn

provide proper HTML syntax for test cases

https://html.spec.whatwg.org/dev/syntax.html#syntax-attributes

Options
    • -4
    • +8
    ./tcl/test/html-conversion-procs.tcl
Monday 26 Aug
4:28 pm

gustafn

comment unexpectged behaviour

Options
    • -2
    • +7
    ./tcl/tcl-documentation-procs.tcl
4:27 pm

gustafn

Silence several log entries during initial install and during boot.

The system should complain about missing caches just, when

a) not during initial install, and

b) if this is not during startup of an installed version

Options
    • -2
    • +12
    ./tcl/acs-cache-procs.tcl
10:48 am

gustafn

removed potentially misleading dot in dependency message

Options
    • -2
    • +2
    ./tcl/apm-install-procs.tcl
Sunday 25 Aug
2:48 pm

gustafn

make query name fully qualified to remove warning

Options
    • -1
    • +1
    ./tcl/site-nodes-procs.tcl
Tuesday 20 Aug
3:58 pm

gustafn

Fix potential problems when calling polymorphic SQL functions from Tcl

Some functions are defined in the database with the same number of

arguments but different types, e.g., first argument "package_key"

(type text) or "package_id" (type integer). This is fine from the SQL

standpoint, but when calling from Tcl via bind-vars

(e.g. ":package_id"), everything is passed as a string, and

potentially, the wrong function is called.

Now, all the automatically generated subs are generated with casts,

when the integer based variant must be called.

Some examples:

Before:

set s [ns_pg_bind 0or1row $__DB {select apm__set_value(:package_id,:parameter_name,:attr_value)}]

set s [ns_pg_bind 0or1row $__DB {select apm__get_value(:package_id,:parameter_name)}]

Now:

set s [ns_pg_bind 0or1row $__DB {select apm__set_value(CAST(:package_id AS integer),:parameter_name,:attr_value)}]

set s [ns_pg_bind 0or1row $__DB {select apm__get_value(CAST(:package_id AS integer),:parameter_name)}]

- bumped version number to 5.10.1b11

Options
    • -3
    • +3
    ./acs-tcl.info
    • -13
    • +110
    ./tcl/acs-db-12-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
11:36 am

gustafn

fixed resource leak

Options
    • -45
    • +45
    ./tcl/test/acs-tcl-test-procs.tcl
11:30 am

gustafn

reduced verbosity

Options
    • -2
    • +2
    ./tcl/acs-cache-procs.tcl
10:41 am

antoniop

Make localurl filter more robust to invalid URLs: fail validation in this case, intead of crashing

Options
    • -5
    • +9
    ./tcl/tcl-documentation-procs.tcl
10:14 am

gustafn

fixed resource leaks

dom trees were not deleted

Options
    • -4
    • +6
    ./tcl/test/http-client-procs.tcl
9:53 am

gustafn

ad_dom_sanitize_html: fixed 2 resource leaks

in case of parsing errors in the input string the following structures leaked:

- dom tree

- stuct::tree

Options
    • -38
    • +42
    ./tcl/text-html-procs.tcl
8:59 am

gustafn

make sure to delete tdom document

Delete nodes explicitly, otherwise it survives the end of the proc.

Options
    • -2
    • +5
    ./tcl/json-procs.tcl
Monday 19 Aug
3:42 pm

gustafn

fixed icanuse-test for deleting samesite cookies

Options
    • -1
    • +1
    ./tcl/00-icanuse-procs.tcl