• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Test for ad_register_proc exposing a bug due to missing argument expansion

file request-processor-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./request-processor-procs.tcl
fix header generation

since the headers are set in a loop, "ns_set put" is incorrect

since it is additive. "ns_set update" is correct.

improve spelling

Make so that also party::update enforces emails to be lowercase, add/extend automated tests to make sure emails are lowercase everywhere

  1. … 2 more files in changeset.
Refine regex and extend tests

  1. … 1 more file in changeset.
Extend 'acs_tcl__util_url_valid_p' test case

Make the check for relative URLs less strict to cover some valid cases (see RFC 1808) and extend test cases.

  1. … 1 more file in changeset.
Add the 'relative' flag to 'util_url_valid_p', to check also relative URLs. Extend 'acs_tcl__util_url_valid_p' test case and bump package version.

  1. … 2 more files in changeset.
Refine URL validation regexp and extend 'acs_tcl__util_url_valid_p' test case.

  1. … 1 more file in changeset.
Replace regexp for mail validation by the version proposed by mozilla for the email input type validation, and increment the test cases for valid/invalid emails. Thanks to Günter Ernst for the pointers.

  1. … 1 more file in changeset.
Add 'object_p' test case, covering 'acs_object::object_p'

Add 'string_length_compare' test case, covering 'util::string_length_compare'

Add 'name_to_path' test case, covering 'util::name_to_path'

Add 'util_email_valid_p' test case, covering 'util_email_valid_p'

Increase verbosity

Add 'db_boolean' test case, covering 'db_boolean'

Add 'ad_future_years_list' test case, covering 'ad_future_years_list'

Add 'host_admin_and_outgoing_sender' test case, covering 'ad_outgoing_sender' and 'ad_host_administrator'

improved spelling

  1. … 5 more files in changeset.
Added page_contract filter "object_id"

This change adds the page_contract filter "object_id", which validates

values whether these are syntactically acceptable as object_ids in

PostgreSQL and Oracle.

Note that before one is able to use the filter, the server has to be

restarted. Otherwise, when e.g. "apm/version_reload.tcl" would be

executed with the new filter, it would fail. So, one has to be careful

on update scripts, when people upgrade from old version not to create

a blocking mutual blocking condition.

  1. … 4 more files in changeset.
In acs-tcl.documentation__check_proc_doc automated test, if the test fails on procs that belong to namespaces outside the OpenACS codebase, just issue a warning rather than failing

improved listing of covered procs

added page contract filter "printable" to avoid passing of binary values to certain pages

  1. … 2 more files in changeset.
removed unclear test

Whitespace changes + Editor hints

Relax error level

Check also token value in nsv in 'secret_tokens_get' test case

fix and extend regression test, when bread-crumb label needs quoting

Whitespace changes