• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Include tests with string containing an extension, put also a ß in the mix

Basic test for ad_sanitize_filename

file utilities-procs.tcl was initially added on branch oacs-5-10.

Fix test category misplacement

Take care of string values when these are longer than the randomized length

Whitespace changes

Set tests as 'production_safe'

Do rollback after test run

Rework of the 'test_apm_parameter__register' and 'test_apm_package_instance__new' test cases.

Ignored disabled packages in both tests.

Check all enabled packages in 'test_apm_package_instance__new', instead of picking just one randomly, so all issues instantiating packages are found at once.

Indentation changes.

Adapt tests to the new behaviour of 'apm_parameter_unregister'

Do not add admin_node to the component bars if it is empty

Reduce error level to warning in the nullchat test case, as the issue is driver related

Fix typo in library doc

Improve portability of test code

improve comments

  1. … 4 more files in changeset.
Whitespace changes + editor hints

Add 'nullchar' test, which uncovers a bug transmitting the null character to postgres. Many thanks to Nathan Coulter for finding out and creating the test as well.

Avoid testing all site nodes on 'site_node_get_children', if the number of them is too large, as it can take too long

improve spelling

  1. … 14 more files in changeset.
improve spelling

  1. … 5 more files in changeset.
introduced "ad_file" as a means to avoid unexpected tilde substitution in file names

  1. … 50 more files in changeset.
improve spelling: move closer to the linux documentation recommendations

  1. … 32 more files in changeset.
improve comments and spelling

  1. … 1 more file in changeset.
ad_urlencode_url: add a slash to the path when this is not empty, fix test case

  1. … 1 more file in changeset.
Extend test

Expose a regression after changes for bug #3437

more more fix for issue #3441

As Keith reported, there is was one more issue concerning missing column_names and empty query results. This is now as well fixed in oacs-5-10. Also, the regression test was extended to handle these cases as well.

  1. … 2 more files in changeset.
fix for issue #3441

  1. … 1 more file in changeset.
fix for issue #3437, extend regression test

  1. … 1 more file in changeset.
fix for issue #3440: problem with SQL queries in db_transactions after some db_multirows

the was a problem with with db_handle management in complex setups,

where a db_multirow iterating over more than one tuple causes

some other queries in the transaction to fail. See as well

the new test case added to the regression test.

Many thanks to Keith Paskett for reporting and the good test case!

https://openacs.org/bugtracker/openacs/bug?format=table&bug_number=3440

  1. … 2 more files in changeset.