• last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Require admin privileges for attachment deletion in the forum, the same as for message editing

Put the delete link to the right of the attachment

Only offer the possibility to delete an attachment from the file storage if it is really there, offer to detach it in any case.

    • -58
    • +75
    ./packages/attachments/www/detach.tcl
Add 'attachments::get_title' to centralize the logic of title guessing for an attachment

Add the 'detach' option on the attachment list, for users with write permissions on the message

Center icons on attachment list

    • -0
    • +4
    ./packages/forums/www/resources/forums.css
Generalize attachment size logic in forum posts, so different object types, such as 'content_item', 'content_revision', and their subtypes, are supported

Whitespace changes

    • -2
    • +2
    ./packages/attachments/www/download/index.xql
Generalize attachment download logic, so it can deal with different object types, such as 'content_item', 'content_revision', and their subtypes

    • -11
    • +35
    ./packages/attachments/www/download/index.vuh
    • -1
    • +12
    ./packages/attachments/www/download/index.xql
Add 'exception_count' to 'ad_return_complaint'

    • -3
    • +5
    ./packages/attachments/www/download/index.vuh
Use the paremeter 'LoginPasswordAutocomplete' to decide on the value of the attribute for the password element in the login form

Add a new instance parameter 'LoginPasswordAutocomplete' with the value of the 'autocomplete' attribute of the password field of the login form, to let each subsite decide.

    • -2
    • +3
    ./packages/acs-subsite/acs-subsite.info
improve spelling

    • -2
    • +2
    ./packages/acs-core-docs/www/files/dbstart.txt
remove obsolete file

Make 'attachments::get_all_attachments' more general, so we try our best to get the 'label' of the attachment by trying different options depending on the object type: 'content_item', 'content_revision', a subtype of those, or just the 'title' row in the 'acs_objects' table. In the very worst case, just set the given 'item_id' as the label.

Add a simple test case for 'content::revision::get_title'

Add 'content::revision::get_title', a simple proc to get the title of a particular 'content_revision'

Whitespace changes + Editor hints

Disable autocomplete on login password field on 'openacs-bootstrap3-theme'

Prefer live to latest revision when getting title for attachments in 'attachments::get_all_attachments'

Adjust doc and defaults of 'content::item::get_title' to the actual implementation of 'content_item__get_title'

When the attachment is not in the file storage, consider both the possibilities of it being a 'content_item' or a 'content_revision', while trying to resolve its title in 'attachments::get_all_attachments' by looking directly in the content respository

Use 'item_id' instead of 'revision_id' for attachments

Do not assume all attachments are in the file storage while retrieving their title/name

Remove self-reference in proc doc

Check for already converted form variables on 'template::util::file_transform'. This can happen, for instance, during the 'preview' action of a form.

    • -37
    • +46
    ./packages/acs-templating/tcl/file-procs.tcl
Fix '@see' field in proc doc

    • -3
    • +3
    ./packages/acs-templating/tcl/util-procs.tcl
Replace acs_object_party_privilege_map with permission api

Replace deprecated view in queries