OpenACS

openacs-4

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 12
Total Committers: 143
Last Commit: 26 Apr
Commits this week: 12
Total Lines of Code (LoC): 5,629,491
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 02 Mar 2021
11:32 am

gustafn

fixed bug: exception in test case auth_use_email_for_login_p caused test to terminate

By adding an "ad_try", we can see that the intention to create

a user with no username failed. Probably this was working at some time,

not sure, if it still should.

This is could be a general problem with "aa_run_with_teardown" to

terminate too early in such cases.

Options
    • -10
    • +18
    ./packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
10:56 am

gustafn

fix typo

Options
    • -2
    • +2
    ./packages/acs-automated-testing/tcl/coverage-procs.tcl
10:06 am

gustafn

adjust luminosity calculation to the 2020 standard for UHDTV and HDR

Options
    • -2
    • +5
    ./packages/acs-automated-testing/tcl/coverage-procs.tcl
9:08 am

gustafn

remove spurious parens

Options
    • -2
    • +2
    ./packages/search/sql/oracle/search-packages-create.sql
    • -1
    • +1
    ./packages/search/sql/oracle/upgrade/upgrade-5.10.0d3-5.10.0d4.sql
9:08 am

gustafn

improve spelling

Options
    • -2
    • +2
    ./packages/search/tcl/search-procs.tcl
Monday 01 Mar 2021
8:27 pm

gustafn

calculate total points based on points and not on minutes

Options
    • -1
    • +1
    ./packages/xowf/lib/inclass-exam.wf
7:20 pm

gustafn

Handle potential race condition in search observer queue maintenance

In some cases, when e.g. objects are quicky deleted after updates, the

object might be already be deleted when being tried to trigger a

DELETE operation in the search queue. as a consequence, one can sometimes

observer errors like the one below. The new code double-checks now,

if the object for the DELETE operation still exists.

ERROR: insert or update on table "search_observer_queue" violates foreign key constraint "search_observer_queue_object_id_fk"

: DETAIL: Key (object_id)=(497509146) is not present in table "acs_objects".

: CONTEXT: SQL statement "insert into search_observer_queue (

Options
    • -2
    • +2
    ./packages/search/search.info
    • -1
    • +16
    ./packages/search/sql/oracle/search-packages-create.sql
    • -0
    • +50
    ./packages/search/sql/oracle/upgrade/upgrade-5.10.0d3-5.10.0d4.sql
    • -10
    • +21
    ./packages/search/sql/postgresql/search-packages-create.sql
    • -0
    • +36
    ./packages/search/sql/postgresql/upgrade/upgrade-5.10.0d3-5.10.0d4.sql
7:20 pm

gustafn

file upgrade-5.10.0d3-5.10.0d4.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./packages/search/sql/oracle/upgrade/upgrade-5.10.0d3-5.10.0d4.sql
    • -0
    • +0
    ./packages/search/sql/postgresql/upgrade/upgrade-5.10.0d3-5.10.0d4.sql
7:14 pm

gustafn

whitespace changes: break overlong lines

Options
    • -12
    • +20
    ./packages/search/tcl/search-procs.tcl
7:01 pm

gustafn

whitespace changes

Options
    • -3
    • +8
    ./packages/search/tcl/syndicate-procs.tcl
6:59 pm

gustafn

white space changes: break overlong lines

Options
    • -24
    • +50
    ./packages/search/tcl/search-procs.tcl
5:30 pm

gustafn

compute for and background colors from percentage to guarantee good contrast

Options
    • -6
    • +10
    ./packages/acs-automated-testing/tcl/coverage-procs.tcl
    • -3
    • +5
    ./packages/acs-automated-testing/www/admin/index.adp
    • -5
    • +8
    ./packages/acs-automated-testing/www/admin/index.tcl
3:59 pm

hectorr

Add 'acs_subsite_attribute_datatypes' test case, covering 'attribute::translate_datatype' and 'attribute::datatype_validator_exists_p' procs

Options
    • -1
    • +50
    ./packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
3:15 pm

hectorr

Remove unnecessary aliases

Options
    • -12
    • +12
    ./packages/acs-subsite/tcl/attribute-procs.tcl
3:14 pm

hectorr

Add 'attribute::value_add' and 'attribute::value_delete' to the 'acs_subsite_attributes' test case

Options
    • -1
    • +27
    ./packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
1:05 pm

gustafn

improve comments

Options
    • -4
    • +9
    ./packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
11:46 am

gustafn

improve spelling

Options
    • -2
    • +2
    ./packages/acs-bootstrap-installer/installer/index.tcl
    • -3
    • +3
    ./packages/acs-bootstrap-installer/tcl/test/00-proc-procs.tcl
11:43 am

gustafn

reduce the number of locks (nsv-accesses) for OACS_FULLQUERIES by a factor of 3 when NaviServer is used.

OACS_FULLQUERIES is one of the 3 most intensively locked nsv arrays for

busy implementation

Options
    • -20
    • +52
    ./packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
11:12 am

gustafn

improve test coverage

Options
    • -3
    • +41
    ./packages/acs-bootstrap-installer/tcl/test/00-proc-procs.tcl
11:11 am

gustafn

reduce visibility of internal functions

Options
    • -4
    • +4
    ./packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
10:27 am

gustafn

fix entry in listing of covered procs

Options
    • -1
    • +1
    ./packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl
10:27 am

gustafn

reduce verbosity

Options
    • -2
    • +4
    ./packages/xotcl-core/tcl/06-package-procs.tcl
10:26 am

gustafn

move function db_current_rdbms to acs-bootstrap installer to improve code locality

Options
    • -2
    • +6
    ./packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
    • -6
    • +1
    ./packages/acs-tcl/tcl/01-database-procs.tcl
10:19 am

gustafn

Cleanup of low-level DB-interace: use dict instead of list with fixed positions

VS: ----------------------------------------------------------------------

Options
    • -2
    • +2
    ./packages/acs-bootstrap-installer/acs-bootstrap-installer.info
    • -28
    • +48
    ./packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
    • -3
    • +3
    ./packages/acs-tcl/acs-tcl.info
    • -2
    • +2
    ./packages/acs-tcl/tcl/01-database-procs.tcl
Sunday 28 Feb 2021
10:56 pm

gustafn

reduce usage of ad_arg_parser by using c-level implementation; fixes as well broken cases of bind-var handling

Options
    • -46
    • +23
    ./packages/acs-tcl/tcl/01-database-procs.tcl
10:53 pm

gustafn

added test cases for db_0or1row and db_1row

Options
    • -1
    • +103
    ./packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
10:27 pm

gustafn

whitespace changes

Options
    • -9
    • +9
    ./packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
10:27 pm

gustafn

add test cases for db_list*

Options
    • -1
    • +33
    ./packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
10:24 pm

gustafn

reduce verbosity

Options
    • -2
    • +2
    ./packages/acs-tcl/tcl/test/doc-check-procs.tcl
5:56 pm

gustafn

whitespace changes

Options
    • -1
    • +2
    ./packages/acs-automated-testing/tcl/coverage-procs.tcl
    • -4
    • +4
    ./packages/acs-automated-testing/tcl/example-procs.tcl
    • -5
    • +5
    ./packages/acs-automated-testing/www/index.tcl
    • -3
    • +5
    ./packages/acs-automated-testing/www/server.tcl
    • -2
    • +2
    ./packages/acs-automated-testing/www/admin/index.tcl
    • -1
    • +1
    ./packages/acs-automated-testing/www/admin/proc-coverage.tcl
    • -87
    • +87
    ./packages/acs-automated-testing/www/admin/record-test.tcl
    • -3
    • +3
    ./packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl