• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
extended regression test: increase coverage of page contract filters

    • -32
    • +43
    ./packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
fix util::external_url_p when security::locations returns empty element

    • -1
    • +4
    ./packages/acs-tcl/tcl/utilities-procs.tcl
ease navigation: provide links to coverage pages

added new test cases for testing page contract filters

simplify and modernize Tcl code

improve navigation structure (context bar) and actions labeling

the reousrce actions is not necessary, since rerun performs an automatic resources

adjust to api-browser changes for trailing non-positional arguments

    • -20
    • +24
    ./packages/xotcl-core/tcl/03-doc-procs.tcl
Added support for trailing non-positional arguments

The change makes the old hack with the own trailing-argument-parser

"ad_arg_parser" obsolete by using directly the c-level argument parser

which is anyhow capable of handling trailing arguments. A few changes

were necessary for api doc to handle there trailing arguments as well.

The proc "db_string" is already converted to use native arguments.

    • -6
    • +5
    ./packages/acs-tcl/tcl/01-database-procs.tcl
added test case for db_string with various bind options

    • -4
    • +33
    ./packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
whitespace changes

move db-test case to db-regression test files

    • -181
    • +13
    ./packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -1
    • +184
    ./packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
remove unneeded method

    • -10
    • +1
    ./packages/xotcl-core/tcl/cr-procs.tcl
complete listing of covered procs in test cases

    • -0
    • +1
    ./packages/xowf/tcl/test/xowf-test-procs.tcl
use fine-grade percentage to color mapping

added a comment about the usefulness of ad_arg_parser

Fix for issue #3442 to support range types in .xql files

PostgreSQL supports range types since 9.5. When using range types,

square braces have to be used in SQL statements. Since OpenACS uses

always Tcl substitution in .xql files, and OpenACS does NOT allow

backslash substitution in these files, square brackets could not be

escaped and therefore not be used in .xql files so far. This change

allows now a developer to deactivate the substitution by passing

e.g. "-subst none" to the db_* command using the .xql file. Valid

values for "-subst" are "all", "none", "vars", and "commands", default

is "all" which is exactly the behavior of before. Therefore, this

change is fully backward compatible.

    • -55
    • +65
    ./packages/acs-tcl/tcl/01-database-procs.tcl
Remove leftovers

mark private functions as private

    • -3
    • +3
    ./packages/calendar/tcl/apm-callback-procs.tcl
    • -1
    • +1
    ./packages/search/tcl/apm-callback-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/apm-install-procs.tcl
whitespace changes

    • -4
    • +4
    ./packages/xotcl-core/tcl/05-db-procs.tcl
improve test coverage

    • -5
    • +5
    ./packages/xotcl-core/tcl/doc-procs.tcl
improve consistency of interface: use instance variable when no folder_id is provided

    • -1
    • +4
    ./packages/xotcl-core/tcl/cr-procs.tcl
Whitespace changes

Add new test 'acs_subsite_attributes' covering the 'attribute::add', 'attribute::exists_p' and 'attribute::delete' procs

Add editor hints

    • -1
    • +7
    ./packages/dotlrn/tcl/test/club-procs.tcl
Add 'dotlrn_club_new' test case, covering 'dotlrn_club::new', 'dotlrn_club::community_type' and 'dotlrn_community::get_community_type_from_community_id' procs

    • -0
    • +34
    ./packages/dotlrn/tcl/test/club-procs.tcl
file club-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./packages/dotlrn/tcl/test/club-procs.tcl
Whitespace changes

    • -213
    • +213
    ./packages/dotlrn/tcl/test/dotlrn-procs.tcl
Add trivial test 'dotlrn_community_types', covering 'dotlrn::community_type', 'dotlrn_class::community_type' and 'dotlrn_club::community_type' procs

    • -0
    • +19
    ./packages/dotlrn/tcl/test/dotlrn-procs.tcl
Delete extra pages

Add 'portal::list_pages_tcl_list' and 'portal::get_portal_template_id' to the 'create_portal_from_template' test case