• last updated 20 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
remove dependency on ad_ns_set_keys

    • -5
    • +8
    ./packages/categories/www/cadmin/master.tcl
improve listing of test coverage

    • -1
    • +25
    ./packages/news/tcl/test/news-db-test-init.tcl
mark functions called only internally as private

    • -1
    • +1
    ./packages/acs-admin/tcl/acs-admin-procs.tcl
    • -5
    • +7
    ./packages/acs-mail-lite/tcl/utils-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/acs-kernel-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/security-procs.tcl
bring test coverage to >50% by adding test cases and marking only locally called functions as private

    • -5
    • +5
    ./packages/acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +2
    ./packages/acs-lang/tcl/localization-procs.tcl
Add editor hints + whitespace changes

Remove leftover comment

Add 'attachments_basic_api' test case. Covers basic api of the attachments package: 'attachments::attach', 'attachments::unattach', 'attachments::get_all_attachments', 'attachments::get_attachments' and 'attachments::toggle_approved'

file attachments-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./packages/attachments/tcl/test/attachments-procs.tcl
mark unused function "_mr" as deprecated

    • -9
    • +8
    ./packages/acs-lang/tcl/lang-message-procs.tcl
mark unused functions as deprecated

    • -2
    • +2
    ./packages/acs-tcl/tcl/text-html-procs.tcl
    • -2
    • +6
    ./packages/acs-tcl/tcl/utilities-procs.tcl
improve comment

    • -4
    • +4
    ./packages/acs-tcl/tcl/security-procs.tcl
make use of built-in reverse proxy mode of newer versions of NaviServer

    • -3
    • +6
    ./packages/acs-tcl/tcl/00-icanuse-procs.tcl
overwork get_community_id once more. provide a shortcut is hopless situations, reduce potential warnings and improve comments

    • -11
    • +28
    ./packages/dotlrn/tcl/community-procs.tcl
make clear that get_community_id_from_url needs connection in case no URL is provided; provide shortcut, when determined package_id is empty

    • -4
    • +6
    ./packages/dotlrn/tcl/community-procs.tcl
    • -1
    • +1
    ./packages/survey/tcl/survey-procs.tcl
don't load deprecated code unless explicitly required

    • -1
    • +6
    ./packages/acs-tcl/tcl/sql-statement-procs.tcl
deprecate unused and untested code

    • -3
    • +8
    ./packages/acs-tcl/tcl/sql-statement-procs.tcl
fix deprecated function

remove call to deprecated proc

removed leftover from debugging

Fix correct-when test of empty input when constraint is "<" or "<=". Many thanks for Florian Mosböck for finding this.

    • -3
    • +3
    ./packages/xowiki/tcl/form-field-procs.tcl
provide more details in log message

    • -2
    • +2
    ./packages/xowiki/tcl/import-procs.tcl
mark in log-file begin and end of test cases, support multiple msg arguments in aa_log (similar to ns_log)

reduce verbosity

use tcl "max" idiom

    • -3
    • +2
    ./packages/xotcl-request-monitor/www/index.tcl
prefer ns_dbquotevalue over db_quote, mark latter as deprecated

    • -2
    • +2
    ./packages/acs-admin/tcl/apm-admin-procs.tcl
    • -3
    • +8
    ./packages/acs-tcl/tcl/01-database-procs.tcl
    • -2
    • +2
    ./packages/search/tcl/extra-args-procs.tcl
mark functions as private

improve listing of test coverage

    • -251
    • +8
    ./packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -0
    • +265
    ./packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
    • -37
    • +46
    ./packages/categories/tcl/test/categories-procs.tcl
  1. … 3 more files in changeset.
improve listing of test coverage

    • -8
    • +13
    ./packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
    • -41
    • +44
    ./packages/xowf/tcl/test/xowf-test-procs.tcl
    • -3
    • +3
    ./packages/xowiki/tcl/test/api-test-procs.tcl
    • -37
    • +41
    ./packages/xowiki/tcl/test/xowiki-test-procs.tcl
reduce verbosity

improve listing of test coverage

    • -0
    • +19
    ./packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
    • -1
    • +51
    ./packages/xowf/tcl/test/xowf-test-procs.tcl
    • -0
    • +12
    ./packages/xowiki/tcl/test/api-test-procs.tcl