• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Disable any conversion on the _name property (:name Page instance variable): this property is special and receives already its necessary conversion at validation time, happening before conversion time and should not be overridden

    • -2
    • +12
    ./packages/xowiki/tcl/form-field-procs.tcl
Implement 'language_specific' formfields and 'localized' FormPage properties:

- properties can be stored and retrieved specifying a -localized flag: this flag will make transparently store and retrieve the property value from a custom message key created in the acs-translations package referencing the FormPage. This localization mechanism is additional to that of language-prefixed pages and can address the need of multi-language content for non-prefixable objects such as folders

- via specifying language_specific in the formfield spec, one can enable this new localization mechanism when interacting with the FormPage via a xowiki::Form

TODO: handle export/import of pages (e.g. serializing available translation and generate the new message keys for the imported page), add some nicer UI to make the user aware of e.g. current translation context

    • -20
    • +31
    ./packages/xowiki/tcl/form-field-procs.tcl
    • -3
    • +31
    ./packages/xowiki/tcl/xowiki-procs.tcl
Reduce the threshold for images to be considered black:

in the wild it has happened that borderline-legitimate pictures of 7kbytes have triggered the check.

Fix missing column in sql statement

    • -1
    • +1
    ./packages/xotcl-core/tcl/ical-procs.tcl
prefer db_0or1row +"where exists" over db_string + "select case"

    • -5
    • +3
    ./packages/acs-subsite/tcl/attribute-procs.tcl
    • -8
    • +10
    ./packages/dotlrn/tcl/test/community-procs.tcl
    • -10
    • +10
    ./packages/new-portal/tcl/portal-procs.tcl
send also HEAD requests to the request monitor

reduce usage of idiom "select 1 from dual where exists" when not necessary

    • -11
    • +7
    ./packages/xotcl-core/tcl/05-db-procs.tcl
some packages have high number of instances: no need to aggregate over these

    • -1
    • +2
    ./packages/xotcl-core/tcl/06-param-procs.tcl
Pass missing object_id flag

    • -2
    • +4
    ./packages/acs-lang/tcl/lang-util-procs.tcl
Do not insert object_ids that do not exist in acs_object (leftover group message keys)

Replace limit with portable idiom

    • -4
    • +5
    ./packages/xotcl-core/tcl/05-db-procs.tcl
prefer ad_try, since it is silent, when action is ended by a script_abort

Fix oracle query as for most recent version limit is not supported

    • -4
    • +8
    ./packages/xotcl-core/tcl/05-db-procs.tcl
Go straight to the database with a portable query

    • -4
    • +6
    ./packages/xotcl-core/tcl/06-param-procs.tcl
Improve sql portability, reduce number of statements

Improve sql portability

    • -5
    • +7
    ./packages/acs-subsite/tcl/attribute-procs.tcl
    • -4
    • +6
    ./packages/acs-subsite/tcl/group-procs.tcl
    • -3
    • +6
    ./packages/acs-subsite/tcl/subsite-procs.tcl
Cleanup leftover query

Whitespace cleanup

    • -4
    • +4
    ./packages/acs-tcl/tcl/site-nodes-procs.tcl
Improve sql portability

    • -2
    • +5
    ./packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -4
    • +5
    ./packages/file-storage/www/folder-chunk.tcl
    • -2
    • +11
    ./packages/new-portal/tcl/portal-procs.tcl
    • -12
    • +0
    ./packages/new-portal/tcl/portal-procs.xql
Fix missing end

    • -2
    • +2
    ./packages/dotlrn/tcl/test/community-procs.tcl
Im prove sql portability

    • -5
    • +5
    ./packages/dotlrn/tcl/test/community-procs.tcl
Improve sql portability

    • -4
    • +4
    ./packages/acs-admin/www/apm/parameter-add.tcl
    • -5
    • +5
    ./packages/dotlrn/www/communities-chunk.tcl
    • -2
    • +4
    ./packages/xowiki/tcl/form-field-procs.tcl
Improve sql portability: oracle cannot select a boolean directly using exists

Whitespace cleanup

Make sql portable

Improve sql portability

Replace limit idiom with portable idiom

Avoid the not portable limit idiom, just kill the recursive part using the flag instead

...although one should point out that Oracle does not support the boolean type...

    • -5
    • +4
    ./packages/acs-tcl/tcl/site-nodes-procs.tcl
Improve portability of test code

Replace limit with a portable idiom

    • -5
    • +5
    ./packages/acs-subsite/tcl/group-procs.tcl