• last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed broken link in login and logout widgets

The problem were the links for the main subsite, since on the main subsite,

the resulting link is e.g. //register/logout, which is intpreted as

an URL without a schema (e.g. //openacs.org), leading the errors.

removed onsolte comments

added same-site lax for js-handling of cookies

    • -1
    • +2
    ./cookie-consent/tcl/cookie-consent-procs.tcl
fix false positive of regression test

    • -1
    • +1
    ./acs-templating/tcl/richtext-procs.tcl
fix warning (including some false positives) in regression test

    • -1
    • +1
    ./xowiki/tcl/personal-notification-procs.tcl
acs::test::user::delete: added flag -delete_created_acs_objects and fix regression test for file-storage

    • -2
    • +2
    ./acs-automated-testing/acs-automated-testing.info
    • -3
    • +10
    ./acs-automated-testing/tcl/aa-test-procs.tcl
    • -1
    • +2
    ./acs-automated-testing/tcl/coverage-procs.tcl
    • -2
    • +14
    ./acs-automated-testing/www/admin/index.tcl
    • -3
    • +4
    ./file-storage/tcl/test/file-storage-procs.tcl
Fixed calling info in call-graph, marked verbose test as "stress"

    • -4
    • +7
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
modernize adp file

    • -1
    • +1
    ./survey/www/admin/site-wide-survey.adp
    • -1
    • +1
    ./survey/www/admin/view-text-responses.adp
removed code factored out to the separate "captcha" package

    • -2
    • +0
    ./acs-templating/catalog/acs-templating.de_DE.ISO-8859-1.xml
    • -2
    • +0
    ./acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml
    • -2
    • +0
    ./acs-templating/catalog/acs-templating.it_IT.ISO-8859-1.xml
    • -12
    • +0
    ./acs-templating/sql/oracle/captcha-create.sql
    • -353
    • +0
    ./acs-templating/tcl/captcha-procs.tcl
    • -163
    • +0
    ./acs-templating/tcl/test/captcha-procs.tcl
Added the message catalog and the fonts to this package to keep things separated.

TODO: The message key "Please_enter_the_captcha" is not used on upstream code and could be deleted.

maybe, something from the downstram captcha code was not provide upstream.

file captcha.de_DE.ISO-8859-1.xml was initially added on branch oacs-5-10.

    • -0
    • +0
    ./captcha/catalog/captcha.de_DE.ISO-8859-1.xml
file LiberationSans-Regular.ttf was initially added on branch oacs-5-10.

    • -0
    • +0
    ./captcha/resources/fonts/LiberationSans-Regular.ttf
file captcha.it_IT.ISO-8859-1.xml was initially added on branch oacs-5-10.

    • -0
    • +0
    ./captcha/catalog/captcha.it_IT.ISO-8859-1.xml
file captcha.en_US.ISO-8859-1.xml was initially added on branch oacs-5-10.

    • -0
    • +0
    ./captcha/catalog/captcha.en_US.ISO-8859-1.xml
Factored out captcha package from acs-templating, since it introduces too many external dependencies

Furthermore, as it is, this does not work under macOS (and probably not on *BSD, or windows)

and breaks regression test.

    • -0
    • +12
    ./captcha/sql/oracle/captcha-create.sql
    • -0
    • +5
    ./captcha/sql/postgresql/captcha-drop.sql
    • -0
    • +163
    ./captcha/tcl/test/captcha-procs.tcl
file captcha.info was initially added on branch oacs-5-10.

file captcha-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./captcha/tcl/captcha-procs.tcl
    • -0
    • +0
    ./captcha/tcl/test/captcha-procs.tcl
file captcha-drop.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./captcha/sql/oracle/captcha-drop.sql
    • -0
    • +0
    ./captcha/sql/postgresql/captcha-drop.sql
file captcha-create.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./captcha/sql/oracle/captcha-create.sql
    • -0
    • +0
    ./captcha/sql/postgresql/captcha-create.sql
remove deprecated call

improve comments, such that is is clear what command to use instead

    • -4
    • +4
    ./acs-templating/tcl/deprecated-procs.tcl
deactivate captcha test for the time being

    • -0
    • +1
    ./acs-templating/tcl/test/captcha-procs.tcl
we need the upgrade script, since the automatic aler just kicks in, when the constraint does not exist. Antonio was right.

Nevertheless, it would be a nice feature, if the ORM would handle this.

remove useless upgrade scripts (xotcl-core does this automatically on reloads)

Document and enforce expected behavior when Forms are deleted: this is forbidden and returns an error as long as they have instances

    • -0
    • +139
    ./xowiki/tcl/test/xowiki-test-procs.tcl
Follow up of https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20220622174910

In the end we need the upgrade logic, as the ORM will kick in only if the column is just being created

Do not attempt to load downstream-only workflows at startup

Downstream, the cod will stay as it is and maintained as a local modification

reduce verbosity

reduce verbosity for legacy workflows

Upgrade to CKEditor 4.19.0 (released on 2022-05-24)

    • -2
    • +2
    ./richtext-ckeditor4/richtext-ckeditor4.info
    • -3
    • +3
    ./richtext-ckeditor4/tcl/richtext-procs.tcl