• last updated 18 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecate acs_message_id contract filter, superseded by object_type

    • -2
    • +6
    ./acs-messaging/tcl/acs-messaging-procs.tcl
Allow to deprecate ad_page_contract_filters, improve doc

    • -4
    • +11
    ./acs-tcl/tcl/tcl-documentation-procs.tcl
Increase coverage

    • -1
    • +6
    ./categories/tcl/test/categories-procs.tcl
Increase coverage

    • -7
    • +31
    ./categories/tcl/test/categories-procs.tcl
Make category::page_url private: it is meant to be used via the service contracts and not directly

Increase proc coverage

    • -2
    • +43
    ./categories/tcl/test/categories-procs.tcl
Pass the name down to the db_multirow api, just setting the multirow name is not sufficient to "rename" a multirow

Test api to map an object to a category, which exposes a bug in category::get_mapped_categories_multirow

    • -1
    • +88
    ./categories/tcl/test/categories-procs.tcl
Increase test coverage

    • -4
    • +12
    ./categories/tcl/test/categories-procs.tcl
Deprecate color widget api, superseded by HTML5 features

Increase proc coverage

    • -0
    • +50
    ./acs-tcl/tcl/test/navigation-procs.tcl
Increase test coverage

Fix reference in doc

Deprecate ad_approval_system_inuse_p

Fix implementation of ad_acs_admin_node so that the node_id is returned as stated in the doc

For the one occurrence that treated this proc as boolean, the result will be the same (e.g. 0 = false and any other id = true)

    • -15
    • +12
    ./acs-tcl/tcl/acs-kernel-procs.tcl
Test some system information api

The test shows that ad_acs_admin_node has so far returned a boolean, countrary to what the documentation says

    • -0
    • +52
    ./acs-tcl/tcl/test/acs-kernel-procs.tcl
file acs-kernel-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-tcl/tcl/test/acs-kernel-procs.tcl
When demoting a user, flush the permissions cache as well

    • -1
    • +7
    ./acs-tcl/tcl/community-core-procs.tcl
Test demoting/promoting of a user + a buch of other api

This test fails now when checking if a demoted user is still an swa, one needs to flush the permissions as well

    • -1
    • +103
    ./acs-tcl/tcl/test/community-core-test-procs.tcl
Test acs_user::ScreenName

Test acs_object_type_hierarchy

    • -1
    • +76
    ./acs-tcl/tcl/test/object-test-case-procs.tcl
Test acs_object_type::get_table_name

    • -1
    • +21
    ./acs-tcl/tcl/test/object-test-case-procs.tcl
Test acs_object_name api

    • -1
    • +21
    ./acs-tcl/tcl/test/object-test-case-procs.tcl
Test acs_magic_object

    • -1
    • +18
    ./acs-tcl/tcl/test/object-test-case-procs.tcl
Test various URL generating procs

file defs-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-tcl/tcl/test/defs-procs.tcl
Deprecate util_get_current_url, superseded by ad_return_url

Deprecate export_entire_form_as_url_vars and replace occurrences, add a new -formvars flag to export vars to implement the behavior of the proc, that is, export a subset of the variables coming from the current request

    • -2
    • +2
    ./acs-admin/www/users/complex-search.tcl
    • -3
    • +3
    ./acs-tcl/tcl/request-processor-procs.tcl
Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

    • -2
    • +2
    ./acs-admin/www/users/complex-search.tcl
    • -2
    • +2
    ./acs-developer-support/www/request-info.tcl
    • -2
    • +2
    ./acs-templating/tcl/dimensional-procs.tcl
    • -2
    • +2
    ./general-comments/www/view-comment.tcl
    • -2
    • +2
    ./general-comments/www/admin/index.tcl
Reimplement util_subset_p

    • -39
    • +25
    ./acs-tcl/tcl/utilities-procs.tcl