• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

    • -2
    • +2
    ./acs-admin/www/users/complex-search.tcl
    • -2
    • +2
    ./acs-developer-support/www/request-info.tcl
    • -2
    • +2
    ./acs-templating/tcl/dimensional-procs.tcl
    • -2
    • +2
    ./general-comments/www/view-comment.tcl
    • -2
    • +2
    ./general-comments/www/admin/index.tcl
Reimplement util_subset_p

    • -39
    • +25
    ./acs-tcl/tcl/utilities-procs.tcl
Deprecate util_report_successful_library_load

Deprecate util_commify_number, replace occurrences and translate automated tests

    • -3
    • +3
    ./acs-subsite/www/admin/group-types/delete.tcl
    • -2
    • +2
    ./acs-subsite/www/admin/rel-segments/one.tcl
    • -20
    • +20
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
Whitespace cleanup

    • -2
    • +2
    ./acs-subsite/www/admin/rel-segments/one.tcl
Deprecate export_entire_form

Deprecate util_AnsiDatetoPrettyDate

Deprecate util_report_library_entry

Formatting changes

    • -14
    • +30
    ./acs-tcl/tcl/utilities-procs.tcl
Deprecate util::string_check_urlsafe

Simplify implementation

After some experiments, reinstate the faster version of util_sets_equal_p: this wins (~20% faster) in particular when the sets to be compared are larger

Cleanup duplicated and slower proc definition

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

    • -11
    • +8
    ./acs-templating/tcl/list-procs.tcl
Use faster idiom to tell if a string is only space

    • -2
    • +2
    ./acs-automated-testing/www/admin/testcase.tcl
Fall back to en_US also when a value for nls_language is there, but empty

Use api to determine whether a field is disabled, as the "disabled" variable will always be set now

Claim additional coverage

    • -1
    • +4
    ./acs-templating/tcl/test/parse-test-procs.tcl
Count already exisring handlers before introducing new ones

    • -4
    • +11
    ./acs-templating/tcl/test/parse-test-procs.tcl
Improve acs::test::form_reply so that when the attributes of a file upload (*.tmpfile or *.content-type) are part of the update argument, it will switch automatically to a multipart request and implement a "real" file upload

This is important on newer NaviServer versions that will reject any *.tmpfile parameter in a request that was not produced internally after a file upload

    • -14
    • +45
    ./acs-automated-testing/tcl/aa-test-procs.tcl
    • -31
    • +0
    ./acs-templating/tcl/test/file-procs.tcl
add the amount of questions from the exam in the title

Test also nonce rendering

    • -1
    • +7
    ./acs-templating/tcl/test/parse-test-procs.tcl
Make test more precise

    • -9
    • +12
    ./acs-templating/tcl/test/parse-test-procs.tcl
Test a bunch more api

    • -1
    • +146
    ./acs-templating/tcl/test/parse-test-procs.tcl
Test template::adp_level, fix test coverage declaration

    • -3
    • +36
    ./acs-templating/tcl/test/parse-test-procs.tcl
Test template::adp_parse_string

    • -1
    • +16
    ./acs-templating/tcl/test/parse-test-procs.tcl
Deprecate template::adp_levels, found nowhere in the upstream codebase and superseded by template::adp_level

Increase proc coverage

    • -39
    • +62
    ./acs-templating/tcl/test/parse-test-procs.tcl
State additional proc coverage, improve documentation

    • -0
    • +1
    ./acs-templating/tcl/test/file-procs.tcl
    • -1
    • +2
    ./acs-templating/tcl/test/parse-test-procs.tcl
Make template::head::prepare_multirows a private interface: its stated purpose is to be used inside of the blank-master and it has no practical use otherwise