• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecate template::adp_levels, found nowhere in the upstream codebase and superseded by template::adp_level

Increase proc coverage

    • -39
    • +62
    ./acs-templating/tcl/test/parse-test-procs.tcl
State additional proc coverage, improve documentation

    • -0
    • +1
    ./acs-templating/tcl/test/file-procs.tcl
    • -1
    • +2
    ./acs-templating/tcl/test/parse-test-procs.tcl
Make template::head::prepare_multirows a private interface: its stated purpose is to be used inside of the blank-master and it has no practical use otherwise

Make adp_parse_ad_conn_file a private interface: its stated purpose is to be registered via rp_register_extension_handler in acs-templating/tcl/acs-integration-init.tcl and it has no practical use otherwise

    • -3
    • +3
    ./acs-templating/tcl/acs-integration-procs.tcl
Test ad_return_template

    • -5
    • +76
    ./acs-templating/tcl/test/acs-integration-procs.tcl
Reuse computation

    • -2
    • +2
    ./acs-subsite/www/user/portrait/index.tcl
Avoid catch where a more appropriate idiom exists

    • -8
    • +10
    ./acs-subsite/www/user/portrait/index.tcl
Improve documentation

    • -1
    • +6
    ./acs-subsite/www/user/portrait/index.tcl
Cleanup case

    • -4
    • +0
    ./acs-subsite/www/user/portrait/index.adp
Whitespace cleanup

    • -3
    • +3
    ./acs-subsite/www/user/portrait/index.tcl
Harden page contract

    • -10
    • +2
    ./acs-subsite/www/user/portrait/index.tcl
Extend regression test

    • -5
    • +64
    ./acs-tcl/tcl/test/http-client-procs.tcl
if truncate_len is provided we have to call util_close_html_tags for truncating the string

Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

    • -17
    • +21
    ./acs-tcl/tcl/http-client-procs.tcl
    • -0
    • +59
    ./acs-tcl/tcl/test/http-client-procs.tcl
    • -1
    • +1
    ./file-storage/tcl/test/webtest-procs.tcl
Reimplement upload automated test using a real multipart request, as newer naviserver will reject handcrafted .tmpfile parameters

    • -9
    • +19
    ./file-storage/tcl/test/webtest-procs.tcl
Extend util::http::post_payload and util::http::post to receive form varaibles also in dict form, update documentation

    • -22
    • +58
    ./acs-tcl/tcl/http-client-procs.tcl
Cleanup leftover arguments

Test ad_return_exception_template

    • -0
    • +76
    ./acs-templating/tcl/test/acs-integration-procs.tcl
file acs-integration-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-templating/tcl/test/acs-integration-procs.tcl
Deprecate acs-subsite/www/shared/db-error and move a copy to acs-subsite/lib/shared/db-error, replace occurrences, adjust dependencies

    • -0
    • +20
    ./acs-subsite/lib/shared/db-error.adp
    • -0
    • +1
    ./dotlrn-homework/dotlrn-homework.info
    • -2
    • +2
    ./dotlrn-homework/www/folder-create.tcl
file db-error.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-subsite/lib/shared/db-error.adp
Make this template more robust to the casual invocation from the outside

This should actually be moved to the lib directory, as it is intended as an include

Whitespace changes

    • -14
    • +15
    ./acs-subsite/www/shared/db-error.adp
Test ad_dimensional_sql

    • -0
    • +45
    ./acs-templating/tcl/test/dimensional-procs.tcl
Test ad_dimensional

    • -0
    • +69
    ./acs-templating/tcl/test/dimensional-procs.tcl
file dimensional-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-templating/tcl/test/dimensional-procs.tcl
Make spelling consistent

    • -1
    • +1
    ./acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
Quote unallowed HTML according to acs-tcl.documentation__check_proc_doc

Rename proc according to convention enforced in acs-tcl: naming__proc_naming