OpenACS / openacs-4

packages

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 139
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 5,070,804
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 30 Aug 2022
3:08 pm

antoniop

Reinstate the notnull validation constraint where missing

Options
    • -2
    • +2
    ./forums/lib/message/post.tcl
    • -2
    • +2
    ./forums/lib/message/threads-chunk.tcl
    • -2
    • +2
    ./forums/lib/user/post-history-chunk.tcl
    • -1
    • +1
    ./forums/www/forum-view-statistic.tcl
    • -2
    • +2
    ./forums/www/forum-view.tcl
    • -1
    • +1
    ./forums/www/load-message-content.tcl
    • -1
    • +1
    ./forums/www/mark-all-read.tcl
    • -2
    • +2
    ./forums/www/message-email.tcl
    • -2
    • +2
    ./forums/www/user-history.tcl
    • -2
    • +2
    ./forums/www/admin/forum-disable.tcl
    • -2
    • +2
    ./forums/www/admin/forum-edit.tcl
    • -2
    • +2
    ./forums/www/admin/forum-enable.tcl
    • -2
    • +2
    ./forums/www/admin/permissions-user-add.tcl
    • -5
    • +5
    ./forums/www/admin/subscribe-others-2.tcl
    • -2
    • +2
    ./forums/www/admin/subscribe-others.tcl
  16. … 10 more files in changeset.
2:22 pm

gustafn

re-add notnull value constraint on message_id

This constraint was removed about 14 days ago. Without this constraint,

errors like the following will show up....

[30/Aug/2022:14:07:29.820625][3102633.7f152c28d700][-conn:openacs.org:default:0:196214-] Error: rp_handler no-script-abort: errorMsg can't read "message(forum_id)": no such variable while serving GE

T /forums/message-view?message_id HTTP/1.1

: ad_url </forums/message-view> maps to file </var/www/openacs.org/packages/forums/www/message-view.adp>

: TCL LOOKUP VARNAME message

: can't read "message(forum_id)": no such variable

: while executing

: "forum::get -forum_id $message(forum_id) -array forum"

Probably, in many more cases, the incorrect removal of the notnull constrain performed by [1]

requires the same fix.

[1] https://github.com/openacs/forums/commit/c403e3134ce4e73ba94a80540a8b0f3cb1651ed0#diff-d35c736495ede0174fb39791ab660c5cd1a4ca467db2c4741cfc935167d7e5a8

Options
    • -2
    • +2
    ./forums/www/message-view.tcl
2:03 pm

gustafn

handle clases, where "nt_load_end" is not provided

Options
    • -2
    • +6
    ./boomerang/tcl/boomerang-procs.tcl
1:13 pm

hectorr

Replace message keys inside message keys. Many thanks to Monika Andergassen.

Options
    • -2
    • +2
    ./acs-subsite/acs-subsite.info
    • -1
    • +1
    ./acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
    • -1
    • +1
    ./acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
    • -1
    • +1
    ./acs-subsite/catalog/acs-subsite.it_IT.ISO-8859-1.xml
    • -1
    • +1
    ./acs-subsite/catalog/acs-subsite.ru_RU.utf-8.xml
12:20 pm

antoniop

Harden page contract

Options
    • -9
    • +2
    ./acs-subsite/www/user/portrait/upload.tcl
12:15 pm

antoniop

Make script more robust to agents that won't specify the tmpfile via using the api to retrieve the file information

Options
    • -6
    • +14
    ./acs-subsite/www/user/portrait/upload.tcl
11:38 am

antoniop

Fix typo

Options
    • -2
    • +4
    ./acs-templating/tcl/element-procs.tcl
11:35 am

antoniop

template::element validation reform: do not run custom user-defined validation on fields that are not formally correct

Rationale: user-defined validation often assumes some basic consistency of the submitted value. When this is not formally correct, users might have to reimplement the whole formal validation in their custom fields in order to prevent exceptions. By preventing their custom blocks from being executed, users can rely on their custom fields to be run only against sane values.

Options
    • -20
    • +38
    ./acs-templating/tcl/element-procs.tcl
11:22 am

antoniop

Restore formatting in procs doc

Options
    • -79
    • +99
    ./acs-templating/tcl/element-procs.tcl
10:50 am

antoniop

Normalize indentation according to editor hints

Options
    • -366
    • +366
    ./acs-templating/tcl/element-procs.tcl
10:47 am

gustafn

comment tags, which are NOT supported by HTML5, allow "abbr" in enhanced text

Options
    • -3
    • +13
    ./acs-tcl/tcl/text-html-procs.tcl
10:24 am

antoniop

Fix query syntax

Options
    • -3
    • +4
    ./new-portal/tcl/portal-procs.tcl
Monday 29 Aug 2022
9:22 pm

gustafn

improve styling for Bootstrap 5

Options
    • -6
    • +7
    ./xowf/tcl/test-item-procs.tcl
    • -2
    • +13
    ./xowf/www/resources/test-item.css
7:47 pm

gustafn

provide exception handler for cleanup

Options
    • -14
    • +19
    ./boomerang/tcl/boomerang-procs.tcl
7:39 pm

gustafn

further improve recording, when just navigational timing is effective

Options
    • -3
    • +9
    ./boomerang/tcl/boomerang-procs.tcl
6:14 pm

gustafn

Improved robustness

When not nt_con_st or nt_con_end is provided, set nt_tcp_time to 0

Options
    • -13
    • +27
    ./boomerang/tcl/boomerang-procs.tcl
5:15 pm

gustafn

Reduce verbosity

Options
    • -8
    • +2
    ./acs-tcl/tcl/text-html-procs.tcl
4:50 pm

antoniop

Test template::util::list_to_lookup

Options
    • -1
    • +30
    ./acs-templating/tcl/test/util-procs.tcl
4:30 pm

antoniop

Deprecate template::util::nvl

Options
    • -2
    • +6
    ./acs-templating/tcl/util-procs.tcl
    • -29
    • +1
    ./acs-templating/tcl/test/util-procs.tcl
4:25 pm

antoniop

Deprecate template::util::list_to_array

Options
    • -2
    • +8
    ./acs-templating/tcl/util-procs.tcl
4:17 pm

antoniop

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

Options
    • -2
    • +2
    ./acs-authentication/tcl/authority-procs.tcl
    • -2
    • +2
    ./acs-authentication/tcl/sync-procs.tcl
    • -5
    • +5
    ./acs-authentication/tcl/test/sync-test-procs.tcl
    • -2
    • +2
    ./acs-developer-support/www/request-info.tcl
    • -2
    • +2
    ./acs-lang/tcl/lang-catalog-procs.tcl
    • -3
    • +3
    ./acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +2
    ./acs-lang/www/admin/locale-delete.tcl
    • -2
    • +2
    ./acs-lang/www/admin/message-delete.tcl
    • -1
    • +1
    ./acs-lang/www/admin/message-undelete.tcl
    • -1
    • +1
    ./acs-lang/www/admin/message-unregister.tcl
    • -5
    • +4
    ./acs-mail-lite/tcl/test/email-inbound-procs.tcl
    • -1
    • +1
    ./acs-subsite/lib/login.tcl
    • -2
    • +2
    ./acs-subsite/tcl/group-procs.tcl
    • -2
    • +2
    ./acs-subsite/tcl/subsite-navigation-procs.tcl
    • -2
    • +2
    ./acs-subsite/tcl/subsite-procs.tcl
  16. … 19 more files in changeset.
3:35 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./acs-tcl/tcl/text-html-procs.tcl
3:02 pm

gustafn

implemented ad_html_security_check based on ns_parsehtml

Options
    • -44
    • +144
    ./acs-tcl/tcl/text-html-procs.tcl
3:00 pm

antoniop

Shorten idiom

Options
    • -11
    • +2
    ./acs-templating/tcl/util-procs.tcl
2:54 pm

antoniop

Test template::util::is_nil

Options
    • -1
    • +24
    ./acs-templating/tcl/test/util-procs.tcl
1:53 pm

gustafn

Use "ns_parsehtml" for speed and correctness when available

The new NaviServer built-in command "ns_parsehtml" is used on

several occasions in the code when available, namely in

- util_close_html_tags

- escaping disallowed HTML tags in ad_text_to_html

- util_close_html_tags

The command "util_close_html_tags" has a long history of troubles,

since it was implemented originally based on regular expressions. It

was reported in Jan 2009, that the function took on certain forums

entries 6 to 9 hours (e.g. /forums/message-view?message_id=357753) to

finish. Therefore, at this time a quick version based on tdom was

introduced, which reduced at that time the performance to 7.3

seconds. However, the tdom-based version tend to fail on invalid HTML,

so it could cover only a few cases. The new "ns_parsehtml" is more

robust and works very stable on openacs.org with the know problem

cases. Furthermore, this version is also significantly faster than the

tdom version.

Options
    • -33
    • +269
    ./acs-tcl/tcl/text-html-procs.tcl
    • -6
    • +17
    ./acs-tcl/tcl/test/html-conversion-procs.tcl
1:02 pm

antoniop

Fix doc

Options
    • -1
    • +1
    ./acs-content-repository/www/doc/guide/publish.adp
1:00 pm

antoniop

Deprecate template::util::array_to_vars and template::util::vars_to_array: their functionality can be easily inlined by using the array command

Options
    • -1
    • +3
    ./acs-content-repository/tcl/filter-procs.tcl
    • -2
    • +1
    ./acs-content-repository/www/doc/guide/publish.adp
    • -3
    • +2
    ./acs-content-repository/www/doc/guide/publish.html
    • -3
    • +11
    ./acs-templating/tcl/util-procs.tcl
12:34 pm

gustafn

improve spelling

Options
    • -3
    • +3
    ./acs-tcl/tcl/deprecated-procs.tcl
    • -2
    • +2
    ./acs-tcl/tcl/security-procs.tcl
    • -3
    • +3
    ./acs-tcl/tcl/tcl-documentation-procs.tcl
    • -1
    • +1
    ./acs-tcl/tcl/test/acs-db-00-procs.tcl
    • -1
    • +1
    ./acs-tcl/tcl/test/apm-install-procs.tcl
    • -10
    • +69
    ./acs-tcl/tcl/test/html-conversion-procs.tcl
    • -7
    • +7
    ./acs-tcl/tcl/test/object-test-case-procs.tcl
11:51 am

antoniop

Use existing api to tell whether a formfield is disabled or not and to set/unset disabled on a field, handle the case of checkboxes and select fields, where the attribute should not be set whe it is false (e.g. disabled=0 == disabled)

This fixes upstream automated tests on xowiki and xowf

Options
    • -21
    • +31
    ./xowiki/tcl/form-field-procs.tcl
    • -9
    • +9
    ./xowiki/tcl/xowiki-www-procs.tcl