OpenACS / openacs-4

packages

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 139
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 5,070,804
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Aug 2022
3:12 pm

antoniop

Declare proc coverage

Options
    • -0
    • +2
    ./acs-tcl/tcl/test/http-client-procs.tcl
    • -0
    • +1
    ./acs-templating/tcl/test/file-procs.tcl
3:09 pm

antoniop

Factor the payload building behavior in util::http::post into its own proc, so that it can be reused elsewhere

Options
    • -69
    • +170
    ./acs-tcl/tcl/http-client-procs.tcl
2:45 pm

antoniop

Make also sure the tmpfile from the widget exists beforehand, when validating: we don't want users to "explore" our tmpdir with bogus values that just look sane

Options
    • -3
    • +3
    ./acs-templating/acs-templating.info
    • -1
    • +1
    ./acs-templating/tcl/file-procs.tcl
    • -11
    • +24
    ./acs-templating/tcl/test/data-procs.tcl
2:37 pm

antoniop

Add must_exist flag to enforce a safe tmpfile to already exist

Options
    • -2
    • +2
    ./acs-tcl/acs-tcl.info
    • -4
    • +9
    ./acs-tcl/tcl/security-procs.tcl
    • -1
    • +6
    ./acs-tcl/tcl/test/security-procs.tcl
1:44 pm

gustafn

Fixed bug in util_convert_line_breaks_to_html

The code deleted spaces around certain tags, while - according to the

documentation, only line breaks should be removed from there.

Extended regression test.

Options
    • -4
    • +5
    ./acs-tcl/tcl/text-html-procs.tcl
    • -5
    • +14
    ./acs-tcl/tcl/test/html-conversion-procs.tcl
1:37 pm

antoniop

Improve doc

Options
    • -3
    • +3
    ./acs-templating/tcl/file-procs.tcl
1:34 pm

antoniop

Revert to previous template::widget::file behavior of accepting input in a form of a list of 3 elements (e.g. without a .tmpfile in the request), but introduce validation so that we enforce all widget values to be in the proper format and the files to be "safe"

Options
    • -3
    • +3
    ./acs-templating/acs-templating.info
    • -0
    • +1
    ./acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml
    • -42
    • +83
    ./acs-templating/tcl/file-procs.tcl
    • -7
    • +14
    ./acs-templating/tcl/test/data-procs.tcl
    • -0
    • +244
    ./acs-templating/tcl/test/file-procs.tcl
1:34 pm

antoniop

file file-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./acs-templating/tcl/test/file-procs.tcl
1:29 pm

antoniop

Bring test closer to reality

Options
    • -6
    • +14
    ./file-storage/tcl/test/webtest-procs.tcl
1:25 pm

antoniop

Introduce security::safe_tmpfile_p checking whether a file belongs to the configured tmpfolder and respects other constraints

The plan is to use it to improve input validations

Options
    • -2
    • +2
    ./acs-tcl/acs-tcl.info
    • -1
    • +54
    ./acs-tcl/tcl/security-procs.tcl
    • -0
    • +45
    ./acs-tcl/tcl/test/security-procs.tcl
11:53 am

gustafn

Fixed serious bug killing at least short-text questions in inclass exam

The bug was introduced in [1], by testing for the existence of the

disabled attribute, and when it exists, it was omitting values

reading. The problem is that when form-fields are reset, the

"disabled" attribute is set to 0, leading the exists check to

succeed. In essence, This change sets now the default value of the

form-field to "0", such that it is safe to test it everywhere.

Originally, it was not set by default to save resources (memory and

processing power), but this requires a more careful analysis when

changes happen.

[1] https://fisheye.openacs.org/browse/OpenACS/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl?r1=1.368.2.125&r2=1.368.2.126

Options
    • -2
    • +2
    ./xowiki/tcl/form-field-procs.tcl
    • -12
    • +11
    ./xowiki/tcl/xowiki-www-procs.tcl
Wednesday 24 Aug 2022
7:45 pm

gustafn

Tighten test for is_wf_instance

Previously, the test was based on setting of state and FormPage.

In cases, where plain FormPages are used inside an xowf package

this test was leading to wrong results.

Options
    • -1
    • +4
    ./xowf/tcl/xowf-procs.tcl
    • -0
    • +1
    ./xowf/tcl/test/test-item-procs.tcl
6:50 pm

gustafn

base all timings on NavigationTiming plugin to get closer to previous behavior

Options
    • -5
    • +13
    ./boomerang/tcl/boomerang-procs.tcl
    • -0
    • +456
    ./boomerang/www/resources/plugins-1.737.0/navtiming.js
6:50 pm

gustafn

file navtiming.js was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./boomerang/www/resources/plugins-1.737.0/navtiming.js
6:00 pm

gustafn

improved error message

make clear, what the name and what the item_id in the message are

Options
    • -2
    • +2
    ./xowiki/tcl/folder-procs.tcl
5:59 pm

gustafn

use new path xowiki/lib/portlets/ instead of .../www/...

Options
    • -3
    • +4
    ./xowiki/tcl/xowiki-procs.tcl
5:57 pm

gustafn

comment method

Options
    • -1
    • +4
    ./xowiki/tcl/xowiki-uploader-procs.tcl
4:51 pm

gustafn

Deactivated script-dynamic again

activating "script-dynamic" for script-src prevents resources as the following from loading

<script type="text/javascript" src="/resources/xowiki/bootstrap-treeview/1.2.0/bootstrap-treeview.min.js" nonce="F8843D5CD542FB1CDB4C94C5D13C4E5ECC2E1DCA">

Options
    • -2
    • +2
    ./acs-tcl/tcl/security-procs.tcl
4:30 pm

gustafn

improve test coverage of apm_* API

Options
    • -0
    • +24
    ./acs-tcl/tcl/test/apm-procs.tcl
4:28 pm

gustafn

reduce verbosity

Options
    • -1
    • +1
    ./openacs-bootstrap5-theme/resources/widgets/login.tcl
2:13 pm

gustafn

added test for checking documentation in regard of valid HTML markup

Options
    • -2
    • +53
    ./acs-tcl/tcl/test/doc-check-procs.tcl
10:58 am

antoniop

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

Options
    • -19
    • +4
    ./acs-templating/tcl/file-procs.tcl
    • -1
    • +121
    ./file-storage/tcl/test/file-storage-procs.tcl
    • -1
    • +5
    ./file-storage/www/file-add.tcl
9:05 am

antoniop

Whitespace cleanup

Options
    • -6
    • +6
    ./file-storage/tcl/test/webtest-procs.tcl
Tuesday 23 Aug 2022
9:10 pm

gustafn

replace occurrences of <br/> in api doc strings

Options
    • -8
    • +8
    ./acs-mail-lite/tcl/email-inbound-procs.tcl
    • -12
    • +16
    ./xotcl-core/tcl/cr-procs.tcl
    • -9
    • +12
    ./xotcl-core/tcl/generic-procs.tcl
8:44 pm

gustafn

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

Options
    • -3
    • +3
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -1
    • +1
    ./acs-content-repository/tcl/publish-procs.tcl
    • -7
    • +7
    ./acs-lang/tcl/lang-util-procs.tcl
    • -2
    • +4
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -3
    • +3
    ./acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +2
    ./acs-mail-lite/tcl/legacy-inbound-procs.tcl
    • -6
    • +7
    ./acs-tcl/tcl/deprecated-procs.tcl
    • -5
    • +9
    ./acs-tcl/tcl/security-procs.tcl
    • -17
    • +22
    ./acs-tcl/tcl/tcl-documentation-procs.tcl
    • -7
    • +6
    ./acs-tcl/tcl/utilities-procs.tcl
    • -10
    • +18
    ./notifications/tcl/notification-callback-procs.tcl
    • -5
    • +6
    ./tsearch2-driver/tcl/tsearch2-driver-procs.tcl
    • -0
    • +8
    ./xowf/tcl/test-item-procs.tcl
5:39 pm

antoniop

Incorporate feedback from downstream penetration tests:

do not skip basic validation in the file widget when a tmpfile is not found in the request.

Options
    • -47
    • +54
    ./acs-templating/tcl/file-procs.tcl
5:35 pm

antoniop

forum_id is actually optional here

Options
    • -2
    • +2
    ./forums/lib/search/search-form.tcl
4:53 pm

antoniop

Port of downstream hotfix: questions defined with an empty scoring might later fail the score calculations

One might consider preventing empty scores altogether via validation

Options
    • -3
    • +3
    ./xowiki/tcl/form-field-procs.tcl
2:58 pm

gustafn

improving rendering in api-doc

- fixed validity of HTML (missing <dd>)

- use

<dt>foo</dt><dd>...</dd>

instead of

<dt><b>foo></b><dd>...</dd>

and other variants. This improves stylability.

Options
    • -29
    • +29
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    ./acs-api-browser/tcl/api-doc-init.tcl
2:54 pm

gustafn

Moved styling to site-master.css

Options
    • -7
    • +0
    ./acs-api-browser/www/proc-view.adp
    • -0
    • +6
    ./acs-subsite/www/resources/site-master.css