• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix files__page_contracts for this page

    • -0
    • +7
    ./acs-admin/lib/developer-services.tcl
Check also for empty lines at the end of the file in the 'files__trailing_whitespace' test case

    • -2
    • +10
    ./acs-tcl/tcl/test/file-test-procs.tcl
Fix files__page_contracts automated test for the page

    • -10
    • +13
    ./acs-admin/lib/service-parameters.tcl
Use localized message when returning 403 and no custom message is specified

Provide an ad_include_contract for the page (fixes files__page_contracts)

    • -46
    • +55
    ./acs-authentication/lib/local-search.tcl
Ehm.. revert previous commit: search would use service contract to get the search form, so we should no assume local-search to be used...

    • -2
    • +4
    ./acs-admin/www/users/complex-search.tcl
    • -0
    • +1
    ./acs-authentication/lib/local-search.adp
    • -0
    • +79
    ./acs-authentication/lib/local-search.tcl
    • -0
    • +106
    ./acs-authentication/lib/search.adp
    • -0
    • +155
    ./acs-authentication/lib/search.tcl
Removal of obsolete user search includes

Rationale:

- no mention to these pages anywhere in upstream packages

- local-search fails files__page_contracts automated test

- weird code in local-search (where is authority_id used to filter users?...)

- acs-admin/users/complex-search is a working replacement and duplicates their intended features

- as for TIP#125, in case complex-search was not reusable, probably a minor rework would do

    • -5
    • +3
    ./acs-admin/www/users/complex-search.tcl
    • -1
    • +0
    ./acs-authentication/lib/local-search.adp
    • -79
    • +0
    ./acs-authentication/lib/local-search.tcl
    • -106
    • +0
    ./acs-authentication/lib/search.adp
    • -155
    • +0
    ./acs-authentication/lib/search.tcl
added cookie management by passing request dict as "-session" to next requests

- new webtest API calls:

::acs::test::login

::acs::test::logout

- transformed tclwebtest_example to webtest_example (not using twt)

    • -11
    • +97
    ./acs-automated-testing/tcl/aa-test-procs.tcl
    • -31
    • +35
    ./acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
Allow to specify the URL which is used for regression

testing for cases, where it is hard to determine (when e.g. running

behind a proxy server)

    • -20
    • +43
    ./acs-automated-testing/tcl/aa-test-procs.tcl
whitespace changes

    • -9
    • +9
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
Document the use of the parameter 'args' containing a list of a variable number of arguments

    • -5
    • +8
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
Fix proc doc parameters without description

    • -4
    • +3
    ./xotcl-request-monitor/tcl/throttle_mod-procs.tcl
Trim whitespaces

Indentation change

    • -3
    • +13
    ./acs-authentication/lib/search.adp
Fix parameter name in proc doc

Parameters UI: show main (empty) section at the beginning and deprecated section at the bottom

    • -10
    • +4
    ./acs-subsite/www/shared/parameters.tcl
    • -2
    • +7
    ./acs-subsite/www/shared/parameters.xql
Whitespace changes

    • -227
    • +227
    ./assessment/tcl/as-item-type-mc-procs.tcl
    • -153
    • +152
    ./dotlrn/tcl/dotlrn-procs.tcl
    • -412
    • +412
    ./evaluation/tcl/evaluation-procs.tcl
Add @see in deprecated proc, declare acs-kernel.AdminOwner parameter deprecated (superseded by acs-kernel.HostAdministrator)

Fix proc doc errors detected by 'documentation__check_parameters'

    • -1
    • +1
    ./assessment/tcl/as-item-type-mc-procs.tcl
    • -10
    • +8
    ./evaluation/tcl/evaluation-procs.tcl
    • -2
    • +2
    ./faq-portlet/tcl/faq-portlet-procs.tcl
Whitespace cleanup

    • -15
    • +15
    ./xowf/tcl/test/xowf-test-procs.tcl
Fix cases when 'selected_p' is empty, which is the default for 'ad_get_client_property'

Fix URL

    • -2
    • +2
    ./acs-automated-testing/tcl/aa-test-procs.tcl
include content_pages and include_pages in call graph analysis

    • -4
    • +6
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
include protection hints for callers in callgraph display

    • -2
    • +2
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
include acs-bootstrap-installer/bootstrap.tcl in init files for callgraph analysis

    • -9
    • +13
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
apm_source and apm_guess_db_type are called from multiple packages

    • -3
    • +3
    ./acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
improve callgraph display: handle false positives

    • -7
    • +10
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
include calls from *-init.tcl files in call graph analysis

    • -63
    • +125
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
- reduce verbosity

- improve structuring

    • -35
    • +35
    ./acs-api-browser/www/content-page-view.tcl
allow as well testing via https

    • -2
    • +8
    ./acs-automated-testing/tcl/aa-test-procs.tcl