• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reduce divergency between oracle and postgres codebase

    • -11
    • +0
    ./acs-subsite/tcl/package-procs-oracle.xql
    • -11
    • +0
    ./acs-subsite/tcl/package-procs-postgresql.xql
    • -11
    • +5
    ./acs-subsite/tcl/package-procs.tcl
Dont even offer to delete the root folder as this is prevented anyway

Put redundant query definition into generic ones

    • -14
    • +0
    ./acs-tcl/tcl/apm-install-procs-oracle.xql
    • -14
    • +0
    ./acs-tcl/tcl/apm-install-procs-postgresql.xql
    • -1
    • +14
    ./acs-tcl/tcl/apm-install-procs.xql
Use localization and api to streamline sql

    • -11
    • +54
    ./bug-tracker/www/admin/versions.tcl
    • -18
    • +3
    ./bug-tracker/www/admin/versions.xql
Close select properly

Promote whole postgres sql to generic, as it is portable

    • -102
    • +0
    ./bug-tracker/www/admin/versions-oracle.xql
    • -99
    • +0
    ./bug-tracker/www/admin/versions-postgresql.xql
    • -0
    • +92
    ./bug-tracker/www/admin/versions.xql
Fix query in generic xql that was committed by mistake, replace it with the one for postgres, as it is portable, remove oracle query

    • -3
    • +28
    ./assessment/www/asm-admin/send-mail.xql
Streamline sql to reduce divergencies between oracle and postgres codebase, remove redundant query definitions

    • -29
    • +0
    ./acs-subsite/tcl/subsite-procs-oracle.xql
    • -29
    • +0
    ./acs-subsite/tcl/subsite-procs-postgresql.xql
    • -6
    • +14
    ./acs-subsite/tcl/subsite-procs.tcl
    • -20
    • +0
    ./acs-subsite/tcl/subsite-procs.xql
remove dead code

Reuse existing api and streamline queries to reduce divergency between oracle and postgres codebase

    • -43
    • +0
    ./acs-tcl/tcl/apm-procs-postgresql.xql
whitespace cleanup

    • -453
    • +453
    ./file-storage/tcl/file-storage-procs.tcl
mark required parameters as required. Fixes issue #3347

    • -28
    • +28
    ./file-storage/tcl/file-storage-procs.tcl
Remove leftover call to dotlrn_community::type_exists

Allow themeing of /packages/acs-tcl/lib/complain

    • -2
    • +2
    ./acs-tcl/tcl/tcl-documentation-procs.tcl
Add missing message

whitespace cleanup

    • -134
    • +134
    ./acs-subsite/tcl/group-type-procs.tcl
    • -200
    • +200
    ./acs-subsite/tcl/rel-types-procs.tcl
Use subst instead of string quoting to improve readability (syntax highlighting)

Drop -postgresql.xql for "create_table" since there is no -oracle.xql and the -postgresql.xql is identical to inline code.

    • -18
    • +0
    ./acs-subsite/tcl/group-type-procs-postgresql.xql
    • -12
    • +13
    ./acs-subsite/tcl/group-type-procs.tcl
    • -11
    • +0
    ./acs-subsite/tcl/rel-types-procs-postgresql.xql
    • -11
    • +10
    ./acs-subsite/tcl/rel-types-procs.tcl
make code more robust, when connection is already closed

fix non-existing call to dotlrn_community::type_exists

Remove duplicated queries and logic, simplify idioms

    • -168
    • +5
    ./dotlrn/www/communities-chunk-oracle.xql
    • -188
    • +6
    ./dotlrn/www/communities-chunk-postgresql.xql
    • -18
    • +11
    ./dotlrn/www/communities-chunk.tcl
    • -30
    • +0
    ./fs-portlet/www/fs-contents-portlet-oracle.xql
    • -33
    • +0
    ./fs-portlet/www/fs-contents-portlet-postgresql.xql
Remove redundant query definitions

    • -19
    • +0
    ./acs-mail-lite/tcl/acs-mail-lite-procs-oracle.xql
    • -20
    • +0
    ./acs-mail-lite/tcl/acs-mail-lite-procs-postgresql.xql
Make filters consistent with what the list displays (approved means live_revision not nulll and latest revision = live_revision)

UI improvements and fix

- make sql portable

- bring all sql inline

- reduce query duplication

- simplify if idioms

- fix UI by unclobbering revision_id variable and allowing to select revision correctly

    • -64
    • +0
    ./general-comments/www/view-comment-oracle.xql
    • -63
    • +0
    ./general-comments/www/view-comment-postgresql.xql
    • -32
    • +47
    ./general-comments/www/view-comment.tcl
    • -55
    • +0
    ./general-comments/www/view-comment.xql
Improvement and fixes for this UI

- improve localization

- exploit builtin multirow feature

- reduce divergencies between oracle and postgres codebase

- remove unused sql columns

- invert boolean logics for approved and live to reflect sql clause behavior

    • -30
    • +0
    ./general-comments/www/index-oracle.xql
    • -28
    • +0
    ./general-comments/www/index-postgresql.xql
    • -11
    • +10
    ./general-comments/www/index.tcl
Whitespace changes

    • -12
    • +12
    ./assessment/tcl/as-item-answer-procs.tcl
    • -50
    • +50
    ./assessment/tcl/as-item-choice-procs.tcl
Fix duplicated words

    • -1
    • +1
    ./assessment/tcl/as-item-answer-procs.tcl
    • -1
    • +1
    ./assessment/tcl/as-item-choice-procs.tcl
    • -2
    • +2
    ./cookie-consent/tcl/cookie-consent-procs.tcl
    • -1
    • +1
    ./xotcl-core/tcl/50-protocol-handler-procs.tcl
Bugfix

forcing this db_multirow to be executed, I found out {} idiom was missing and therefore shadowing extended columns to the template::list

Remove duplicated words

Use more portable sql idioms and simplify query using api, remove unused query

    • -30
    • +4
    ./fs-portlet/www/fs-portlet-oracle.xql
    • -37
    • +5
    ./fs-portlet/www/fs-portlet-postgresql.xql