OpenACS / openacs-4 / packages

xowiki

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 139,159
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 07 Mar 2022
2:24 pm

antoniop

Also allow to specify the page order

Options
    • -4
    • +13
    ./tcl/test/test-procs.tcl
2:16 pm

antoniop

Allow to specify the content when requiring the page

Options
    • -2
    • +11
    ./tcl/test/test-procs.tcl
Sunday 06 Mar 2022
7:00 pm

gustafn

Extend randomization of multiple alternatives for cases, where one alternative must be "true"

Certain evaluation schemes for multiple choice questions require that

at least one alternative must be true. Otherwise, a division by 0

might appear. This is an issue, when a subset of alternatives is used

(e.g. 3 out of 10 alternatives). The version know evaluation schemes

with such a requirement and makes sure that in the resulting set, at

least one correct alternative is correct. Note: this change does not

make sure that the full set of alternatives contains at least one

correct alternative.

Options
    • -6
    • +36
    ./tcl/form-field-procs.tcl
Saturday 05 Mar 2022
10:35 am

gustafn

keep avoiding call "value_if_nothing_is_returned_from_form" for disabled field

This change reverts to the previous behavior and is logically sound.

All regression test continue to work. Not clear, why Antonio removed

this call (maybe due to downstream changes, but these should be

sorted out).

Options
    • -6
    • +9
    ./tcl/xowiki-www-procs.tcl
10:28 am

gustafn

add test case for disabled checkbox (should be the same as for non-disabled case)

Options
    • -2
    • +14
    ./tcl/test/xowiki-test-procs.tcl
10:27 am

gustafn

include field name in debug message

Options
    • -2
    • +2
    ./tcl/form-field-procs.tcl
Friday 04 Mar 2022
10:11 pm

gustafn

add canvas evaluation scheme of MC questions

Options
    • -2
    • +2
    ./xowiki.info
    • -4
    • +6
    ./tcl/form-field-procs.tcl
  3. … 2 more files in changeset.
8:18 pm

gustafn

Undo the change trying to alter the order inside "add_pages"

The method is intended to preserve the order of the passed-in ordered

composite. Added comments to clarify it for people not so familiar with the

code.

Options
    • -7
    • +14
    ./tcl/tree-procs.tcl
5:06 pm

antoniop

Port of downstream feature: optionally allow to instantiate the items before deletion in order to apply specific class logics

Options
    • -2
    • +14
    ./tcl/xowiki-www-procs.tcl
4:24 pm

trenner

execute configure proc after page was created

Options
    • -14
    • +14
    ./tcl/xowiki-www-procs.tcl
4:19 pm

trenner

provide test for p.configure parameter

Options
    • -0
    • +60
    ./tcl/test/xowiki-test-procs.tcl
3:55 pm

antoniop

Treat disabled form fields as they are: fields that the browser would not send to us and need to be treated "internally"

Options
    • -11
    • +2
    ./tcl/form-field-procs.tcl
    • -6
    • +2
    ./tcl/xowiki-www-procs.tcl
3:33 pm

antoniop

Formatting change

Options
    • -6
    • +12
    ./tcl/tree-procs.tcl
3:02 pm

antoniop

Use the page order as position, rather than an incremental number

Options
    • -2
    • +2
    ./tcl/tree-procs.tcl
11:53 am

gustafn

handle cases in name-validation/normalization, where the language comes from _nls_language rather than nls_language

Many thanks to Markus Moser for analyzing and identifying the problem.

Options
    • -3
    • +21
    ./tcl/xowiki-form-procs.tcl
11:30 am

gustafn

fix typo

Options
    • -2
    • +2
    ./tcl/form-field-procs.tcl
Thursday 03 Mar 2022
8:37 pm

gustafn

Delete CKEditor 3 (which was replaced by CKEditor 4 in 2012)

CKEditor 4 is continued to be supported.

Options
    • -188
    • +1
    ./tcl/form-field-procs.tcl
    • -1433
    • +0
    ./www/resources/ckeditor/CHANGES.html
    • -92
    • +0
    ./www/resources/ckeditor/INSTALL.html
    • -1327
    • +0
    ./www/resources/ckeditor/LICENSE.html
    • -955
    • +0
    ./www/resources/ckeditor/ckeditor.asp
    • -149
    • +0
    ./www/resources/ckeditor/ckeditor.js
    • -211
    • +0
    ./www/resources/ckeditor/ckeditor.pack
    • -29
    • +0
    ./www/resources/ckeditor/ckeditor.php
    • -8
    • +0
    ./www/resources/ckeditor/ckeditor_basic.js
    • -20
    • +0
    ./www/resources/ckeditor/ckeditor_basic_source.js
    • -566
    • +0
    ./www/resources/ckeditor/ckeditor_php4.php
    • -556
    • +0
    ./www/resources/ckeditor/ckeditor_php5.php
    • -35
    • +0
    ./www/resources/ckeditor/ckeditor_source.js
    • -11
    • +0
    ./www/resources/ckeditor/config.js
    • -25
    • +0
    ./www/resources/ckeditor/contents.css
  16. … 591 more files in changeset.
8:00 pm

gustafn

comment recent smelly change

+CVS: ----------------------------------------------------------------------

Options
    • -1
    • +10
    ./tcl/form-field-procs.tcl
7:40 pm

gustafn

Support specification of allowed tags/attributes/protocols via global package parameters.

This change makes it possible to define for a package values for

AllowedTags, AllowedAttributes, or AllowedProtocols. If (some of)

these exist, use these for configuring "ad_html_security_check". If +

not, fall back to the default (site wide) definition.

This change is fully backward compatible and effects on sites defining

such global parameters. This change was induced by the need of large

sites, where it is not feasible to set these parameters on the package

instance level, since this site has 830000 packages instances.

Bump version number to 5.10.1d19

Options
    • -3
    • +3
    ./xowiki.info
    • -4
    • +25
    ./tcl/form-field-procs.tcl
  3. … 1 more file in changeset.
7:22 pm

gustafn

improve error message

Options
    • -4
    • +6
    ./tcl/xowiki-procs.tcl
7:21 pm

gustafn

fix typo

Options
    • -3
    • +3
    ./tcl/xowiki-utility-procs.tcl
Wednesday 02 Mar 2022
3:03 pm

antoniop

Actually not enforce options validation on disabled formfields

Options
    • -2
    • +2
    ./tcl/form-field-procs.tcl
2:57 pm

antoniop

Don't enforce options validation on disabled fields, demonstrate that this won't allow to insert invalid values in the field

Options
    • -0
    • +5
    ./tcl/test/xowiki-test-procs.tcl
2:18 pm

antoniop

Fix the test, which was not actually reproducing the issue

in order to do so, I had to fix the behavior of acs::test::xpath::get_form_values: we should in fact NOT extract the value of disabled formfield, as a real browser will not send them in the POST request.

Options
    • -4
    • +16
    ./tcl/test/xowiki-test-procs.tcl
  2. … 1 more file in changeset.
11:46 am

antoniop

Expose behavior:

extend date formfield test to include also a date in a specific format from downstream, set to disabled. Set the day of the month as a number < 10. Show that in this case the validation will complain about an invalid value. This because the field is represented as " 1" rather than the expected "1"

Options
    • -4
    • +8
    ./tcl/test/xowiki-test-procs.tcl
Monday 21 Feb 2022
12:53 pm

gustafn

Added the option to parameterize www-delete and www-toggle-publish-status with return_url

In cases, these www* methods are called programmatically, these can be

now parameterized with an "-return_url" parameter to achieve

e.g. workflow-specific behavior.

Many thanks to Thomas Renner for the analysis on

www-toggle-publish-status.

Version number bumped to 5.10.1d18

Options
    • -2
    • +2
    ./xowiki.info
    • -6
    • +13
    ./tcl/package-procs.tcl
    • -6
    • +17
    ./tcl/xowiki-www-procs.tcl
Sunday 20 Feb 2022
6:09 pm

gustafn

Modernize code

- use dict instead of Tcl array

- prefer char operations instead of match operations

Options
    • -6
    • +8
    ./tcl/xowiki-www-procs.tcl
6:06 pm

gustafn

Fixes for Oracle 19c: boolean and timestamp handling

- a clause "true" is invalid in Oracle SQL (using "1=1" is fine).

- function "now()" does not exist, use "CURRENT_TIMESTAMP" instead

- addressing all attributes in a join via "*" is not allowed, when other

attributes are used as well. Using e.g., "bt.*" is OK.

Options
    • -2
    • +3
    ./tcl/folder-procs.tcl
    • -7
    • +7
    ./tcl/xowiki-procs.tcl
Friday 18 Feb 2022
7:32 pm

gustafn

added file content checker for zip, gzip and dump imports

Options
    • -3
    • +3
    ./xowiki.info
    • -11
    • +20
    ./tcl/import-procs.tcl
    • -3
    • +13
    ./www/admin/import.tcl
4:19 pm

antoniop

The reorder_box must always be treated as a multiple field

Options
    • -1
    • +9
    ./tcl/form-field-procs.tcl