OpenACS / openacs-4 / packages

xowiki

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 139,159
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 Mar 2022
3:03 pm

antoniop

Actually not enforce options validation on disabled formfields

Options
    • -2
    • +2
    ./tcl/form-field-procs.tcl
2:57 pm

antoniop

Don't enforce options validation on disabled fields, demonstrate that this won't allow to insert invalid values in the field

Options
    • -0
    • +5
    ./tcl/test/xowiki-test-procs.tcl
2:18 pm

antoniop

Fix the test, which was not actually reproducing the issue

in order to do so, I had to fix the behavior of acs::test::xpath::get_form_values: we should in fact NOT extract the value of disabled formfield, as a real browser will not send them in the POST request.

Options
    • -4
    • +16
    ./tcl/test/xowiki-test-procs.tcl
  2. … 1 more file in changeset.
11:46 am

antoniop

Expose behavior:

extend date formfield test to include also a date in a specific format from downstream, set to disabled. Set the day of the month as a number < 10. Show that in this case the validation will complain about an invalid value. This because the field is represented as " 1" rather than the expected "1"

Options
    • -4
    • +8
    ./tcl/test/xowiki-test-procs.tcl
Monday 21 Feb 2022
12:53 pm

gustafn

Added the option to parameterize www-delete and www-toggle-publish-status with return_url

In cases, these www* methods are called programmatically, these can be

now parameterized with an "-return_url" parameter to achieve

e.g. workflow-specific behavior.

Many thanks to Thomas Renner for the analysis on

www-toggle-publish-status.

Version number bumped to 5.10.1d18

Options
    • -2
    • +2
    ./xowiki.info
    • -6
    • +13
    ./tcl/package-procs.tcl
    • -6
    • +17
    ./tcl/xowiki-www-procs.tcl
Sunday 20 Feb 2022
6:09 pm

gustafn

Modernize code

- use dict instead of Tcl array

- prefer char operations instead of match operations

Options
    • -6
    • +8
    ./tcl/xowiki-www-procs.tcl
6:06 pm

gustafn

Fixes for Oracle 19c: boolean and timestamp handling

- a clause "true" is invalid in Oracle SQL (using "1=1" is fine).

- function "now()" does not exist, use "CURRENT_TIMESTAMP" instead

- addressing all attributes in a join via "*" is not allowed, when other

attributes are used as well. Using e.g., "bt.*" is OK.

Options
    • -2
    • +3
    ./tcl/folder-procs.tcl
    • -7
    • +7
    ./tcl/xowiki-procs.tcl
Friday 18 Feb 2022
7:32 pm

gustafn

added file content checker for zip, gzip and dump imports

Options
    • -3
    • +3
    ./xowiki.info
    • -11
    • +20
    ./tcl/import-procs.tcl
    • -3
    • +13
    ./www/admin/import.tcl
4:19 pm

antoniop

The reorder_box must always be treated as a multiple field

Options
    • -1
    • +9
    ./tcl/form-field-procs.tcl
1:14 pm

antoniop

Explicitly set the :plugin <variable>

Options
    • -2
    • +2
    ./tcl/form-field-procs.tcl
11:14 am

antoniop

Support the extraPlugins attribute the same as the CKEditor4 richtext formfield, as some places in xowiki assume it

Options
    • -2
    • +5
    ./tcl/form-field-procs.tcl
Thursday 17 Feb 2022
11:41 am

gustafn

Fixes for Oracle 19c: added missing Oracle support

Options
    • -19
    • +72
    ./tcl/xowiki-procs.tcl
Tuesday 08 Feb 2022
3:50 pm

gustafn

Beautify display of CSS tree renderer for deeper trees

- allow one to specify general UL class via "toc" includelet (was only CSS class for top-level UL)

- support passing general class for UL for tree renderer (was only CSS class for top-level UL)

- passing properties also via "add_page" to TreeNode instances

Options
    • -8
    • +12
    ./tcl/includelet-procs.tcl
    • -10
    • +31
    ./tcl/tree-procs.tcl
11:05 am

antoniop

Update italian localization

Options
    • -2
    • +2
    ./xowiki.info
    • -0
    • +9
    ./catalog/xowiki.it_IT.ISO-8859-1.xml
  3. … 2 more files in changeset.
Thursday 03 Feb 2022
7:26 pm

gustafn

Reduce dependencies on YUI 2

- Added native CSS classes for Tree renderer

(named "xowiki-tree" to avoid name clashes).

- Made TreeRenderer more configurable, by providing css class names etc.

- toc includelet: replaced default (when no style is provided)

from yuitree to list + xowiki-tree.

The old behavior can be achieved by {{toc -style yuitree}}

Note that not all features of the YUI tree might be available

- The CSS variant with xowiki-tree can also be used for the folder-tree,

but so far, the bootstrap3 renderer is more nice.

Options
    • -5
    • +16
    ./tcl/includelet-procs.tcl
    • -14
    • +25
    ./tcl/tree-procs.tcl
    • -3
    • +58
    ./www/resources/xowiki.css
Wednesday 02 Feb 2022
11:30 am

antoniop

Modernize api

Options
    • -3
    • +3
    ./tcl/test/xowiki-test-procs.tcl
11:28 am

antoniop

Improve test robustness:

the folder in the test is required, so it might be the case that its state was already tampered with. Change the test to first make sure the state from db and object are consistent, whatever they are, then perform some set/fetch/check tests on 3 arbitrary states

Options
    • -13
    • +15
    ./tcl/test/xowiki-test-procs.tcl
Tuesday 01 Feb 2022
10:10 pm

gustafn

extended regression test

Options
    • -0
    • +47
    ./tcl/test/api-test-procs.tcl
    • -10
    • +117
    ./tcl/test/xowiki-test-procs.tcl
10:09 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./tcl/yui-init.tcl
10:09 pm

gustafn

make API call a public one

Options
    • -10
    • +12
    ./tcl/xowiki-procs.tcl
10:07 pm

gustafn

issue error for unexpected value

Options
    • -5
    • +4
    ./tcl/form-field-procs.tcl
8:28 pm

gustafn

added missing space

Options
    • -1
    • +1
    ./tcl/xowiki-init.tcl
6:03 pm

antoniop

date formfield does not need special conversion when converting to external, its value is already converted when rendered

Options
    • -1
    • +9
    ./tcl/form-field-procs.tcl
Monday 31 Jan 2022
7:38 pm

gustafn

prefer YUI 2.9.0 when available

Options
    • -34
    • +68
    ./tcl/yui-init.tcl
6:34 pm

gustafn

Upgrade to jQuery UI 1.13.1

Options
    • -1
    • +1
    ./www/resources/jquery/jquery-ui.css
    • -2
    • +2
    ./www/resources/jquery/jquery-ui.min.js
2:12 pm

gustafn

Updated inferface for Page->create_form_page_instance

Since "create_form_page_instance" creates always a form

page, we can also pass the state at creation to it

(like other essential parameters). The default value

is "initial" (the default state in workflows).

Bumped version number to 5.10.1d15

Options
    • -2
    • +2
    ./xowiki.info
    • -5
    • +3
    ./tcl/xowiki-procs.tcl
2:11 pm

gustafn

updated list of tested functions

Options
    • -6
    • +6
    ./tcl/test/xowiki-admin-tests-procs.tcl
Saturday 29 Jan 2022
7:27 pm

gustafn

refactor code

Options
    • -20
    • +44
    ./tcl/package-procs.tcl
    • -35
    • +8
    ./tcl/xowiki-procs.tcl
Friday 28 Jan 2022
9:05 pm

gustafn

safetybelt for acunetix testing: refetch parameter page, when it is not initialized

hopefully a temporary measure

Options
    • -1
    • +9
    ./tcl/xowiki-procs.tcl
5:12 pm

antoniop

Test reproducing an upstream use case: a compound field made of both regular, and compound field, with the compound field also repeated

This test exposes a bug in the acs::test::xpath::get_form_values proc

Options
    • -0
    • +123
    ./tcl/test/xowiki-test-procs.tcl