• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset MAIN:gustafn:20220819193517:4 does not match your current filter (clear filter).

file calendar-portlet.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/calendar-portlet.adp
file include.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/include.tcl
file forums-portlet.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/forums-portlet.tcl
file forums-portlet.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/forums-portlet.adp
file calendar-portlet.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/calendar-portlet.tcl
Remove private variable from the contract

Add page contract

Generalized handling of local_return_url

I am not fully happy with the handlings of "return_url" in exam workflows.

Maybe this can be reworked in a way such that "local_return_url" is not

neccsessary in the future.

Test behavior of the omit formfield spec

fixed typo in version number

VS: ----------------------------------------------------------------------

Bumped version number to xowiki-5.10.1d33

Improved support for composite questions and bootstrap 5

This fixes a bug when composite questions were generated with

bootstrap3 and rendered later with bootstrap5.

  1. … 1 more file in changeset.
improve bootstrap5 compatibility for inclass exam

  1. … 1 more file in changeset.
Preliminary cleanup

In this test we will loop through instances of ::xowiki::Page currently in memory to perform some checks. When multiple tests run in the same request, we cannot guarantee that other tests won't create ::xowiki::Page instances that won't comply with the conditions here. We cleanup any existing object in advance to start from a clean slate.

    • -0
    • +9
    ./tcl/test/xowiki-admin-tests-procs.tcl
Skip processing for all formfields that are defined as disabled:

the browser should not send us these data in the first place.

Extend test: show that even when a field is defined as disabled, a request crafted to carry these fields will get through and the values will be stored

A fix will come shortly, similar to what was done for compound fields

undo part of last change

unfortunatly, the 0.9.3 issue can't be fixed so simple as hoped. The "-html" flag is necessary for dealing with autoclosed entries.

for orthogonaly, remove "-html" flag from dom parse to avoid a potential top-level <html> element

fix compatibility with tdom 0.9.3

fix warning (including some false positives) in regression test

we need the upgrade script, since the automatic aler just kicks in, when the constraint does not exist. Antonio was right.

Nevertheless, it would be a nice feature, if the ORM would handle this.

remove useless upgrade scripts (xotcl-core does this automatically on reloads)

Document and enforce expected behavior when Forms are deleted: this is forbidden and returns an error as long as they have instances

    • -0
    • +139
    ./tcl/test/xowiki-test-procs.tcl
Follow up of https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20220622174910

In the end we need the upgrade logic, as the ORM will kick in only if the column is just being created

Make page_template foreign key deferrable

This solves the problem of deleting implicitly child-items, which

depend on each other when deleting an item. When deleting an item, the

deletion of child-items in the content repository happens in an

arbitrary order, which could raise fk constraints. Since the deletion

happens in a transaction, the deferring checking of the constraints

helps, since then the constraint violating item is also already

deleted.

There is no update script necessary, since reload alters the

constraint.

undo recent change, which is not sufficiently general (and solve the issue by db means, next commit)

Address the cornercase of form pages having their template stored in the same folder: when deleting items containing such a setup, cleanup these formpages first

Addresses a consequence of https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20220613165033

remove traces of md5::md5, since ns_md5 is emulated also for AOLserver

  1. … 2 more files in changeset.
Drop "ON DELETE CASCADE" on page_template, since this might lead to crippled entries in the database.

When someone delets via operations in the database a form, protentially existing

form pages refering to this item might be left in a crippled state.

The cascade operation deletes the revision (xowiki_page_instance), but leaves

the half-crippled item. The problem does not exist over the web interface,

since it does not allow such items to be deleted while form pages exist.

Add support for menu-entries, where simply a "-link" is provided