OpenACS / openacs-4 / packages / xowiki / tcl

form-field-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 17 May
Commits this week: 0
Total Lines of Code (LoC): 4,137
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 09 Jan 2022
6:35 pm

gustafn

output warning for unexpected input

Options
    • -1
    • +3
    ./form-field-procs.tcl
6:23 pm

gustafn

Various small improvements:

- Page->content_header_append/content_header_get: new methods to

include HTML content before the form. One use case ist to include

additional forms this way, since these cannot be included in the

main form of a FormPage. The additional content is displayed in the

www-view method.

- FormPage->create_form_fields_from_names: new convenience function to create

form-fields via their names. The definitions of the named form-fields are

taken from the provided form_constraints. This function is useful when

only a subset of the form-constraints definitions should be used

to create form-fields.

- improve comments

- improve argument checking on parent_id to be able to provide better

error messages

- reduce usage of regexp for performance reasons

- improve spelling

Options
    • -5
    • +8
    ./form-field-procs.tcl
  2. … 2 more files in changeset.
Tuesday 04 Jan 2022
6:49 pm

gustafn

use "throw" in exception handling with "try"

Options
    • -4
    • +8
    ./form-field-procs.tcl
5:14 pm

antoniop

Fail with the actual error message when parsing the value fails, rather than because of "result" variable not being set

Options
    • -7
    • +5
    ./form-field-procs.tcl
Sunday 02 Jan 2022
5:25 pm

gustafn

- Define converters as procs

- Register these procs as aliases where convenient

- this effects:

dict_to_fc, dict_to_spec, spec_to_dict, fc_to_dict, dict_value

- extended regression test

- bumped version number to 5.10.1d9

Options
    • -38
    • +140
    ./form-field-procs.tcl
  2. … 2 more files in changeset.
Saturday 25 Dec 2021
5:10 pm

gustafn

Added archiving of items, reduced usage of images for icons

When an item is archived, it is not shown to plain users. Internally,

when an item is archived, the publish status is changed to "expired"

and removed from search/syndication. When an item is archived, it can

be brought via "toggle-publish-status" to state "production" again.

Future versions might rename the item in such conditions, but

currently, it is NOT renamed, so one cannot create one more item in

the same folder with the same name.

For realizing this functionality, the includelet "form-usages" accepts

now an additional optional value for "-buttons" named "archive". The

publish status toggle can be used now for switching from

"production"->"ready", "ready"->"production" and

"expired"->"production".

Additionally, the usage of .png images as icons was reduced by CSS

elements for easier styling (e.g., for different themes) and for

reducing less server requests and better responsiveness. In particular

the images for active.png and inactive.png are not necessary any more

and were removed.

Bumped version number to 5.10.1d8 to enforce loading of the message

keys.

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 13 more files in changeset.
Friday 17 Dec 2021
11:32 pm

gustafn

define javascript input handler for formfield class numeric to prevent non-numeric input while preserving the multi-lingual interpretation

Options
    • -4
    • +31
    ./form-field-procs.tcl
Sunday 05 Dec 2021
5:19 pm

gustafn

make log entries more uniform

Options
    • -2
    • +3
    ./form-field-procs.tcl
Monday 15 Nov 2021
6:23 pm

gustafn

prefer standard OpenACS API for accessing parameters

Options
    • -3
    • +4
    ./form-field-procs.tcl
  2. … 4 more files in changeset.
Tuesday 09 Nov 2021
8:27 pm

gustafn

modernize idiom

Options
    • -5
    • +2
    ./form-field-procs.tcl
Thursday 04 Nov 2021
6:10 pm

gustafn

minor update of call pattern and debug line

Options
    • -3
    • +3
    ./form-field-procs.tcl
Sunday 31 Oct 2021
8:07 pm

gustafn

Refactor form-field statistics (part 1)

- Start move of statistics from being collected in form-fields to

collecting these in the workflow objects. The original code was

developed with less randomization (e.g. no x out of y alternatives)

which requires that the formfields have to be reset multiple times

(e.g. for multiple students in the exam protocol). The exam-protocol

handler cleans regularly the form-fields, which caused also the

deletion of statistics. Collecting these in the (exam) workflow is

safe.

- Collect correct and incorrect statistics per alternative. Since

different students might see different alternatives calculating the

successrate can only be performed by the students having seens this

alternative.

Options
    • -13
    • +76
    ./form-field-procs.tcl
  2. … 2 more files in changeset.
Friday 22 Oct 2021
9:44 pm

gustafn

deactivate grammarly as well, when spellcheck is turned off for textarea

Options
    • -3
    • +5
    ./form-field-procs.tcl
Thursday 21 Oct 2021
10:54 am

gustafn

better control of browser built-in spellcheck

- xowiki: added property "spellcheck" to formfield classes "textarea" and "text_fields"

- xowf: allow per-exam to activate/deactivate spellcheck in these widget classes

Options
    • -2
    • +8
    ./form-field-procs.tcl
  2. … 6 more files in changeset.
Saturday 16 Oct 2021
4:45 pm

gustafn

Extend high-level filtering by providing "-unless" clause in form-field class "form_page"

- added "unless" clause to form-field class "test_section" to be able to filter

certain pages which should not be included

- reduced redundancy be factor out "compute_filter_clauses" method for FormPage

(used in includelet procs (class "form-usages") and form-field procs (class "form_page")

Options
    • -7
    • +8
    ./form-field-procs.tcl
  2. … 3 more files in changeset.
Friday 17 Sep 2021
9:33 pm

gustafn

allow to specify witdget type alternatively via "_type" in the form field dict

This change makes it possible to specify the whole widget spec part in a single dict

Options
    • -3
    • +8
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Monday 06 Sep 2021
6:46 pm

antoniop

State dependecny from package-procs, or ::xowiki::CSS class won't be available to this library at boot

Options
    • -1
    • +3
    ./form-field-procs.tcl
Thursday 02 Sep 2021
3:24 pm

gustafn

New CSS abstraction: xowiki::CSS

Before this change, the application developer was responsible to

initialize the CSS-speficic settings (such as setting default values

for parameter classes). The new object xowiki::CSS is initialized

automatically, when an xowiki class (or one of its subclasses) is

initialized. Furthermore, it provides a per-thread caching to reduce

double work. Furthermore, the xowiki::CSS provides a mapping between

abstract and concrete CSS class names, such that switching between

different CSS toolkits becomes easier (e.g. upgrade from bootstrap 3

to newer versions).

xowiki::CSS initialize ;# make sure, everything is in line with PreferredCSSToolkit

xowiki::CSS clear ;# reset the mapping

xowiki::CSS toolkit ;# return the toolkit name

xowiki::CSS class /classname/ ;# perform CSS class name mapping

The methods "setCSSDefaults" and "preferredCSSToolkit" as deprecated.

The version number was bumped to 5.10.0d81

Options
    • -5
    • +9
    ./form-field-procs.tcl
  2. … 7 more files in changeset.
Saturday 07 Aug 2021
11:43 am

gustafn

streamline returnredirect commands

make sure, the provided URL is always properly encoded

Options
    • -4
    • +2
    ./form-field-procs.tcl
  2. … 2 more files in changeset.
Tuesday 03 Aug 2021
8:58 pm

gustafn

minor refactoring to correct old-style widgetSpecs; prefer variable resolver over method calls for unset

Options
    • -21
    • +30
    ./form-field-procs.tcl
7:26 pm

gustafn

support editor=none in arbitrary form-field specs

Options
    • -9
    • +17
    ./form-field-procs.tcl
Monday 02 Aug 2021
11:23 pm

gustafn

prefer usage of "xo::write_tmp_file" over "xo::write_file" for writing tmp files

Options
    • -6
    • +8
    ./form-field-procs.tcl
  2. … 4 more files in changeset.
Tuesday 27 Jul 2021
2:09 pm

gustafn

fix creating/editing of xowiki::Forms

This change essentially reverts the change of July 2, which broke

the feature to specify "editor=none". This is important for the

"form" form-field entry, which requires a FORM tag, that is

usually removed by actual version of the ckeditor.

Options
    • -17
    • +32
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Thursday 22 Jul 2021
10:11 pm

gustafn

upgrade default ckeditor from 4.15.1 to 4.16.1 (released in May 2021)

Options
    • -7
    • +23
    ./form-field-procs.tcl
  2. … 2 more files in changeset.
Friday 02 Jul 2021
6:33 pm

antoniop

In order to make the "editor=" formfield spec option have any effect, one should catch the value from the spec early, before the formfield is reclassed and initialized

This also exposes that the editor=none value is not valid (detected by xowiki and xowf automated tests). For this to be valid one should define it as a richtext subclass.

Options
    • -1
    • +13
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Thursday 01 Jul 2021
7:48 pm

gustafn

make child_components a proc (::xowiki::formfield::child_components) and add filter expression

Options
    • -15
    • +25
    ./form-field-procs.tcl
3:47 pm

gustafn

Added new method "child_components": Return for a list of form-field objs all child components

Options
    • -2
    • +25
    ./form-field-procs.tcl
Monday 28 Jun 2021
9:42 pm

gustafn

provide a less confusing name for new methodm improve comments

Options
    • -9
    • +9
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
5:33 pm

antoniop

Fix typo in comment

Options
    • -5
    • +4
    ./form-field-procs.tcl
5:31 pm

antoniop

Implement reset_to_default method to reset formfields in case of validation error

the current behavior of this method is currently a no-op for every formfield, except files, where we want to make sure the value has been reset. We also handle the case now of compound fields, as they might be compounds of file formfields

Options
    • -1
    • +29
    ./form-field-procs.tcl
  2. … 1 more file in changeset.