• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
simplify logic

Fix variable name

switch from xo::db::sql to acs::dc interface

  1. … 10 more files in changeset.
Added support for www-toggle-publish-status

This is needed to avoid a bad interaction with [ad_return_url] as it

is used in www-toggle-publish-status in xowiki, since the workflow

definition unsets the actual return_url, which causes ad_return_url to

use the URL leading to this call (m=toggle-publish-status), causing a

redirection loop.

Version number bumped to 5.10.1d28

  1. … 2 more files in changeset.
ensure html markup is well formed

"::xowiki::includelet::personal-notification-messages modal_message_dialog"

is returning the html link with an open a-tag, which has to be closed from the caller

display notification link while the exam is published

provide a clean representation of questions to reduce hacking and complexity

file test-helper-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/test-helper-procs.tcl
As we cannot know which kind of exercise we got on a page in advance due to randomization, make the parameter we send for an answer dependant on the question type we find

Document public api

make grading dialog draggable

make parameter name more self-expanatory to avoid misinterpretations

  1. … 2 more files in changeset.
Store statistics in a separate page instead of the workflow itself

- advantages:

* smaller workflow instance

- no danger that page is too large for caching, even for large exams.

- smaller objects mean also better performance

* modification date in exam is not modified when statistics

are updated

* easier extensible

- New function WorkflowPage->childpage

easy to use interface for creating child pages

- render_submission=exam_protocol: changed name of

parameter "-form_objs" to "-filter_form_ids", since

form_objs are used typically to keep objects, not ids

- Still to do: policy for inclass-exam-statistics.wf

- Bumped version number to 5.10.1d25

  1. … 3 more files in changeset.
Fix comment

Simplify test logics, bring comment closer to relevant code

Improve robustness of xowf.create_test_items automated test: make sure that the exercise appearing is actually supposed to render 2 images

Fixes xowf.create_test_items automated test

Port downstream change: adding label for question selection box

Many thanks to Felix Mödritscher

  1. … 3 more files in changeset.
avoid unneccesary warnings (and unneccessary work)

In case the exam-protocol is shown filtered (e.g. only selected questions)

there is distinction between the available answer attributes and the

answer attributes, which is shown. Earlier versions tried to lookup

all available answer attributes, now we restrict the lookup to only

the shown answer attributes, and therefore avaiding running into

warnings of the form "No form field with name ... found"

this warning is just important for applications using an fc-repository

Put more info in the warning

do not allow to edit unresolve links during the exam, but allow this in the preview mode

  1. … 1 more file in changeset.
Port edit-new policy rule from original policy1 object, so that unresolved links can be rendered correctly

Fixes xowf create_composite_test_item automated test

Disallow "create-from-prototype" to non-admins in exam-answering workflows.

take out for the time being the pool question as parts of the composite question

describe_form: describe components of a copound test item rather than the container

list covered test cases

  1. … 2 more files in changeset.
revert escaped debug output

streamline and extend test cases for resolving in composite items and in preview workflows

improve robustness for partial exams

Make the test stricter: name the files all different so that their existance in the src of an img tag is certain for each of them