• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Simple fixes pointing to insufficient test cases

Many thanks to Franz Penz for the fixes

Remove leftover call tpo deprecated api

Deprecate acs_privacy:: api and inline the few usages in the dotlrn packages

See https://openacs.org/forums/message-view?message_id=5672076

  1. … 5 more files in changeset.
Quote user provided value in error message to eliminate potential XSS attack vector

Deprecate twt::user::create and twt::user::delete, superseded by their acs::test::user:: counterparts

  1. … 11 more files in changeset.
Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 33 more files in changeset.
Added comment to clarify what the issue with this code ist

Fix typo

Handle the case, happening e.g. when installing from repositores, that the cache does not exist yet

Revent experimental change and document it

added try_cache (not sure we want this on the longer range)

Whitespace changes

Add callback hooks for archive, unarchive and delete. Thanks to Felix Moedritscher

Add editor hints

Add 'dotlrn_club_new' test case, covering 'dotlrn_club::new', 'dotlrn_club::community_type' and 'dotlrn_community::get_community_type_from_community_id' procs

file club-procs.tcl was initially added on branch oacs-5-10.

Whitespace changes

Add trivial test 'dotlrn_community_types', covering 'dotlrn::community_type', 'dotlrn_class::community_type' and 'dotlrn_club::community_type' procs

Make api public: uses public api internally and downstream packages use it

Adapt spam variable name to what is advertised to the user

  1. … 1 more file in changeset.
Replace spam::interpolate with 'string map'

Deprecate spam::interpolate in favor of 'string map'

Reinstate get_portal_id_not_cached as private, replace occurrences with public api

  1. … 1 more file in changeset.
Reinstate get_portal_id_not_cached as private, flush the cache before calling public api instead

  1. … 3 more files in changeset.
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 4 more files in changeset.
Whitespace cleanup

Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 1 more file in changeset.
overwork get_community_id once more. provide a shortcut is hopless situations, reduce potential warnings and improve comments

make clear that get_community_id_from_url needs connection in case no URL is provided; provide shortcut, when determined package_id is empty

  1. … 2 more files in changeset.
Fix log message, as ad_log supports only one message as argument.