• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 225 more files in changeset.
Fix typos

  1. … 28 more files in changeset.
Fix boolean expressions in -adp files, make termination after connection closing commands explicit

  1. … 15 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7820 more files in changeset.
Use ad_script_abort everytime one issues ad_return_complaint, or subsequent errors will trigger without the user noticing

Fix spelling errors

  1. … 4 more files in changeset.
Fix spelling errors

  1. … 15 more files in changeset.
Replace innerHTML idiom with a more DOM compliant one, as IE would show undefined username otherwise.

- make boolean tests in .adp files more uniform

  1. … 2 more files in changeset.
Removed unnecessary decoding of received messages, fixed encoding of sent messages so special characters are properly urlencoded.

Allow user to specify how far in the past people connecting to the chat will see.

This is important on Learn@WU because people joining the chat room later want to

see the full conversation and before this was not settable from the UI. (Now defaults

to 4 hours) Useful also when somebody accidentally refreshes the chat after the

timewindow has passed.

Took this chance to ease a bit every future development: removed stored procedures

slowing greatly any change on the data model in favor of plain sql statements.

Incremented usage of cache.

Removed duplicated database operation when managing transcripts.

Fixed transcript name not being shown when deleting.

  1. … 8 more files in changeset.
Commit some leftover change, apply some review suggestions

  1. … 1 more file in changeset.
Refined error reporting: by returning a page containing the prefix

"chat-errmsg: "

one can decide what to show in case of error, otherwise we stick to the old behaviour (predefined message).

Chats won't throw an error anymore when people keep looking to a room that has been closed.

Instead, user will be informed that the room is unavailable.

Added missing locale key source of errors in the log.

Fixed wrong stored procedure, stating different arguments than in actual usage.

Cleaned up weird idioms in xql files and chat api, moved many db operations into tcl api.

Exploited cache (ns_cache) to retrieve quickly chat room information.

Improved code quality a bit.

Ported upstream some local modification, like prettifying of flags in chat room management

and fix of double quoting in chat's javascript.

  1. … 7 more files in changeset.
Introduced new options to set chat rooms so login and/or logout message are not issued everytime a user enters/exits the chat.

  1. … 10 more files in changeset.
Fixed table alias

- reduce dependencies on acs_object_party_privilege_map

- remove unneeded queries and .xql file

  1. … 2 more files in changeset.
- modernize HTML

- apply fresh patches to oacs-5-9 branch

  1. … 39 more files in changeset.
- tighten page contracts

  1. … 15 more files in changeset.
- modernize HTML markup

- follow adp converions for properties

  1. … 5 more files in changeset.
- remove deprecated calls

  1. … 5 more files in changeset.
- modernize Tcl

  1. … 1 more file in changeset.
Javascript support for streaming ajax based chat interface

    • -0
    • +73
    ./ajax/scripted-streaming-chat.js
- quote HTML attribute values

- use &amp instead of & in hrefs

- improve performance of index page in postgres for large sites from around 10 secs to 120 ms by moving function calls out of sql aggregation

  1. … 1 more file in changeset.
Add headings

HTML cleanup