• last updated 6 hours ago
Constraints: committers
Constraints: files
Constraints: dates
passing properties consistently with @....;literal@

  1. … 11 more files in changeset.
get rid of legacy message key "menu-Clipboard-Copy"; "menu-Clipboard-Use-Copy" is used since several years instead

  1. … 6 more files in changeset.
When deleting, make sure supplied id is actually a room id

Cleanup unreferenced SQL

Refactor display and edit modes to be based on ad_form. Many thanks to Monika Andergassen and Günter Ernst

  1. … 3 more files in changeset.
Replace handcrafted form with 'ad_form'. Many thanks to Monika Andergassen.

file transcript-new.adp was initially added on branch oacs-5-10.

Replace deprecated API. Fixes 'callgraph__bad_page_calls' test case

Remove 'moderator-grant' and 'moderator-revoke' pages, linked nowhere and using obsolete API

Remove 'chat-room-grant.tcl' page, linked nowhere and using obsolete API

Change input widget to 'number' and use a maximum value for 'messages_time_window' that can be validated in the browser. Bump version number, and add dependency to the 'acs-templating' version providing with the new 'number' widget

  1. … 1 more file in changeset.
improve spelling: move closer to the linux documentation recommendations

  1. … 7 more files in changeset.
Show the "Enable notifications" button in the chat only if the user has not accepted, or explicitly denied, notifications yet

  1. … 1 more file in changeset.
Add "Web notifications" for new messages in the chat. See: https://www.w3.org/TR/notifications/

"You should only request consent to display notifications in response to a user gesture

(e.g. clicking a button). This is not only best practice — you should not be spamming

users with notifications they didn't agree to — but going forward browsers will explicitly

disallow notification permission requests not triggered in response to a user gesture.

Firefox is already doing this from version 72, for example, and Safari has done it for some time."


  1. … 4 more files in changeset.
Show number of active users in chat. Many thanks to Monika Andergassen

  1. … 3 more files in changeset.
Handle the case when one is trying to access a non-existing room

Uniform the quoting criteria when dealing with transcripts:

- transcripts are stored as they are, no quoting in the data we store (and therefore HTML should be avoided)

- transcripts are displayed quoted, therefore disabling any effect from HTML eventually present in the content

- bring the logics to build transcript content in the api to avoid duplication

- avoid sending the transcript content to transcript-new-2, as we can generate it server side

Note: storing transcripts as a pre-formatted chunk of text is probably not the best approach, as any changes to the formatting cannot be applied to pre-existing data without a delicate upgrade. This new approach will make <br> tags inside older transcripts visible...

  1. … 4 more files in changeset.
Remove lefrover files

file toggle-active.tcl was initially added on branch oacs-5-10.

Allow to toggle chat active state from the chat list

improve spelling: prefer comma after "therefore" and friends

  1. … 4 more files in changeset.
improve comments

  1. … 2 more files in changeset.
Reduce divergencies between oracle and postgres

Reduce divergency between oracle and postgres

  1. … 3 more files in changeset.
improve spelling

  1. … 9 more files in changeset.
Chat reform:

- use consistently package_id to model belonging of a chat object to a particular package instead of the context_id

- set context_id to the package_id, as was already the case in practice, for permission checking

- make sure package_id exists and set it to the context_id in case it doesn't to handle legacy installations

  1. … 5 more files in changeset.
Fix typo

Align XoWiki UI naming to that currently in xowiki.pretty_name

  1. … 4 more files in changeset.
admin_p and user_p are actually never displayed, so it doesn't make sense to have them in the select clause. What makes sense is that we filter for those chats we can actually access

base_url is in fact just the package_url from the connection