Activity OpenACS/openacs-4/packages/attachments

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	25
Last Commit:	05 Apr
Commits this week:	0
Total Lines of Code (LoC):	3,555
Net change in LoC this week:	0

Commit Activity

last updated 6 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Wednesday 14 Aug 2019

4:28 pm

hectorr

Return a fallback attachments url when not in a connection context, for example, during mail sending on the bulk-mail package

- -17
- +21
./tcl/attachments-procs.tcl
- History
- Source
- Diff
./tcl/attachments-procs.tcl

Thursday 18 Jul 2019

6:04 pm

hectorr

Add new private proc 'attachments::get_attachments_url', and use it to complement the logic of 'attachments::get_url'

As 'attachments::get_url' returns the value of the attachments package

'RelativeUrl' parameter, which can change at any time, it could happen

that previously mounted attachments have a different url and are not

found anymore.

We try our best here to find a mounted attachments package under

'base_url' to mitigate this, probably flawed, package logic.

In the future, probably a better method should be used for URL resolving

that is not so broken.

The whole thing is even more weird, as the attachments package is

currently a singleton that auto-mounts on /attachments, so i am tempted

to replace this whole thing with just that, but anyway...

- -4
- +51
./tcl/attachments-procs.tcl
- History
- Source
- Diff
./tcl/attachments-procs.tcl

Monday 15 Jul 2019

12:53 am

gustafn

improve spelling

- -2
- +2
./www/doc/index.adp
- History
- Source
- Diff
./www/doc/index.adp
… 3 more files in changeset.

Friday 12 Jul 2019

4:31 pm

hectorr

Only offer the possibility to delete an attachment from the file storage if it is really there, offer to detach it in any case.

- -2
- +2
./www/detach.adp
- History
- Source
- Diff
./www/detach.adp
- -58
- +75
./www/detach.tcl
- History
- Source
- Diff
./www/detach.tcl

4:19 pm

hectorr

Add 'attachments::get_title' to centralize the logic of title guessing for an attachment

- -37
- +51
./tcl/attachments-procs.tcl
- History
- Source
- Diff
./tcl/attachments-procs.tcl

Thursday 11 Jul 2019

6:41 pm

hectorr

Whitespace changes

- -15
- +20
./www/go-to-attachment.xql
- History
- Source
- Diff
./www/go-to-attachment.xql
- -2
- +2
./www/download/index.xql
- History
- Source
- Diff
./www/download/index.xql

6:38 pm

hectorr

Generalize attachment download logic, so it can deal with different object types, such as 'content_item', 'content_revision', and their subtypes

- -44
- +60
./www/go-to-attachment.tcl
- History
- Source
- Diff
./www/go-to-attachment.tcl
- -0
- +14
./www/go-to-attachment.xql
- History
- Source
- Diff
./www/go-to-attachment.xql
- -11
- +35
./www/download/index.vuh
- History
- Source
- Diff
./www/download/index.vuh
- -1
- +12
./www/download/index.xql
- History
- Source
- Diff
./www/download/index.xql

6:01 pm

hectorr

Add 'exception_count' to 'ad_return_complaint'

- -3
- +5
./www/download/index.vuh
- History
- Source
- Diff
./www/download/index.vuh

Wednesday 10 Jul 2019

8:39 pm

Make 'attachments::get_all_attachments' more general, so we try our best to get the 'label' of the attachment by trying different options depending on the object type: 'content_item', 'content_revision', a subtype of those, or just the 'title' row in the 'acs_objects' table. In the very worst case, just set the given 'item_id' as the label.

- -24
- +38
./tcl/attachments-procs.tcl
- History
- Source
- Diff
./tcl/attachments-procs.tcl

2:50 pm

hectorr

Prefer live to latest revision when getting title for attachments in 'attachments::get_all_attachments'

- -2
- +2
./tcl/attachments-procs.tcl
- History
- Source
- Diff
./tcl/attachments-procs.tcl

2:23 pm

hectorr

When the attachment is not in the file storage, consider both the possibilities of it being a 'content_item' or a 'content_revision', while trying to resolve its title in 'attachments::get_all_attachments' by looking directly in the content respository

- -5
- +22
./tcl/attachments-procs.tcl
- History
- Source
- Diff
./tcl/attachments-procs.tcl

Tuesday 09 Jul 2019

8:30 pm

hectorr

Use 'item_id' instead of 'revision_id' for attachments

- -2
- +2
./tcl/attachments-procs.tcl
- History
- Source
- Diff
./tcl/attachments-procs.tcl

7:42 pm

hectorr

Do not assume all attachments are in the file storage while retrieving their title/name

- -1
- +8
./tcl/attachments-procs.tcl
- History
- Source
- Diff
./tcl/attachments-procs.tcl

Monday 01 Jul 2019

4:47 pm

hectorr

Move 'util::content_size_pretty' into 'acs-lang' and rename it to 'lc_content_size_pretty', localicing 'bytes' and adapting automated tests. Bump 'acs-lang' version.