OpenACS / openacs-4 / packages / attachments

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 915
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +0
    ./attachments-procs.tcl
    • -0
    • +376
    ./test/attachments-procs.tcl
  3. … 1463 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -10
    • +122
    ./attachments-procs.tcl
    • -0
    • +102
    ./richtext-procs.tcl
  3. … 8098 more files in changeset.
Friday 02 Aug
5:28 pm

antoniop

Implement for the attachment package a reusable UI meant to be integrated by richtext editors

The UI implements basic CRUD operations on an attachment stored under a generic acs_object. The UI expects to be opened by an iframe and to pass the rendered content to the opener page.

Options
    • -0
    • +102
    ./richtext-procs.tcl
  2. … 6 more files in changeset.
5:28 pm

antoniop

file richtext-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./richtext-procs.tcl
Monday 20 Feb 2023
11:53 am

antoniop

Fake the node_id when test is run outside of a connection

Many thanks to Thomas Renner

Options
    • -21
    • +33
    ./test/attachments-procs.tcl
11:39 am

antoniop

Fix actual coverage

Options
    • -3
    • +2
    ./test/attachments-procs.tcl
Wednesday 15 Feb 2023
2:21 pm

antoniop

Complete coverega of public api for the package

Options
    • -2
    • +268
    ./test/attachments-procs.tcl
Monday 12 Sep 2022
4:43 pm

antoniop

Deprecate attachments::root_folder_map_p

Options
    • -2
    • +4
    ./attachments-procs.tcl
4:38 pm

antoniop

Document public api

Options
    • -1
    • +8
    ./attachments-procs.tcl
Tuesday 22 Jun 2021
4:43 pm

hectorr

Add minimal test case for 'attachments::get_package_key'

Options
    • -1
    • +12
    ./test/attachments-procs.tcl
Thursday 18 Feb 2021
3:19 pm

hectorr

Remove leftover comment

Options
    • -2
    • +1
    ./test/attachments-procs.tcl
3:16 pm

hectorr

Add 'attachments_basic_api' test case. Covers basic api of the attachments package: 'attachments::attach', 'attachments::unattach', 'attachments::get_all_attachments', 'attachments::get_attachments' and 'attachments::toggle_approved'

Options
    • -0
    • +89
    ./test/attachments-procs.tcl
3:16 pm

hectorr

file attachments-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./test/attachments-procs.tcl
Wednesday 14 Aug 2019
4:28 pm

hectorr

Return a fallback attachments url when not in a connection context, for example, during mail sending on the bulk-mail package

Options
    • -17
    • +21
    ./attachments-procs.tcl
Thursday 18 Jul 2019
6:04 pm

hectorr

Add new private proc 'attachments::get_attachments_url', and use it to complement the logic of 'attachments::get_url'

As 'attachments::get_url' returns the value of the attachments package

'RelativeUrl' parameter, which can change at any time, it could happen

that previously mounted attachments have a different url and are not

found anymore.

We try our best here to find a mounted attachments package under

'base_url' to mitigate this, probably flawed, package logic.

In the future, probably a better method should be used for URL resolving

that is not so broken.

The whole thing is even more weird, as the attachments package is

currently a singleton that auto-mounts on /attachments, so i am tempted

to replace this whole thing with just that, but anyway...

Options
    • -4
    • +51
    ./attachments-procs.tcl
Friday 12 Jul 2019
4:19 pm

hectorr

Add 'attachments::get_title' to centralize the logic of title guessing for an attachment

Options
    • -37
    • +51
    ./attachments-procs.tcl
Wednesday 10 Jul 2019
8:39 pm

hectorr

Make 'attachments::get_all_attachments' more general, so we try our best to get the 'label' of the attachment by trying different options depending on the object type: 'content_item', 'content_revision', a subtype of those, or just the 'title' row in the 'acs_objects' table. In the very worst case, just set the given 'item_id' as the label.

Options
    • -24
    • +38
    ./attachments-procs.tcl
2:50 pm

hectorr

Prefer live to latest revision when getting title for attachments in 'attachments::get_all_attachments'

Options
    • -2
    • +2
    ./attachments-procs.tcl
2:23 pm

hectorr

When the attachment is not in the file storage, consider both the possibilities of it being a 'content_item' or a 'content_revision', while trying to resolve its title in 'attachments::get_all_attachments' by looking directly in the content respository

Options
    • -5
    • +22
    ./attachments-procs.tcl
Tuesday 09 Jul 2019
8:30 pm

hectorr

Use 'item_id' instead of 'revision_id' for attachments

Options
    • -2
    • +2
    ./attachments-procs.tcl
7:42 pm

hectorr

Do not assume all attachments are in the file storage while retrieving their title/name

Options
    • -1
    • +8
    ./attachments-procs.tcl
Thursday 28 Jun 2018
4:22 pm

hectorr

Whitespace cleanup

Options
    • -8
    • +8
    ./attachments-procs.tcl
4:21 pm

hectorr

Provide a minimal documentation to public procs

Options
    • -9
    • +20
    ./attachments-procs.tcl
Wednesday 20 Jun 2018
9:33 am

antoniop

Smartify query

Options
    • -7
    • +3
    ./attachments-procs.xql
Tuesday 19 Jun 2018
5:55 pm

antoniop

Let everything happen in the database for this proc

Options
    • -5
    • +1
    ./attachments-procs.tcl
    • -10
    • +5
    ./attachments-procs.xql
5:09 pm

antoniop

Remove divergency between oracle and postgres codebase, rewrite proc to avoid duplication and give it a proper and correct documentation

Quoting commit that replaced db_list_of_lists with db_list, de facto hiding every additional column from results:

-------

Author: Peter Marklund <peter_marklund@fastmail.fm>

Date: Mon Nov 24 14:50:34 2003 +0000

changing the get_attachments procs to use db_list instead of db_list_of_lists and the PG query to only return the id

-------

Options
    • -23
    • +0
    ./attachments-procs-oracle.xql
    • -24
    • +0
    ./attachments-procs-postgresql.xql
    • -29
    • +50
    ./attachments-procs.tcl
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -1
    • +7
    ./attachments-procs.tcl
  2. … 7834 more files in changeset.
Thursday 10 Sep 2015
10:27 am

gustafn

- add editor hints to keep spaces/tabs in the future more consistent

Options
    • -1
    • +7
    ./attachments-procs.tcl
  2. … 313 more files in changeset.
Monday 27 Oct 2014
5:38 pm

victorg

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

Options
    • -3
    • +3
    ./attachments-procs.tcl
  2. … 2547 more files in changeset.
Thursday 03 Oct 2013
1:08 am

gustafn

- breace expressions

- used compiled instructions

- bump version number

Options
    • -3
    • +3
    ./attachments-procs.tcl
  2. … 8 more files in changeset.