OpenACS / openacs-4 / packages

acs-templating

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 61
Last Commit: 31 May
Commits this week: 1
Total Lines of Code (LoC): 312,825
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Aug 2022
1:34 pm

antoniop

Revert to previous template::widget::file behavior of accepting input in a form of a list of 3 elements (e.g. without a .tmpfile in the request), but introduce validation so that we enforce all widget values to be in the proper format and the files to be "safe"

Options
    • -3
    • +3
    ./acs-templating.info
    • -0
    • +1
    ./catalog/acs-templating.en_US.ISO-8859-1.xml
    • -42
    • +83
    ./tcl/file-procs.tcl
    • -7
    • +14
    ./tcl/test/data-procs.tcl
    • -0
    • +244
    ./tcl/test/file-procs.tcl
1:34 pm

antoniop

file file-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/file-procs.tcl
Wednesday 24 Aug 2022
10:58 am

antoniop

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

Options
    • -19
    • +4
    ./tcl/file-procs.tcl
  2. … 2 more files in changeset.
Tuesday 23 Aug 2022
5:39 pm

antoniop

Incorporate feedback from downstream penetration tests:

do not skip basic validation in the file widget when a tmpfile is not found in the request.

Options
    • -47
    • +54
    ./tcl/file-procs.tcl
Sunday 14 Aug 2022
10:05 am

gustafn

extended adp:icon handling

Added support for multiple classes,

Added more potentially reusabel icon names,

bumped version to 5.10.1d13

Options
    • -2
    • +2
    ./acs-templating.info
    • -3
    • +4
    ./tcl/style-procs.tcl
    • -2
    • +6
    ./tcl/tag-init.tcl
Saturday 13 Aug 2022
3:55 pm

gustafn

extended generic names by "user" and "list-alt"

Options
    • -1
    • +9
    ./tcl/tag-init.tcl
Thursday 11 Aug 2022
1:05 pm

gustafn

whitespace changes

Options
    • -50
    • +50
    ./tcl/tag-init.tcl
1:01 pm

gustafn

added new generic icon name: add-new-item

Options
    • -1
    • +5
    ./tcl/tag-init.tcl
1:00 pm

gustafn

prefer parameter::get_from_package_key over fetching package_id first

Options
    • -7
    • +9
    ./tcl/template-init.tcl
Friday 15 Jul 2022
1:21 pm

antoniop

Cleanup message keys that do not exist in the english locale (they do exist in their "_time" variant, e.g. Time_must_be_after_min_time, already translated in spanish)

Options
    • -2
    • +2
    ./acs-templating.info
    • -2
    • +0
    ./catalog/acs-templating.es_ES.ISO-8859-1.xml
Monday 04 Jul 2022
2:59 pm

hectorr

Bump version number after catalog change

Options
    • -2
    • +2
    ./acs-templating.info
Sunday 26 Jun 2022
9:30 pm

gustafn

fix false positive of regression test

Options
    • -1
    • +1
    ./tcl/richtext-procs.tcl
1:06 pm

gustafn

removed code factored out to the separate "captcha" package

Options
    • -2
    • +0
    ./catalog/acs-templating.de_DE.ISO-8859-1.xml
    • -2
    • +0
    ./catalog/acs-templating.en_US.ISO-8859-1.xml
    • -2
    • +0
    ./catalog/acs-templating.it_IT.ISO-8859-1.xml
    • -906
    • +0
    ./resources/fonts/LiberationSans-Regular.ttf
    • -2
    • +1
    ./sql/oracle/acs-templating-create.sql
    • -12
    • +0
    ./sql/oracle/captcha-create.sql
    • -13
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
    • -2
    • +1
    ./sql/postgresql/acs-templating-create.sql
    • -10
    • +0
    ./sql/postgresql/captcha-create.sql
    • -13
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
    • -353
    • +0
    ./tcl/captcha-procs.tcl
    • -163
    • +0
    ./tcl/test/captcha-procs.tcl
Saturday 25 Jun 2022
2:05 pm

gustafn

improve comments, such that is is clear what command to use instead

Options
    • -4
    • +4
    ./tcl/deprecated-procs.tcl
2:05 pm

gustafn

deactivate captcha test for the time being

Options
    • -0
    • +1
    ./tcl/test/captcha-procs.tcl
Wednesday 22 Jun 2022
10:42 am

antoniop

Constrain captcha width to 100% of its parent's size

Options
    • -1
    • +1
    ./tcl/captcha-procs.tcl
Wednesday 15 Jun 2022
8:54 pm

gustafn

whitespace changes

Options
    • -8
    • +8
    ./tcl/parse-procs.tcl
8:48 pm

gustafn

reduce useless warnings for template::adp_parse_tags

The problem was that template::adp_compile_chunk produces no output, when the parsed chunk contains only whitespace,

causing an error message in this case. The changed method shortcuts the behavior.

Options
    • -4
    • +7
    ./tcl/parse-procs.tcl
Monday 02 May 2022
2:03 pm

antoniop

Fix missing variable

Options
    • -1
    • +1
    ./tcl/captcha-procs.tcl
Thursday 28 Apr 2022
12:59 pm

antoniop

Fix typo

Options
    • -2
    • +1
    ./tcl/captcha-procs.tcl
Wednesday 27 Apr 2022
6:43 pm

antoniop

Provide an alternative exec-free captcha implementation using libgd and its Tcl wrapper https://github.com/flightaware/tcl.gd

This implementation will be preferred to the one using convert, when available.

Options
    • -0
    • +906
    ./resources/fonts/LiberationSans-Regular.ttf
    • -23
    • +152
    ./tcl/captcha-procs.tcl
6:43 pm

antoniop

file LiberationSans-Regular.ttf was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./resources/fonts/LiberationSans-Regular.ttf
6:30 pm

gustafn

passing properties consistently with @....;literal@

Options
    • -1
    • +1
    ./www/doc/demo/fibo.adp
    • -1
    • +1
    ./www/doc/exercise/list-and-var-sample.adp
  3. … 52 more files in changeset.
2:22 pm

gustafn

passing properties consistently with @....;literal@ and not "noquote", since noquote content is already parsed

Options
    • -1
    • +1
    ./www/doc/migration.adp
    • -4
    • +4
    ./www/doc/migration.html
  3. … 13 more files in changeset.
Thursday 21 Apr 2022
1:34 pm

antoniop

Cleanup dummy commands and objects to avoid cross interactions between tests

Options
    • -0
    • +1
    ./tcl/test/captcha-procs.tcl
  2. … 1 more file in changeset.
Wednesday 20 Apr 2022
3:49 pm

antoniop

Go back supporting arbitrary options, potentially from custom user-defined widgets: these will be assumed to be expressed as name-value pairs and we will keep notifying such cases in the logfile

Options
    • -8
    • +44
    ./tcl/element-procs.tcl
11:58 am

gustafn

whitespace changes

Options
    • -61
    • +71
    ./tcl/test/parse-test-procs.tcl
10:51 am

gustafn

revive delete regression test (was formerly in xowiki)

Options
    • -1
    • +25
    ./tcl/test/parse-test-procs.tcl
9:16 am

antoniop

Keep supporting also the htmlarea_p option

Options
    • -1
    • +7
    ./tcl/element-procs.tcl
8:52 am

antoniop

Fix doc

Options
    • -2
    • +2
    ./tcl/element-procs.tcl