OpenACS / openacs-4 / packages

acs-templating

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 61
Last Commit: 06:29
Commits this week: 0
Total Lines of Code (LoC): 318,920
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 34 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 04 Apr 2022
11:46 am

antoniop

Improve message key and translations

Options
    • -2
    • +2
    ./acs-templating.info
    • -1
    • +1
    ./catalog/acs-templating.de_DE.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/acs-templating.en_US.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/acs-templating.it_IT.ISO-8859-1.xml
Thursday 31 Mar 2022
6:36 pm

antoniop

Improve doc

Options
    • -6
    • +7
    ./tcl/element-procs.tcl
6:33 pm

antoniop

Replace the lame template::util::get_opts with some homemade utility that will parse arguments reliably, adjust the one upstream use case where arguments other than those documented might be passed to the element creation, introduce a warning when this happens somewhere else

Options
    • -2
    • +82
    ./tcl/element-procs.tcl
  2. … 1 more file in changeset.
6:23 pm

antoniop

Fix test, the proc behaves as documented (and IMO, it should go away at some point)

Options
    • -2
    • +7
    ./tcl/test/util-procs.tcl
2:59 pm

antoniop

New test for template::util::get_opts

This will expose a bug when an argument in an even position is specified that starts with a "-" character

Options
    • -1
    • +32
    ./tcl/test/util-procs.tcl
Wednesday 30 Mar 2022
10:34 am

trenner

not necessary to check if format is a list

Options
    • -1
    • +1
    ./tcl/richtext-procs.tcl
9:59 am

trenner

move the check for the provided format on richtext level

Options
    • -0
    • +4
    ./tcl/richtext-procs.tcl
    • -4
    • +2
    ./tcl/widget-procs.tcl
Tuesday 29 Mar 2022
1:01 pm

trenner

increase robustness

Options
    • -2
    • +4
    ./tcl/widget-procs.tcl
Thursday 17 Feb 2022
4:20 pm

gustafn

Fixes for Oracle 19c: fix data types and interval calculation

Options
    • -8
    • +6
    ./sql/oracle/captcha-create.sql
3:17 pm

antoniop

Don't use expressions for the default value, apparently a nono in Oracle

See e.g. https://docs.oracle.com/javadb/10.8.3.0/ref/rrefsqlj30540.html#rrefsqlj30540__sqlj64478

Options
    • -2
    • +7
    ./sql/oracle/captcha-create.sql
    • -2
    • +1
    ./sql/oracle/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
Tuesday 08 Feb 2022
10:36 am

antoniop

Update italian localization

Options
    • -2
    • +2
    ./acs-templating.info
    • -0
    • +3
    ./catalog/acs-templating.it_IT.ISO-8859-1.xml
10:31 am

antoniop

Return a 422 complaint, introduce a generic error message when an item is invalid

Options
    • -2
    • +2
    ./acs-templating.info
    • -0
    • +1
    ./catalog/acs-templating.en_US.ISO-8859-1.xml
  3. … 2 more files in changeset.
Monday 07 Feb 2022
5:12 pm

antoniop

Be stricter when validating widgets with restricted options: when no options are specified, treat it as automatic failure

Options
    • -5
    • +11
    ./tcl/data-procs.tcl
Monday 31 Jan 2022
12:13 pm

antoniop

Compute amplitude and wavelength explicitly in pixels and make it stable with respect to the captcha size, introduce a random offset for the wave instead

Fixes acs-templating.tesseract_cannot_crack_catpcha automated test

Options
    • -3
    • +8
    ./tcl/captcha-procs.tcl
Sunday 30 Jan 2022
3:38 pm

gustafn

Minor modernization

- use atomic stack operations to reduce locks and avoid race conditions

- improve spelling

- break overlong lines

- better align comments with actual code

Options
    • -3
    • +3
    ./tcl/date-procs.tcl
    • -36
    • +61
    ./tcl/parse-procs.tcl
    • -1
    • +1
    ./tcl/test/captcha-procs.tcl
Friday 28 Jan 2022
10:59 am

antoniop

Provide a message key for help text, localize in German

Options
    • -2
    • +2
    ./acs-templating.info
    • -0
    • +2
    ./catalog/acs-templating.de_DE.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/acs-templating.en_US.ISO-8859-1.xml
10:28 am

antoniop

Drop the pointsize parameter, use size instead, yielding more predictable results across Imagemagik versions and more controllable in general, make the wavelength randomized in the distortion

Options
    • -10
    • +12
    ./tcl/captcha-procs.tcl
    • -3
    • +13
    ./tcl/test/captcha-procs.tcl
Thursday 27 Jan 2022
10:23 am

antoniop

Deprecate template::util::tcl_to_sql_list, completely replaced by ns_dbquotelist, a native NaviServer command

Options
    • -1
    • +23
    ./tcl/deprecated-procs.tcl
    • -24
    • +1
    ./tcl/util-procs.tcl
    • -32
    • +1
    ./tcl/test/parse-test-procs.tcl
  4. … 15 more files in changeset.
9:22 am

antoniop

Improve test portability

Options
    • -1
    • +1
    ./tcl/test/captcha-procs.tcl
9:20 am

antoniop

Baseline test of captcha robustness: challenge the captcha using tesseract, also applying basic normalizations

Options
    • -0
    • +48
    ./tcl/test/captcha-procs.tcl
9:18 am

antoniop

Fail when no value is specified

Options
    • -4
    • +3
    ./tcl/captcha-procs.tcl
9:12 am

antoniop

Fix tests according to new behavior

Options
    • -6
    • +15
    ./tcl/test/captcha-procs.tcl
8:26 am

antoniop

Improve behavior: invalidate the captcha when the check fails, cleanup expired captcha also when a new one is generated

Options
    • -10
    • +22
    ./tcl/captcha-procs.tcl
Wednesday 26 Jan 2022
6:28 pm

antoniop

Test newly introduced api

Options
    • -0
    • +94
    ./tcl/test/captcha-procs.tcl
6:28 pm

antoniop

file captcha-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/captcha-procs.tcl
5:06 pm

antoniop

A simple image captcha implementation:

a random text is converted to a distorted image, its checksum, together with the expected text are stored in a lookup table. Upon validation, the text input by the user is matched against the checksum to determine if the captcha is correct.

Plan is to use it downstream on certain publicly available contact forms.

Options
    • -2
    • +2
    ./acs-templating.info
    • -0
    • +1
    ./catalog/acs-templating.en_US.ISO-8859-1.xml
    • -1
    • +2
    ./sql/oracle/acs-templating-create.sql
    • -0
    • +9
    ./sql/oracle/captcha-create.sql
    • -0
    • +14
    ./sql/oracle/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
    • -1
    • +2
    ./sql/postgresql/acs-templating-create.sql
    • -0
    • +10
    ./sql/postgresql/captcha-create.sql
    • -0
    • +13
    ./sql/postgresql/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
    • -0
    • +207
    ./tcl/captcha-procs.tcl
5:06 pm

antoniop

file captcha-create.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/oracle/captcha-create.sql
    • -0
    • +0
    ./sql/postgresql/captcha-create.sql
5:06 pm

antoniop

file captcha-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/captcha-procs.tcl
5:06 pm

antoniop

file upgrade-5.10.1d0-5.10.1d1.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
3:45 pm

antoniop

Make sure widget variable exists for the element

Options
    • -2
    • +3
    ./tcl/data-procs.tcl