• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Baseline test of captcha robustness: challenge the captcha using tesseract, also applying basic normalizations

Fail when no value is specified

Fix tests according to new behavior

Improve behavior: invalidate the captcha when the check fails, cleanup expired captcha also when a new one is generated

Test newly introduced api

file captcha-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/captcha-procs.tcl
A simple image captcha implementation:

a random text is converted to a distorted image, its checksum, together with the expected text are stored in a lookup table. Upon validation, the text input by the user is matched against the checksum to determine if the captcha is correct.

Plan is to use it downstream on certain publicly available contact forms.

    • -0
    • +1
    ./catalog/acs-templating.en_US.ISO-8859-1.xml
    • -1
    • +2
    ./sql/oracle/acs-templating-create.sql
    • -0
    • +14
    ./sql/oracle/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
    • -1
    • +2
    ./sql/postgresql/acs-templating-create.sql
    • -0
    • +10
    ./sql/postgresql/captcha-create.sql
file captcha-create.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/captcha-create.sql
    • -0
    • +0
    ./sql/postgresql/captcha-create.sql
file captcha-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/captcha-procs.tcl
file upgrade-5.10.1d0-5.10.1d1.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
Make sure widget variable exists for the element

Add multiselect to the widgets we check

Restrict new widget validation of options to select and radio, not every widget must restrict the values to the options property

Implement a hook for widget-specific validation and use it to enforce that widgets that specify a list of options must return a value that belongs to those options

Inform widget: do not render any input element alongside the form value

improve spelling

validate format of richtext field always

Smartify idioms

Fix typo

simplify idioms

Deprecate template::util::list_opts: it can be replaced by trivial tcl idioms

Streamline idioms

    • -12
    • +3
    ./resources/forms/confirm-button.tcl
Streamline ns_set idioms

Deprecate template::util::set_to_vars: it can be replaced with trivial idioms

Deprecate template::util::set_to_list: this proc can be replaced with trivial ns_set and tcl idioms

Get rid of trivial private api publish::set_to_pairs

  1. … 1 more file in changeset.
Replace trivial api

Streamline ns_set idioms

  1. … 1 more file in changeset.
Uniform documentation style

Normalize indentation