• last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
External identity provider reform (part 3)

- logout from external identity provider, if logged in via it

- extend default login page via ADP include, when external

identity providers are configured.

  1. … 4 more files in changeset.
External identity provider reform (part 2)

Use the external identity provider for refresh of logins. When a user

is logged in via an external identity provider, use the same identity

provider for a refresh when it expires. The expiration time is

controlled via the classical OpenACS parameters.

Note that in general, the same user might be authenticated via a

classical OpenACS authority (e.g. local authority) and/or via an

external one (e.g. Microsoft Identity Platform (Azure) or GitHub).

For single-sign-ons, when the token is still valid, the redirect to

the external identity provider does not mean necessarily that the use

is shown the external identity provider's login page.

  1. … 2 more files in changeset.
whitespace changes

Added preliminary support for secondary registries (e.g., MS Azure via oauth2)

- When login happened via external registry, the logout should happen

there as well.

- let "sec_login_read_cookie" return a dict instead of a list

(eases future extension)

- bump version number to 5.10.1d31

improve spelling

Reintroduce exec-based approach for unzipping, as zipfile::decode will not handle files > 2GB well

Re-introduce the exec and document why

Close channel

Provide exec-free implementation of tarball extraction

Deprecate apm_file_type_keys, which can be inlined by a simple dict idiom

Avoid dubious catches, collect more logics in the proc

Test apm_workspace directory api

Add missing flag -file to the api call

Test creating and extracting an APM Package tarball

file apm-file-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/apm-file-procs.tcl
As tcllib was released in 2016, I believe we can cleanup the legacy zip implementation

Provide exec-free implementation of util::unzip using zipfile::decode

Extend the test to cover also cornercase behavior concerning overwriting of files

Test zipping and unzipping utilities

Make test less tautological

Test for psql only when this is expected

    • -12
    • +20
    ./tcl/test/acs-tcl-test-procs.tcl
Fallback to the location of the psql executable when a pgbin was not explicitly defined in the config file (which is allowed)

Test external command dependencies

This will currently fail because of a bug in db_get_pgbin

Test ad_change_password

Add notes about api

    • -5
    • +21
    ./tcl/site-node-apm-integration-procs.tcl
Update api

  1. … 1 more file in changeset.
Deprecate trivial wrappers to the NaviServer API

Modern ns_getform will not return the empty string for empty requests, but only when we are operating outside of a connection. In such circumstances is arguably useful to manipulate the request parameters.

  1. … 2 more files in changeset.
Commit missing change to the users api

Update documentation

Use a better regexp to reimplement ad_looks_like_html_p, use the improved api to port downstream feature: an ad_form datatype validator that won't allow to insert markup

Many thanks to Günter Ernst

  1. … 1 more file in changeset.