OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 73
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 74,868
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 28 Sep 2022
10:20 am

gustafn

Give people the chance to use OpenACS with WithDeprecatedCode set to 0

When OpenACS is configured to omit loading of long deprecated code

(WithDeprecatedCode set to 0) files like deprecated-procs.tcl are not

loaded. Therefore, these files should only contain code, which was

deprecated at LEAST ONE RELEASE EARLIER, such that site admins have

one release time to fix calls to deprecated code. This is especially

important for public procs.

Options
    • -102
    • +2
    ./tcl/deprecated-procs.tcl
    • -2
    • +107
    ./tcl/utilities-procs.tcl
Wednesday 14 Sep 2022
2:33 pm

antoniop

Prefer acs::try_cache where the cache existance cannot be taken for granted (e.g. at upgrade)

Options
    • -6
    • +5
    ./tcl/apm-install-procs.tcl
2:29 pm

antoniop

Make acs::try_cache more robust to transitional situations during instance upgrade, where the object might exist, but not the method

Options
    • -1
    • +4
    ./tcl/acs-cache-procs.tcl
12:45 pm

antoniop

Ignore also class definitions in the ignored namespaces

Options
    • -1
    • +1
    ./tcl/test/doc-check-procs.tcl
Tuesday 13 Sep 2022
6:55 pm

gernst

ns_quotehtml user submitted value inside error message to prevent potential XSS attack

Options
    • -3
    • +3
    ./tcl/tcl-documentation-procs.tcl
4:40 pm

antoniop

Ignore the ::nsshell namespace: this is a NaviServer module, hence outside the OpenACS source tree

Options
    • -0
    • +1
    ./tcl/test/doc-check-procs.tcl
11:33 am

antoniop

Document public api

Options
    • -2
    • +3
    ./tcl/utilities-procs.tcl
  2. … 1 more file in changeset.
11:27 am

antoniop

Add doc to public api, fix obvious bug

Options
    • -3
    • +11
    ./tcl/utilities-procs.tcl
Monday 12 Sep 2022
6:23 pm

antoniop

Document public api

Options
    • -1
    • +11
    ./tcl/utilities-procs.tcl
  2. … 1 more file in changeset.
6:04 pm

antoniop

Document public api

Options
    • -2
    • +4
    ./tcl/security-procs.tcl
5:43 pm

antoniop

Document public api

Options
    • -1
    • +3
    ./tcl/install-procs.tcl
  2. … 1 more file in changeset.
4:52 pm

antoniop

Fix doc definition, add remark

Options
    • -4
    • +7
    ./tcl/exception-procs.tcl
3:45 pm

antoniop

Consider @see annotations as sufficient documentation

Options
    • -1
    • +2
    ./tcl/test/doc-check-procs.tcl
2:55 pm

antoniop

Add doc to public api

Options
    • -2
    • +11
    ./tcl/acs-db-00-procs.tcl
Friday 09 Sep 2022
3:53 pm

antoniop

Make test more precise: some procs have just a newline in their doc instead of meaningful documentation...

Options
    • -1
    • +4
    ./tcl/test/doc-check-procs.tcl
1:32 pm

antoniop

Centralize retrieval of the test URL

Options
    • -9
    • +1
    ./tcl/test/http-client-procs.tcl
    • -13
    • +1
    ./tcl/test/security-procs.tcl
  3. … 4 more files in changeset.
Thursday 08 Sep 2022
6:16 pm

antoniop

Allow to deprecate ad_page_contract_filters, improve doc

Options
    • -4
    • +11
    ./tcl/tcl-documentation-procs.tcl
12:12 pm

antoniop

Deprecate color widget api, superseded by HTML5 features

Options
    • -5
    • +22
    ./tcl/widgets-procs.tcl
10:41 am

antoniop

Increase proc coverage

Options
    • -0
    • +50
    ./tcl/test/navigation-procs.tcl
10:13 am

antoniop

Increase test coverage

Options
    • -0
    • +6
    ./tcl/test/defs-procs.tcl
Wednesday 07 Sep 2022
4:35 pm

antoniop

Deprecate ad_approval_system_inuse_p

Options
    • -2
    • +8
    ./tcl/admin-procs.tcl
4:22 pm

antoniop

Fix implementation of ad_acs_admin_node so that the node_id is returned as stated in the doc

For the one occurrence that treated this proc as boolean, the result will be the same (e.g. 0 = false and any other id = true)

Options
    • -15
    • +12
    ./tcl/acs-kernel-procs.tcl
    • -16
    • +0
    ./tcl/acs-kernel-procs.xql
4:16 pm

antoniop

Test some system information api

The test shows that ad_acs_admin_node has so far returned a boolean, countrary to what the documentation says

Options
    • -0
    • +52
    ./tcl/test/acs-kernel-procs.tcl
4:16 pm

antoniop

file acs-kernel-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/acs-kernel-procs.tcl
3:56 pm

antoniop

When demoting a user, flush the permissions cache as well

Options
    • -1
    • +7
    ./tcl/community-core-procs.tcl
3:53 pm

antoniop

Test demoting/promoting of a user + a buch of other api

This test fails now when checking if a demoted user is still an swa, one needs to flush the permissions as well

Options
    • -1
    • +103
    ./tcl/test/community-core-test-procs.tcl
2:51 pm

antoniop

Test acs_user::ScreenName

Options
    • -1
    • +42
    ./tcl/test/community-core-test-procs.tcl
12:27 pm

antoniop

Test acs_object_type_hierarchy

Options
    • -1
    • +76
    ./tcl/test/object-test-case-procs.tcl
Tuesday 06 Sep 2022
2:41 pm

antoniop

Test acs_object_type::get_table_name

Options
    • -1
    • +21
    ./tcl/test/object-test-case-procs.tcl
2:31 pm

antoniop

Test acs_object_name api

Options
    • -1
    • +21
    ./tcl/test/object-test-case-procs.tcl