OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 73
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 74,868
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 Mar 2022
6:01 pm

gustafn

Make ad_html_security_check configurable

ad_html_security_check has now three optional attributes

to make it configurable for different situations

-allowed_tags

-allowed_attributes

-allowed_protocols

If these attributes are not specified, the behavior is exactly like

before. This change makes it also easier to regression test this

function, since the behavior does not necessarily depend on a site's

parameter settings.

The function was also modernized, new regression tests were added.

Options
    • -47
    • +78
    ./tcl/text-html-procs.tcl
    • -20
    • +39
    ./tcl/test/html-conversion-procs.tcl
Wednesday 23 Feb 2022
3:18 pm

gustafn

make sure, the dependencies are aligned (drop of xo::site_node)

Options
    • -2
    • +2
    ./acs-tcl.info
  2. … 1 more file in changeset.
Tuesday 22 Feb 2022
12:24 pm

gustafn

Improve spelling

Options
    • -1
    • +1
    ./tcl/acs-db-00-procs.tcl
    • -1
    • +1
    ./tcl/site-nodes-procs.tcl
12:24 pm

gustafn

Fine-tuning the new db function interface

#

# Check, wether we have to regenerate the database function interface.

#

# - During initial setup, there are no db-functions, so nothing has to

# be done.

#

# - During regular startup of the server, the generation of the stub

# interface happens in the *init procs (hopefully this is always

# sufficient, but seems so)

#

# - During reloads of acs-db-*-procs, the base classes are interface

# objects are recreated and cleaned up from all prior definitons,

# which means that in this situations, we have to regeneate the

# interface.

#

# - One might call manually the regeneration, when database functions

# have been altered and no restart is desired.

#

Options
    • -10
    • +41
    ./tcl/acs-db-12-procs.tcl
Monday 21 Feb 2022
9:35 pm

gustafn

Reform of site-nodes-procs

- made XOTcl2 based implementation of site-nodes usable during

initial bootstrap

- made new site-node cache implementation working for Oracle

- now, the same code works during bootstrap, for PostgreSQL and Oracle

and independent of xotcl-core being installed or not.

- removed old and broken nsv-based site-node cache

- reduced need of .xql files (removed query for delete.delete_site_node)

- moved deprecated calls to deprecated-procs.tcl

This change make the code much clearer and eases maintenance and debugging.

Options
    • -327
    • +499
    ./tcl/deprecated-procs.tcl
    • -6
    • +0
    ./tcl/site-nodes-procs-oracle.xql
    • -6
    • +0
    ./tcl/site-nodes-procs-postgresql.xql
    • -1587
    • +777
    ./tcl/site-nodes-procs.tcl
9:27 pm

gustafn

Update of SQL function calling interface to make it usable during initial bootstrap

- add sanity checks and produce error messages,

when function args are incorrect.

- do not throw errors in case it is called before the

table acs_function_args was created (during boot)

- added preliminary "list" call to acs::dc

- added first *-init.tcl to be called after loading

the *-proc.tcl files.

- removed all references to the ::xo::* namespace

Options
    • -0
    • +9
    ./tcl/00-acs-tcl-init.tcl
    • -1
    • +0
    ./tcl/20-memoize-init.tcl
    • -3
    • +29
    ./tcl/acs-db-00-procs.tcl
    • -7
    • +50
    ./tcl/acs-db-12-procs.tcl
9:27 pm

gustafn

file 00-acs-tcl-init.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/00-acs-tcl-init.tcl
9:13 pm

gustafn

Make parameter::get_from_package_key usable during inital boot

This change makes parameter::get_from_package_key usable during

initial boot, i.e. before the table apm_parameters is created.

In these cases, the function returns just the default value.

Options
    • -55
    • +71
    ./tcl/parameter-procs.tcl
9:11 pm

gustafn

Support memory units as default of the cache sizes

Options
    • -1
    • +1
    ./tcl/acs-cache-procs.tcl
8:42 pm

gustafn

update questionable test slightly

Options
    • -11
    • +5
    ./tcl/test/db-proc-test-procs.tcl
9:49 am

gustafn

improve spelling and formulations

Options
    • -9
    • +10
    ./tcl/acs-db-12-procs.tcl
    • -2
    • +2
    ./tcl/request-processor-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
Sunday 20 Feb 2022
8:45 pm

gustafn

Added new interface for calling database functions

This is tested for PostgreSQL and Oracle and the drivers nsdb and nsdbi.

For details, see https://openacs.org/xowiki/calling-database-functions

Options
    • -2
    • +2
    ./acs-tcl.info
    • -0
    • +179
    ./tcl/acs-db-00-procs.tcl
    • -0
    • +561
    ./tcl/acs-db-12-procs.tcl
8:45 pm

gustafn

file acs-db-00-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/acs-db-00-procs.tcl
8:45 pm

gustafn

file acs-db-12-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/acs-db-12-procs.tcl
2:18 pm

gustafn

minor cleanup to make code more consistent

Options
    • -17
    • +7
    ./tcl/01-database-procs.tcl
Friday 18 Feb 2022
1:37 pm

gustafn

util::file_content_check: new utility for checking content of a file

Check whether the provided file is of the requested type.

This function is more robust and protable than relying on

external programs and their output, but it does not work on

all possible file types. It checks a few common cases that

could lead to problems otherwise, like when uploading archives.

Bump version to 5.10.1d9

Options
    • -2
    • +2
    ./acs-tcl.info
    • -2
    • +40
    ./tcl/utilities-procs.tcl
    • -0
    • +24
    ./tcl/test/utilities-procs.tcl
1:34 pm

gustafn

minor changes: don't complain about postgres internal constraint names, provide hints for oversizing

Options
    • -11
    • +33
    ./tcl/test/datamodel-test-procs.tcl
12:50 pm

gustafn

more cases, use same testing idiom for permissions everywhere, break overlong lines

Options
    • -10
    • +16
    ./tcl/test/test-permissions-procs.tcl
12:45 pm

gustafn

fix test cases

Options
    • -14
    • +14
    ./tcl/test/test-permissions-procs.tcl
12:36 pm

gustafn

revert last change of Antonio, since this kills Oracle again

It is not clear, which code needs integer as results for Boolean results.

If there is such code, it should handle this requirement locally.

Options
    • -2
    • +2
    ./tcl/acs-permissions-procs.tcl
10:42 am

antoniop

Reintroduce cast to integer using a portable idiom

Options
    • -2
    • +2
    ./tcl/acs-permissions-procs.tcl
Tuesday 15 Feb 2022
6:10 pm

gustafn

Fixes for Oracle 19c: invalid cast to integer

This fixes the following bug for Oracle:

: invalid positional variable `:', valid values start with 1

: while executing

: "ns_ora 0or1row nsdb0 {

: select acs_permission.permission_p(:object_id, :party_id, :privilege)::integer from dual

: }"

Options
    • -2
    • +2
    ./tcl/acs-permissions-procs.tcl
6:00 pm

gustafn

fix editing bug

V: ----------------------------------------------------------------------

Options
    • -2
    • +1
    ./tcl/community-core-procs.tcl
5:57 pm

gustafn

Fixes for Oracle 19c boolean types in query

This fixes the following bug for Oracle:

: select u.user_id,

: u.authority_id,

: u.username,

: u.screen_name,

: u.priv_name,

: u.priv_email,

: u.email_verified_p,

: u.email_bouncing_p,

: u.no_alerts_until,

: u.last_visit,

: to_char(last_visit, 'YYYY-MM-DD HH24:MI:SS') as last_visit_ansi,

: u.second_to_last_visit,

: to_char(second_to_last_visit, 'YYYY-MM-DD HH24:MI:SS') as second_to_last_visit_ansi,

: u.n_sessions,

: u.password,

: u.salt,

: u.password_question,

: u.password_answer,

: u.password_changed_date,

: extract(day from current_timestamp - password_changed_date) as password_age_days,

: u.auth_token,

: mm.rel_id,

: mr.member_state !>>>!= 'approved' as registered_user_p,

: mr.member_state

: from users u

: left join group_member_map mm on mm.member_id = u.user_id

: and mm.group_id = mm.container_id

: and mm.group_id = :registered_users_group_id

: and mm.rel_type = 'membership_rel'

: left join membership_rels mr on mr.rel_id = mm.rel_id

: where u.user_id = :user_id

Options
    • -1
    • +2
    ./tcl/community-core-procs.tcl
Thursday 10 Feb 2022
10:33 pm

gustafn

fixes for Oracle 19c

Options
    • -0
    • +1
    ./tcl/20-memoize-init.tcl
    • -2
    • +2
    ./tcl/acs-kernel-procs.tcl
    • -4
    • +5
    ./tcl/apm-procs.tcl
  4. … 3 more files in changeset.
Monday 07 Feb 2022
1:21 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
    • -3
    • +3
    ./tcl/utilities-procs.tcl
    • -1
    • +1
    ./tcl/test/proxy-test-procs.tcl
1:13 pm

gustafn

extend tests and pinpoint essesntials

Options
    • -0
    • +20
    ./tcl/test/db-proc-test-procs.tcl
11:30 am

antoniop

Cleanup smelly comment: we don't need to catch the error, if it fails it fails and the application should handle it

Options
    • -2
    • +1
    ./tcl/utilities-procs.tcl
11:20 am

antoniop

Minimize and corrrect test: strings containing the null character are expected to fail when fed to the DBMS, even when quoted

Options
    • -10
    • +14
    ./tcl/test/db-proc-test-procs.tcl
    • -109
    • +0
    ./tcl/test/data/db-quoting-test.txt
Thursday 03 Feb 2022
3:33 pm

antoniop

New automated test

Options
    • -0
    • +18
    ./tcl/test/db-proc-test-procs.tcl
    • -0
    • +109
    ./tcl/test/data/db-quoting-test.txt