OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 2
Total Committers: 73
Last Commit: 19 Jan
Commits this week: 2
Total Lines of Code (LoC): 74,868
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 02 Nov 2021
11:29 am

gustafn

Performance improvement: make "apm_version_names_compare" faster by a factor of ~100

The function "apm_version_names_compare" is called relatively often

and issues an SQL query. The function is stable (returns always the

same results for the same input) and called with only a few different

input values. By using acs::per_thread_cache the performance improves

from 265 microseconds to 2 microseconds; by using the per-tread cache

the operation scales better since it is fully lock-free (once cached).

Options
    • -13
    • +11
    ./tcl/apm-install-procs.tcl
Friday 29 Oct 2021
12:35 pm

gustafn

added support for "ns_trim -prefix".

The command is predefined in NaviServer; if not available, a comatibility version is added.

This change also mitigates a potential memory-leak problem in nsv_dict with certain

versions of NaviServer which might lead on busy sites to problems.

Options
    • -2
    • +2
    ./acs-tcl.info
    • -12
    • +39
    ./tcl/00-icanuse-procs.tcl
  3. … 2 more files in changeset.
Wednesday 27 Oct 2021
6:46 pm

gustafn

remove incorrect and misleading comment and simplify code accordingly

Options
    • -15
    • +7
    ./tcl/parameter-procs.tcl
6:42 pm

gustafn

set the global variable ::acs::kernel_id early enough during boostrap of new instances, such it can be used in a uniform way

Options
    • -2
    • +6
    ./tcl/20-memoize-init.tcl
    • -5
    • +5
    ./tcl/server-cluster-procs.tcl
  3. … 1 more file in changeset.
6:34 pm

gustafn

improve comment

Options
    • -3
    • +3
    ./tcl/site-nodes-procs.tcl
Tuesday 19 Oct 2021
11:07 am

gustafn

extend tests for naturalnum

Options
    • -1
    • +1
    ./tcl/test/acs-tcl-test-procs.tcl
Monday 18 Oct 2021
6:31 pm

antoniop

Prefer api to retrieve the acs-kernel id, as this will work also in corercases such as bootstraping of a new OpenACS instance

Options
    • -1
    • +1
    ./tcl/20-memoize-init.tcl
    • -5
    • +5
    ./tcl/server-cluster-procs.tcl
Friday 15 Oct 2021
4:18 pm

gustafn

fix wrong name (not sure, why i have not noticed this earlier)

Options
    • -2
    • +2
    ./tcl/site-nodes-procs.tcl
Wednesday 13 Oct 2021
9:18 pm

gustafn

perform also sitewide flushes for urspace based site-node cache

Options
    • -0
    • +1
    ./tcl/acs-cache-procs.tcl
    • -2
    • +2
    ./tcl/site-nodes-procs.tcl
Tuesday 12 Oct 2021
10:56 am

gustafn

More work on refactoring and streamlining cluster infrastructure

- removed more cases of ad-hoc parsing of IP address and port

- reduced code redundancy

- fixed incorrect comments

- removed obsolete private functions server_cluster_httpget_from_peers

and server_cluster_do_httpget (replaced by acs::clusterwide)

Options
    • -9
    • +12
    ./tcl/cluster-init.tcl
    • -51
    • +43
    ./tcl/server-cluster-procs.tcl
Monday 11 Oct 2021
10:11 pm

gustafn

Refactored and streamlined of cluster infrastructure

- base the API new new cluster infrastructure (including memoize-flush, server_cluster_peer_hosts, etc.)

- improved handling for multiple IP addresses and IPv6

- removed assumptions of local vs. global network drivers

- server_cluster_httpget_from_peers not used anymore

Options
    • -35
    • +1
    ./tcl/20-memoize-init.tcl
    • -19
    • +50
    ./tcl/acs-cache-procs.tcl
    • -19
    • +38
    ./tcl/cluster-init.tcl
    • -1
    • +10
    ./tcl/memoize-procs.tcl
    • -23
    • +13
    ./tcl/server-cluster-procs.tcl
  6. … 1 more file in changeset.
Thursday 07 Oct 2021
5:42 pm

gustafn

Provide a default timeout of 5m to all ns_cache besed caches created via the acs-cache infrastructure

Background: in case, a db entry is to be cached, where the db query

does not finish (e.g. runs into a deadlock), subsequent attempts for

the same value will be blocked as well by the mutex protecting the

entry to be cached. Therefore, later requests to this entry might queue

up in the server. By providing a timeout, this mutex will terminate

latest when the timeout is reached.

The default value for the timeout is set to 5m. In case a certain

cache might issue requests running longer than this, the cache has

to be configured with a larger timeout value.

Options
    • -0
    • +2
    ./tcl/acs-cache-procs.tcl
1:07 pm

gustafn

improve spelling

Options
    • -8
    • +8
    ./tcl/utilities-procs.tcl
Wednesday 06 Oct 2021
2:21 pm

trenner

provide a fork-free implementation of dot rendering

Options
    • -4
    • +5
    ./tcl/utilities-procs.tcl
Monday 04 Oct 2021
11:37 am

gustafn

Improving ad_parameter_cache:

- added handling of cachingmode "none"

- added implementation via "nsv_dict" (cluster aware)

- execute parameter callbacks cluster-wide

- version number bumped to 5.10.1d4

Options
    • -2
    • +2
    ./acs-tcl.info
    • -7
    • +9
    ./tcl/acs-cache-procs.tcl
    • -47
    • +165
    ./tcl/defs-procs.tcl
    • -3
    • +3
    ./tcl/parameter-procs.tcl
11:35 am

gustafn

improve spelling

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
Sunday 03 Oct 2021
8:13 pm

gustafn

added support for SCRYPT (RFC 7914) as password hash function.

The use of scrypt requires NaviServer compiled with OpenSSL 3.0 or newer

Options
    • -2
    • +15
    ./tcl/security-procs.tcl
  2. … 1 more file in changeset.
Friday 01 Oct 2021
9:30 am

gustafn

stick to the original names with the "-" since this is also the naming convention outside of OpenACS (e.g. "scram-sha-256")

Options
    • -3
    • +3
    ./acs-tcl.info
    • -7
    • +7
    ./tcl/security-procs.tcl
    • -2
    • +4
    ./tcl/test/doc-check-procs.tcl
  4. … 5 more files in changeset.
Thursday 30 Sep 2021
6:21 pm

antoniop

Set ad_include_contract's local variables in a way that they are hinted as private by the "__" prefix: this reduces the chance of conflicting with popular variable names to pass to an include such as "context"

Options
    • -5
    • +5
    ./tcl/tcl-documentation-procs.tcl
2:34 pm

gustafn

Change caching of driver keys

There seems to be a bug in "db_driverkey", when OpenACS connects to

multiple databases [1]. The situation with "db_driverkey" is

complicated by the fact that this function is sometimes called with a

database name in its argument "dbn", and sometimes with a database

handle. This is something to look at in the future.

The new version removes the per-thread caching, which was introduced

to reduce the high number of mutex locks caused in busy machines. The

new version is better by a factor of 2 than older versions, but relies

on NaviServer.

[1] https://openacs.org/forums/message-view?message_id=5537865

Options
    • -33
    • +42
    ./tcl/01-database-procs.tcl
Wednesday 29 Sep 2021
2:09 pm

antoniop

Complete reform introduced in https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20210928124647

- add datamodel change to the creation script

- refactor algorithm names in a way that the new procs will comply with acs-tcl.naming__proc_naming automated test

Options
    • -3
    • +3
    ./acs-tcl.info
    • -7
    • +7
    ./tcl/security-procs.tcl
  3. … 5 more files in changeset.
Tuesday 28 Sep 2021
2:46 pm

gustafn

Stronger password hashes for OpenACS

This change introduces the possibility to use either the classical

OpenACS password hash algorithm "salted-sha1" or the SCRAM passord

function "scram-sha-256". The latter can be used by (a) using the

most recent version of NaviServer (from Sept 28, 2021 or newer) and

(b) by configuring the password hash preferences via Kernel package

parameter "PasswordHashAlgorithm". The package parameter can contain a

list of multiple hash algorithms in preference order. The most

preferred available algorithm is chosen.

By default, the "PasswordHashAlgorithm" is "salted-sha1", and the

behavior is as before. After upgrading to the new version of acs-tcl

and acs-kernel, the preference list can be configured. When a user

logs in and the preferred available algorithm is different from the

previously used algorithm, the upgrade is performed for the user

automatically.

The usage of SHA1 in OpenACS is easily target of security audits (see

[1]). The biggest danger is that if somebody gets full access to the

"users" table (e.g. when decommissioning a hard disk). In this case

the hashes can be attacked with dictionaries by using some crypto

hardware (when someone gets raw access to the DB, one has usually some

other big problems). However, by using the "scram-sha-256" hash

function this danger is substantially reduced. This function computes

a password hash using PBKDF2 (Password-Based Key Derivation Function

2). This function is used to reduce vulnerabilities of brute-force

attacks against password hashes. The hash function of SCRAM is PBKDF2

[RFC2898] with HMAC as the pseudorandom function (PRF) and with dkLen

== output length of HMAC == output length of the digest function. So,

it uses a better hash algorithm (sha-256 vs. sha1) and applies this a

high number of times (15K times for a password hash computation).

NaviServer supports as well the even better SCRYPT algorithm, but this

is only available when NaviServer is compiled with OpenSSL 3.0 or

newer. On the contrary, scram-sha-256 (actually PKCS5_PBKDF2_HMAC) is

available since OpenSSL 1.0.0 (2015).

All the improved hash functions require NaviServer with its tight

integration to the crypto functions of OpenSSL.

[1] https://openacs.org/forums/message-view?message_id=5522562

Options
    • -3
    • +3
    ./acs-tcl.info
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl
    • -14
    • +103
    ./tcl/security-procs.tcl
    • -17
    • +0
    ./tcl/security-procs.xql
  5. … 3 more files in changeset.
Monday 27 Sep 2021
1:28 pm

antoniop

Add missing argument expansion and comply with automated test

Options
    • -3
    • +3
    ./tcl/request-processor-procs.tcl
1:27 pm

antoniop

Test for ad_register_proc exposing a bug due to missing argument expansion

Options
    • -0
    • +159
    ./tcl/test/request-processor-procs.tcl
1:27 pm

antoniop

file request-processor-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/request-processor-procs.tcl
Friday 24 Sep 2021
1:38 pm

gustafn

Improved spelling

Options
    • -2
    • +2
    ./tcl/tcl-documentation-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
1:31 pm

gustafn

let the per_thread_cache behave like the per_connection_cache when the NaviServer configuration valriable "cachingmode" is set to none

Options
    • -9
    • +24
    ./tcl/acs-cache-procs.tcl
Thursday 16 Sep 2021
10:27 am

gustafn

fix release dates in .info files

Options
    • -1
    • +1
    ./acs-tcl.info
  2. … 82 more files in changeset.
Wednesday 15 Sep 2021
6:11 pm

gustafn

release work

Options
    • -4
    • +4
    ./acs-tcl.info
  2. … 204 more files in changeset.
Monday 06 Sep 2021
6:56 pm

antoniop

Unwrap fake oneliners

Options
    • -8
    • +30
    ./tcl/text-html-procs.tcl