• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Simplify expressions

Whitespace changes

Whitespace cleanup

Remove proc doc duplication in 'db_1row'. As the proc is essentially a wrapper for 'db_0or1row', just a pointer is better, avoiding future issues if parameters change.

Whitespace cleanup

    • -15
    • +15
    ./tcl/request-processor-procs.tcl
Harmonize parameter names in proc documentation removing unexistent ones

Fix parameter name in proc doc

Fix parameter names in proc doc

Fix parameter names in proc doc

Whitespace changes

  1. … 1 more file in changeset.
Whitespace changes

    • -56
    • +56
    ./tcl/application-data-link-procs.tcl
  1. … 1 more file in changeset.
Fix parameter names and descriptions in proc doc

Fix misleading and uncoherent 'apm_data_model_scripts_find' proc documentation

Fix parameter names in proc doc

Whitespace changeds

    • -261
    • +261
    ./tcl/deprecated-procs.tcl
Harmonize parameter names in proc documentation removing unnecessary hyphens

  1. … 1 more file in changeset.
Fix parameter name

Allow square brackets in proc doc. In particular, this fixed a false positive with [doc_string] in 'ad_proc'

Improve 'args' check in 'documentation__check_parameters' test case by using the built-in 'varargs_p' variable.

Add 'args' parameter to the real parameter list of the 'documentation__check_parameters', as it is not included into 'switches' or 'positionals'.

Use 'apm_get_package_files -file_types' instead of filtering the 'www' and 'lib' directories manually.

Take care of '_p' boolean parameters when checking for discrepancies between real and documented proc parameters.

Overhaul of test cases:

- make tested API calls explict

- reduce dependency on twt

    • -1
    • +98
    ./tcl/test/apm-parameter-test-procs.tcl
    • -113
    • +141
    ./tcl/test/application-data-link-procs.tcl
    • -8
    • +28
    ./tcl/test/community-core-test-procs.tcl
    • -15
    • +33
    ./tcl/test/datamodel-test-procs.tcl
    • -29
    • +174
    ./tcl/test/html-conversion-procs.tcl
    • -12
    • +20
    ./tcl/test/openacs-kernel-procs.tcl
    • -12
    • +21
    ./tcl/test/test-membership-rel-procs.tcl
  1. … 4 more files in changeset.
don't leak user_ids from regression test case

    • -10
    • +9
    ./tcl/test/community-core-test-procs.tcl
make tested API calls explicit

    • -7
    • +23
    ./tcl/test/site-nodes-test-procs.tcl
prefer built-in ns_dbquotevalue over DoubleApos

make former private functions, used in several packages to public functions

improve spelling

  1. … 2 more files in changeset.
Add new test case 'documentation__check_parameters', which checks if parameters defined in the proc doc (@param) are really proc parameters.

Sometimes proc parameter changes are not reflected in the proc doc, this should take care of some of these cases.

improve spelling