OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 73
Last Commit: 26 Apr
Commits this week: 1
Total Lines of Code (LoC): 68,337
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 14 May 2018
5:11 pm

antoniop

Deprecate proc apm_pretty_name_for_db_type as is not used anywhere and also relies on questionable datamodel

Options
    • -14
    • +25
    ./tcl/apm-procs.tcl
3:22 pm

gustafn

make spelling of names more consistent

Options
    • -3
    • +3
    ./tcl/form-processing-procs.tcl
    • -2
    • +2
    ./tcl/navigation-procs.tcl
    • -2
    • +2
    ./tcl/security-procs.tcl
    • -2
    • +2
    ./tcl/text-html-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs-aolserver.tcl
    • -2
    • +2
    ./tcl/utilities-procs-naviserver.tcl
3:21 pm

gustafn

site-nodes cache reform: use ns_urlsspace instead of brute-force caching.

For OpenACS site with recent versions of NaviServer and XOTcl2,

cache sitenode information much more efficiently by the built-in

URL trie, which supports tree match operations, for

tree information. This means that for example for .vuh

handlers it is not necessary to cache the full url for

obtaining the site-node, like it was until now:

3839 id-/storage/view/installers/windows-installer/installer.htm

3839 id-/storage/view/aolserver/install.tgz

3839 id-/storage/view/tutorial/OpenACS_Tutorial.htm

3839 id-/storage/view/openacs-dotlrn-conference-2007-spring/Methodology_ALPE.pdf

3839 id-/storage/view/xowiki-resources/Assessment.jpg

3839 id-/storage/view/tutorial-page-map.png

...

Providing a single entry like

ns_urlspace set -key sitenode /storage/* 3839

is sufficient.

Why is this needed: current cache sizes of larger sites show 330K

(site A) and 390K (site B) cache entries. Matchbase flushes have to

gor thhrough all these entries, causing long lock times. Running

thhis code at OpenACS.org shows an improvement by a factor of more

than 200x.

Options
    • -1
    • +29
    ./tcl/site-nodes-init.tcl
    • -252
    • +343
    ./tcl/site-nodes-procs.tcl
3:14 pm

antoniop

Use proper thread cached variables instead of legacy proc

Options
    • -2
    • +2
    ./tcl/apm-file-procs.tcl
2:49 pm

antoniop

Deprecate proc 'apm_db_type_keys' as the info it provides is already in 'ad_known_database_types' without need for queries

TODO: find out if we really need a table of database types

Options
    • -11
    • +19
    ./tcl/apm-file-procs.tcl
    • -7
    • +0
    ./tcl/apm-file-procs.xql
Friday 11 May 2018
11:16 am

antoniop

Improve indentation, use non indentation-breaking idioms to create report string

TODO: refactor this bug-tracker dependency outside the core, e.g. using a callback

Options
    • -112
    • +113
    ./lib/page-error.tcl
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -3
    • +3
    ./lib/page-error.tcl
    • -21
    • +21
    ./tcl/00-database-procs.tcl
    • -3
    • +3
    ./tcl/admin-procs.tcl
    • -20
    • +20
    ./tcl/apm-install-procs.tcl
    • -18
    • +18
    ./tcl/apm-procs.tcl
    • -2
    • +2
    ./tcl/application-data-link-procs.tcl
    • -3
    • +3
    ./tcl/community-core-procs.tcl
    • -2
    • +2
    ./tcl/defs-procs.tcl
    • -13
    • +13
    ./tcl/deprecated-procs.tcl
    • -7
    • +7
    ./tcl/form-processing-procs.tcl
    • -4
    • +4
    ./tcl/html-procs.tcl
    • -4
    • +4
    ./tcl/http-client-procs.tcl
    • -3
    • +3
    ./tcl/install-procs.tcl
    • -4
    • +4
    ./tcl/navigation-procs.tcl
    • -3
    • +3
    ./tcl/request-processor-init.tcl
  16. … 461 more files in changeset.
12:37 am

hectorr

Rework variable assigning loops (set -> lassign) + Whitespace changes

Options
    • -5
    • +3
    ./tcl/00-database-procs.tcl
    • -36
    • +35
    ./tcl/pools-init.tcl
  3. … 12 more files in changeset.
Wednesday 02 May 2018
9:19 am

gustafn

improve CSP in accordance with Google's csp-evaluator.withgoogle.com

Options
    • -2
    • +9
    ./tcl/security-procs.tcl
  2. … 1 more file in changeset.
Monday 30 Apr 2018
5:34 pm

hectorr

Prefer 'lappend' to 'set ... concat' for appending elements to lists + Whitespace changes

Options
    • -2
    • +2
    ./tcl/apm-install-procs.tcl
  2. … 3 more files in changeset.
11:14 am

gustafn

remove duplicated words

Options
    • -3
    • +3
    ./tcl/deprecated-procs.tcl
  2. … 9 more files in changeset.
Wednesday 25 Apr 2018
9:47 pm

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -13
    • +13
    ./tcl/deprecated-procs.tcl
  2. … 204 more files in changeset.
9:23 pm

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -3
    • +3
    ./lib/page-error.tcl
    • -21
    • +21
    ./tcl/00-database-procs.tcl
    • -3
    • +3
    ./tcl/admin-procs.tcl
    • -20
    • +20
    ./tcl/apm-install-procs.tcl
    • -18
    • +18
    ./tcl/apm-procs.tcl
    • -2
    • +2
    ./tcl/application-data-link-procs.tcl
    • -3
    • +3
    ./tcl/community-core-procs.tcl
    • -2
    • +2
    ./tcl/defs-procs.tcl
    • -7
    • +7
    ./tcl/form-processing-procs.tcl
    • -4
    • +4
    ./tcl/html-procs.tcl
    • -4
    • +4
    ./tcl/http-client-procs.tcl
    • -3
    • +3
    ./tcl/install-procs.tcl
    • -4
    • +4
    ./tcl/navigation-procs.tcl
    • -3
    • +3
    ./tcl/request-processor-init.tcl
    • -6
    • +6
    ./tcl/request-processor-procs.tcl
  16. … 57 more files in changeset.
10:47 am

gustafn

improve documentation, remove obsolete documentation

Options
    • -25
    • +7
    ./tcl/request-processor-procs.tcl
10:46 am

gustafn

improve documentation

Options
    • -7
    • +7
    ./tcl/00-database-procs.tcl
    • -2
    • +2
    ./tcl/apm-install-procs.tcl
    • -2
    • +2
    ./tcl/apm-procs.tcl
    • -2
    • +2
    ./tcl/community-core-procs.tcl
    • -20
    • +28
    ./tcl/deprecated-procs.tcl
    • -3
    • +3
    ./tcl/install-procs.tcl
    • -2
    • +2
    ./tcl/membership-rel-procs.tcl
    • -11
    • +10
    ./tcl/utilities-procs-aolserver.tcl
    • -11
    • +10
    ./tcl/utilities-procs-naviserver.tcl
  10. … 2 more files in changeset.
Monday 23 Apr 2018
8:24 pm

hectorr

Rework variable assignment (set -> lassign)

Options
    • -173
    • +160
    ./tcl/apm-install-procs.tcl
  2. … 1 more file in changeset.
9:14 am

gustafn

fix typos

Options
    • -2
    • +2
    ./tcl/tcl-documentation-procs.tcl
  2. … 7 more files in changeset.
Wednesday 18 Apr 2018
10:58 pm

hectorr

Fix typos

Options
    • -2
    • +2
    ./tcl/adp-parser-procs.tcl
    • -3
    • +3
    ./tcl/apm-procs.tcl
    • -11
    • +11
    ./tcl/test/acs-tcl-test-procs.tcl
  4. … 1 more file in changeset.
11:09 am

hectorr

Fix typos

Options
    • -5
    • +5
    ./tcl/apm-install-procs.tcl
  2. … 11 more files in changeset.
Thursday 12 Apr 2018
8:40 am

gustafn

fix singular/plural typos

Options
    • -3
    • +3
    ./tcl/deprecated-procs.tcl
  2. … 6 more files in changeset.
Wednesday 11 Apr 2018
11:35 pm

hectorr

Fix typos

Options
    • -2
    • +2
    ./tcl/acs-permissions-procs.tcl
    • -3
    • +3
    ./tcl/deprecated-procs.tcl
    • -2
    • +2
    ./tcl/tcl-documentation-procs.tcl
    • -7
    • +6
    ./tcl/text-html-procs.tcl
  5. … 28 more files in changeset.
Monday 09 Apr 2018
11:20 pm

hectorr

Remove extra line

Options
    • -2
    • +1
    ./tcl/site-nodes-procs.tcl
11:16 pm

hectorr

Prefer 'in' and 'ni' operators over lsearch for testing list containment

Options
    • -1
    • +2
    ./tcl/site-nodes-procs.tcl
  2. … 3 more files in changeset.
10:11 pm

hectorr

Prefer lappend over concat for appending lists (lappend modifies the variable 'in place')

Options
    • -5
    • +5
    ./tcl/ad-functional-procs.tcl
    • -3
    • +3
    ./tcl/apm-procs.tcl
    • -5
    • +5
    ./tcl/utilities-procs.tcl
  4. … 3 more files in changeset.
Saturday 07 Apr 2018
10:48 am

gustafn

Mark procs as deprecated, which were previously just documented as

deprecated and document recommended versions via @see. These procs

should be moved to *deprecated*.tcl after a while to give people

a chance to react (maybe in 5.11 or 5.12).

site_node::conn_url -> ad_conn

site_nodes_sync -> site_node::init_cache

site_node_id -> site_node::get_node_id -url

site_map_unmount_application -> site_node::unmount

site_node_delete_package_instance -> site_node::delete

Options
    • -6
    • +12
    ./tcl/site-nodes-procs.tcl
Friday 06 Apr 2018
6:31 pm

hectorr

Prefer lappend over concat for appending lists (lappend modifies the variable 'in place')

Options
    • -2
    • +2
    ./tcl/00-database-procs.tcl
5:40 pm

gustafn

modermize tcl

Options
    • -5
    • +5
    ./tcl/navigation-procs.tcl
5:02 pm

gustafn

modernize tcl

Options
    • -2
    • +2
    ./tcl/navigation-procs.tcl
    • -2
    • +3
    ./tcl/request-processor-procs.tcl
    • -5
    • +7
    ./tcl/xml-1-dom-procs.tcl
  4. … 1 more file in changeset.
Wednesday 04 Apr 2018
11:31 pm

hectorr

Fix typo (db_list_of_list -> db_list_of_lists)

Options
    • -1
    • +1
    ./tcl/test/acs-tcl-test-procs.tcl
  2. … 2 more files in changeset.
8:51 pm

hectorr

Fix typos

Options
    • -1
    • +1
    ./tcl/form-processing-procs.tcl
    • -2
    • +2
    ./tcl/test/navigation-procs.tcl
  3. … 33 more files in changeset.