• last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
refactor login cookie handling

The old code required repeated execption handlers.

Now, these exception handlers are on one place, and

users of sec_login_read_cookie can rely that a dict

is returned

added exception handler for sec_login_get_external_registry

This is necessary for cases, where no login cookie exists

call directly ns_getform

revert escaped changes

don't assume, the oauth package is installed

External identity provider reform (part 3)

- logout from external identity provider, if logged in via it

- extend default login page via ADP include, when external

identity providers are configured.

  1. … 5 more files in changeset.
External identity provider reform (part 2)

Use the external identity provider for refresh of logins. When a user

is logged in via an external identity provider, use the same identity

provider for a refresh when it expires. The expiration time is

controlled via the classical OpenACS parameters.

Note that in general, the same user might be authenticated via a

classical OpenACS authority (e.g. local authority) and/or via an

external one (e.g. Microsoft Identity Platform (Azure) or GitHub).

For single-sign-ons, when the token is still valid, the redirect to

the external identity provider does not mean necessarily that the use

is shown the external identity provider's login page.

  1. … 3 more files in changeset.
whitespace changes

Added preliminary support for secondary registries (e.g., MS Azure via oauth2)

- When login happened via external registry, the logout should happen

there as well.

- let "sec_login_read_cookie" return a dict instead of a list

(eases future extension)

- bump version number to 5.10.1d31

  1. … 1 more file in changeset.
improve spelling

Reintroduce exec-based approach for unzipping, as zipfile::decode will not handle files > 2GB well

Re-introduce the exec and document why

Close channel

Provide exec-free implementation of tarball extraction

Deprecate apm_file_type_keys, which can be inlined by a simple dict idiom

Avoid dubious catches, collect more logics in the proc

Test apm_workspace directory api

Add missing flag -file to the api call

Test creating and extracting an APM Package tarball

file apm-file-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/apm-file-procs.tcl
As tcllib was released in 2016, I believe we can cleanup the legacy zip implementation

Provide exec-free implementation of util::unzip using zipfile::decode

Extend the test to cover also cornercase behavior concerning overwriting of files

Test zipping and unzipping utilities

Make test less tautological

Test for psql only when this is expected

Fallback to the location of the psql executable when a pgbin was not explicitly defined in the config file (which is allowed)

Test external command dependencies

This will currently fail because of a bug in db_get_pgbin

Test ad_change_password

Add notes about api

    • -5
    • +21
    ./site-node-apm-integration-procs.tcl