• last updated 54 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve spelling

  1. … 3 more files in changeset.
ad_form: allow multiple files in 'template::widget::file' by using the 'multiple' attribute of the input tag, new on HTML5.

- Pass the 'multiple' flag to 'template::element::create', so it can be used by widgets to modify their behavior.

- Update 'template::element::create' doc.

- This opens the door to reducing the number of widgets by combining single and multivalued ones into one (for instance, 'multiselect' and 'select' widgets), in the same way the 'file' widget does now.

  1. … 2 more files in changeset.
add "blob" to the checked attributes

add checking for javascript and data protocols (fixes issue #3413)

fix broken test cases

make debugging line more meaningful

Replace string equal idiom

Move 'util::content_size_pretty' into 'acs-lang' and rename it to 'lc_content_size_pretty', localicing 'bytes' and adapting automated tests. Bump 'acs-lang' version.

  1. … 40 more files in changeset.
Localize dot/comma just before return on 'util::content_size_prettyutil::content_size_pretty'

"Replace 'decimal' parameter with 'standard' in 'util::content_size_pretty', wich now supports three different standards (SI base-10, IEC base-2 and the old JEDEC base-2), change default to SI base-10 and modify automated tests accordingly". +info: https://en.wikipedia.org/wiki/Binary_prefix

Remove extra brace

Trailing whitespace cleanup

Add automated test for 'ad_decode' and 'util::interval_pretty' procs. Many thanks to Hanifa Hasan

Add automated test for the 'apm_version_names_compare' proc. Many thanks to Hanifa Hasan

Add automated test for the 'ad_color_to_hex' proc. Many thanks to Hanifa Hasan

file widget-test-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/widget-test-procs.tcl
Add new proc 'util::content_size_pretty', to prettify data size given in bytes, and its automated tests.

It supports both binary and decimal representations, a resolution up to YB/YiB, and setting the precision via parameter.

It should replace ad-hoc size prettyfication done manually in several places of the codebase.

replace hardcoded /tmp by API function [ad_tmpdir]

  1. … 9 more files in changeset.
Mark value checking functions from before ad_page_contract as deprecated

(see also issue #3407)

A 16 years old comment says:

This is some old security crud from before we had ad_page_contract

check_for_form_variable_naughtiness

ad_var_type_check_integer_p

ad_var_type_check_safefilename_p

ad_var_type_check_dirname_p

ad_var_type_check_number_p

ad_var_type_check_word_p

ad_var_type_check_nocheck_p

ad_var_type_check_noquote_p

ad_var_type_check_integerlist_p

added ns_asynclogfile to icanuse features

Fix proc 'before-ns_log' (ns_log can be invoked with multiple args)

Fix proc 'before-ns_log' (ns_log can be invoked with multiple args)

use same idioms for checking for exising commands

  1. … 4 more files in changeset.
new feature: 00-canisue-procs: generalization for feature testing in OpenACS installations

  1. … 1 more file in changeset.
file 00-canisue-procs.tcl was initially added on branch oacs-5-10.

improve spelling

use always acs::permission_cache eval instead of code before acs-cache-procs.tcl

fix for issue #3406: honor PermissionCacheTimeout

Make sure files exist

No need to rollback as we don't touch the db