• last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Test acs_object_type::get_table_name

Test acs_object_name api

Test acs_magic_object

Test various URL generating procs

file defs-procs.tcl was initially added on branch oacs-5-10.

Deprecate util_get_current_url, superseded by ad_return_url

Deprecate export_entire_form_as_url_vars and replace occurrences, add a new -formvars flag to export vars to implement the behavior of the proc, that is, export a subset of the variables coming from the current request

  1. … 3 more files in changeset.
Deprecate export_ns_set_vars and extend export_vars to be able to export also a custom ns_set, which was the real added value provided by this api

  1. … 11 more files in changeset.
Reimplement util_subset_p

Deprecate util_report_successful_library_load

Deprecate util_commify_number, replace occurrences and translate automated tests

  1. … 8 more files in changeset.
Deprecate export_entire_form

Deprecate util_AnsiDatetoPrettyDate

  1. … 2 more files in changeset.
Deprecate util_report_library_entry

Formatting changes

Deprecate util::string_check_urlsafe

Simplify implementation

After some experiments, reinstate the faster version of util_sets_equal_p: this wins (~20% faster) in particular when the sets to be compared are larger

Cleanup duplicated and slower proc definition

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

  1. … 6 more files in changeset.
Extend regression test

if truncate_len is provided we have to call util_close_html_tags for truncating the string

Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

  1. … 1 more file in changeset.
Extend util::http::post_payload and util::http::post to receive form varaibles also in dict form, update documentation

Cleanup leftover arguments

Rename proc according to convention enforced in acs-tcl: naming__proc_naming

comment tags, which are NOT supported by HTML5, allow "abbr" in enhanced text

Reduce verbosity

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 30 more files in changeset.
Fix typo