Activity OpenACS/openacs-4/packages/acs-tcl/tcl/test

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	26
Last Commit:	20 Dec
Commits this week:	0
Total Lines of Code (LoC):	12,538
Net change in LoC this week:	0

Commit Activity

last updated 14 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Wednesday 07 Sep 2022

2:51 pm

antoniop

Test acs_user::ScreenName

- -1
- +42
./community-core-test-procs.tcl
- History
- Source
- Diff
./community-core-test-procs.tcl

12:27 pm

antoniop

Test acs_object_type_hierarchy

- -1
- +76
./object-test-case-procs.tcl
- History
- Source
- Diff
./object-test-case-procs.tcl

Tuesday 06 Sep 2022

2:41 pm

antoniop

Test acs_object_type::get_table_name

- -1
- +21
./object-test-case-procs.tcl
- History
- Source
- Diff
./object-test-case-procs.tcl

2:31 pm

antoniop

Test acs_object_name api

- -1
- +21
./object-test-case-procs.tcl
- History
- Source
- Diff
./object-test-case-procs.tcl

2:27 pm

antoniop

Test acs_magic_object

- -1
- +18
./object-test-case-procs.tcl
- History
- Source
- Diff
./object-test-case-procs.tcl

2:22 pm

antoniop

Test various URL generating procs

- -0
- +72
./defs-procs.tcl
- History
- Source
- Diff
./defs-procs.tcl

2:22 pm

antoniop

More
MAIN:antoniop:20220906122250
deleted 1 file
MAIN

file defs-procs.tcl was initially added on branch oacs-5-10.

- -0
- +0
./defs-procs.tcl
- History
- Source
./defs-procs.tcl

9:40 am

antoniop

Deprecate util_commify_number, replace occurrences and translate automated tests

- -20
- +20
./acs-tcl-test-procs.tcl
- History
- Source
- Diff
./acs-tcl-test-procs.tcl
… 9 more files in changeset.

Thursday 01 Sep 2022

11:50 am

antoniop

Extend regression test

- -5
- +64
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl

12:41 am

antoniop

Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

- -0
- +59
./http-client-procs.tcl
- History
- Source
- Diff
./http-client-procs.tcl
… 2 more files in changeset.

Monday 29 Aug 2022

1:53 pm

gustafn

Use "ns_parsehtml" for speed and correctness when available

The new NaviServer built-in command "ns_parsehtml" is used on

several occasions in the code when available, namely in

- util_close_html_tags

- escaping disallowed HTML tags in ad_text_to_html

- util_close_html_tags

The command "util_close_html_tags" has a long history of troubles,

since it was implemented originally based on regular expressions. It

was reported in Jan 2009, that the function took on certain forums

entries 6 to 9 hours (e.g. /forums/message-view?message_id=357753) to

finish. Therefore, at this time a quick version based on tdom was

introduced, which reduced at that time the performance to 7.3

seconds. However, the tdom-based version tend to fail on invalid HTML,

so it could cover only a few cases. The new "ns_parsehtml" is more

robust and works very stable on openacs.org with the know problem

cases. Furthermore, this version is also significantly faster than the

tdom version.

- -6
- +17
./html-conversion-procs.tcl
- History
- Source
- Diff
./html-conversion-procs.tcl
… 1 more file in changeset.

12:34 pm

gustafn

improve spelling

- -1
- +1
./acs-db-00-procs.tcl
- History
- Source
- Diff
./acs-db-00-procs.tcl
- -1
- +1
./apm-install-procs.tcl
- History
- Source
- Diff
./apm-install-procs.tcl
- -10
- +69
./html-conversion-procs.tcl
- History
- Source
- Diff
./html-conversion-procs.tcl
- -7
- +7
./object-test-case-procs.tcl
- History
- Source
- Diff
./object-test-case-procs.tcl
… 3 more files in changeset.

11:47 am

antoniop

Fix typo

- -1
- +1
./doc-check-procs.tcl
- History
- Source
- Diff
./doc-check-procs.tcl

Saturday 27 Aug 2022

10:35 pm

gustafn

use icanuse "ns_parsehtml" and new interface

- -5
- +4
./doc-check-procs.tcl
- History
- Source
- Diff
./doc-check-procs.tcl

Friday 26 Aug 2022

3:00 pm

antoniop

Deprecate ad_parameter_all_values_as_list: it does not provide much value and was also often use improperly

- -2
- +0
./html-conversion-procs.tcl
- History
- Source
- Diff
./html-conversion-procs.tcl
… 4 more files in changeset.

2:06 pm

do not allow acs-subsite TmpDir parameter to define where the tmpfolder is located anymore. This MUST be the one configured in the server-wide configuration. Tmpfiles cannot be in a subfolder of the tmpfolder, they MUST be direct children instead. A tmpfile MUST exist beforehand and be owned, be readable and writable by the user running the nsd process. This complies with the definition of a tmpfile by AolServer/NaviServer when they are created to store content coming from a file upload.

- -28
- +0
./security-procs.tcl
- History
- Source
- Diff
./security-procs.tcl
… 4 more files in changeset.

Thursday 25 Aug 2022

5:37 pm

antoniop

Reimplement ad_page_contract_filter_proc_tmpfile using security::safe_tmpfile_p

Some of the features implemented by this filter have been ported into the api, namely the possibility to fetch the valid temp folders from the subsite TmpDir parameter and the possibility to relax the check and allow also files deeper in the tmpfolder hierachy.

Notably, the hardcoded tmpfolders "/var/tmp" and "/tmp" have NOT been ported. One should configure these values via the many available options. security::safe_tmpfile_p is also more restrictive when a file exists, because it checks for ownership and read and write permissions on the file.