OpenACS / openacs-4 / packages / acs-tcl / tcl

security-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 22
Last Commit: 02 May
Commits this week: 0
Total Lines of Code (LoC): 2,822
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 29 Aug 2022
12:34 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 6 more files in changeset.
Friday 26 Aug 2022
2:06 pm

antoniop

tmpfile page contract filter reform:

do not allow acs-subsite TmpDir parameter to define where the tmpfolder is located anymore. This MUST be the one configured in the server-wide configuration. Tmpfiles cannot be in a subfolder of the tmpfolder, they MUST be direct children instead. A tmpfile MUST exist beforehand and be owned, be readable and writable by the user running the nsd process. This complies with the definition of a tmpfile by AolServer/NaviServer when they are created to store content coming from a file upload.

Options
    • -36
    • +2
    ./security-procs.tcl
  2. … 4 more files in changeset.
Thursday 25 Aug 2022
5:37 pm

antoniop

Reimplement ad_page_contract_filter_proc_tmpfile using security::safe_tmpfile_p

Some of the features implemented by this filter have been ported into the api, namely the possibility to fetch the valid temp folders from the subsite TmpDir parameter and the possibility to relax the check and allow also files deeper in the tmpfolder hierachy.

Notably, the hardcoded tmpfolders "/var/tmp" and "/tmp" have NOT been ported. One should configure these values via the many available options. security::safe_tmpfile_p is also more restrictive when a file exists, because it checks for ownership and read and write permissions on the file.

Options
    • -3
    • +42
    ./security-procs.tcl
  2. … 2 more files in changeset.
2:37 pm

antoniop

Add must_exist flag to enforce a safe tmpfile to already exist

Options
    • -4
    • +9
    ./security-procs.tcl
  2. … 2 more files in changeset.
1:25 pm

antoniop

Introduce security::safe_tmpfile_p checking whether a file belongs to the configured tmpfolder and respects other constraints

The plan is to use it to improve input validations

Options
    • -1
    • +54
    ./security-procs.tcl
  2. … 2 more files in changeset.
Wednesday 24 Aug 2022
4:51 pm

gustafn

Deactivated script-dynamic again

activating "script-dynamic" for script-src prevents resources as the following from loading

<script type="text/javascript" src="/resources/xowiki/bootstrap-treeview/1.2.0/bootstrap-treeview.min.js" nonce="F8843D5CD542FB1CDB4C94C5D13C4E5ECC2E1DCA">

Options
    • -2
    • +2
    ./security-procs.tcl
Tuesday 23 Aug 2022
8:44 pm

gustafn

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

Options
    • -5
    • +9
    ./security-procs.tcl
  2. … 13 more files in changeset.
Sunday 26 Jun 2022
9:37 pm

gustafn

security::cookie_name: since this is used in acs-lang, it has to be public

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 4 more files in changeset.
Tuesday 07 Jun 2022
10:18 am

gustafn

flipping of session_id apparently works without keeping track of the old session_id, so there is no need of keeping track of it

Options
    • -7
    • +3
    ./security-procs.tcl
Sunday 03 Apr 2022
10:46 am

gustafn

reduce verbosity

Options
    • -2
    • +2
    ./security-procs.tcl
Friday 01 Apr 2022
3:54 pm

gustafn

new API call ::security::csp::add_static_resource_header

The API call set the CSP rule on the current connection for a static

resource depending on the MIME type.

# Sample definition for custom CSP rules for static files in the

# OpenACS configuration file.

#

# ns_section ns/server/$server/acs {

# ...

# ns_param StaticCSP {

# image/svg+xml "script-src 'none'"

# }

# ...

# }

bump version number of acs-tcl to 5.10.1d13

Options
    • -2
    • +22
    ./security-procs.tcl
  2. … 3 more files in changeset.
Tuesday 29 Mar 2022
11:25 am

gustafn

New feature: cookie namespaces

So far, all OpenACS versions used "ad_" as a prefix for cookies (such

as ad_login, ad_session_id, ...). In certain situations this can lead

to confusion, since cookies are managed by browsers via domain names,

and running multiple OpenACS instances in the same domain will cause

overwriting of such cookies by these instances. The can happen e.g.

when running multiple instances on the same machine, or using

port-forwarding to virtual machines/containers, using reverse proxies,

etc. Note that the cookie overwriting problem does not exist for

host-node-mapped subsites, since host-node-mapping depends on domain

names.

One could consider using the port in the cookie name (as

sometimes noted as an option), but this would not work, in case the

same server should be reachable over multiple ports.

Therefore, one can now specify a "CookieNamespace" in the OpenACS

configuration file, which is per default "ad_", which is sufficient

for the majority of installations. In cases, where it is needed, a

different CookieNamespace can now be configured.

To manage the cookie names internally, OpenACS provides a new API call

security::cookie_name to derive the namespaced cookie name from a stem.

Snippet of the OpenACS configuration file for setting the CookieNamespace

#---------------------------------------------------------------------

# OpenACS specific settings (per server)

#---------------------------------------------------------------------

ns_section ns/server/${server}/acs {

ns_param CookieNamespace "ad_"

...

}

Options
    • -29
    • +52
    ./security-procs.tcl
  2. … 2 more files in changeset.
Wednesday 16 Mar 2022
2:18 pm

trenner

check that provided signature is a list, otherwise lassign will fail afterwards

Options
    • -1
    • +9
    ./security-procs.tcl
Monday 07 Feb 2022
1:21 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 2 more files in changeset.
Thursday 20 Jan 2022
10:50 am

gustafn

improve comment

Options
    • -2
    • +2
    ./security-procs.tcl
10:44 am

gustafn

align to the usual naming convention (use "_not_cached" suffix)

Options
    • -6
    • +8
    ./security-procs.tcl
Monday 17 Jan 2022
11:28 am

gustafn

added comments and portlets locations for default ports

Options
    • -4
    • +30
    ./security-procs.tcl
10:31 am

gustafn

security::locations: return configured servers from the driver/servers section

additionally, improve caching

Options
    • -60
    • +110
    ./security-procs.tcl
  2. … 1 more file in changeset.
Monday 04 Oct 2021
11:35 am

gustafn

improve spelling

Options
    • -2
    • +2
    ./security-procs.tcl
Sunday 03 Oct 2021
8:13 pm

gustafn

added support for SCRYPT (RFC 7914) as password hash function.

The use of scrypt requires NaviServer compiled with OpenSSL 3.0 or newer

Options
    • -2
    • +15
    ./security-procs.tcl
  2. … 1 more file in changeset.
Friday 01 Oct 2021
9:30 am

gustafn

stick to the original names with the "-" since this is also the naming convention outside of OpenACS (e.g. "scram-sha-256")

Options
    • -7
    • +7
    ./security-procs.tcl
  2. … 7 more files in changeset.
Wednesday 29 Sep 2021
2:09 pm

antoniop

Complete reform introduced in https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20210928124647

- add datamodel change to the creation script

- refactor algorithm names in a way that the new procs will comply with acs-tcl.naming__proc_naming automated test

Options
    • -7
    • +7
    ./security-procs.tcl
  2. … 6 more files in changeset.
Tuesday 28 Sep 2021
2:46 pm

gustafn

Stronger password hashes for OpenACS

This change introduces the possibility to use either the classical

OpenACS password hash algorithm "salted-sha1" or the SCRAM passord

function "scram-sha-256". The latter can be used by (a) using the

most recent version of NaviServer (from Sept 28, 2021 or newer) and

(b) by configuring the password hash preferences via Kernel package

parameter "PasswordHashAlgorithm". The package parameter can contain a

list of multiple hash algorithms in preference order. The most

preferred available algorithm is chosen.

By default, the "PasswordHashAlgorithm" is "salted-sha1", and the

behavior is as before. After upgrading to the new version of acs-tcl

and acs-kernel, the preference list can be configured. When a user

logs in and the preferred available algorithm is different from the

previously used algorithm, the upgrade is performed for the user

automatically.

The usage of SHA1 in OpenACS is easily target of security audits (see

[1]). The biggest danger is that if somebody gets full access to the

"users" table (e.g. when decommissioning a hard disk). In this case

the hashes can be attacked with dictionaries by using some crypto

hardware (when someone gets raw access to the DB, one has usually some

other big problems). However, by using the "scram-sha-256" hash

function this danger is substantially reduced. This function computes

a password hash using PBKDF2 (Password-Based Key Derivation Function

2). This function is used to reduce vulnerabilities of brute-force

attacks against password hashes. The hash function of SCRAM is PBKDF2

[RFC2898] with HMAC as the pseudorandom function (PRF) and with dkLen

== output length of HMAC == output length of the digest function. So,

it uses a better hash algorithm (sha-256 vs. sha1) and applies this a

high number of times (15K times for a password hash computation).

NaviServer supports as well the even better SCRYPT algorithm, but this

is only available when NaviServer is compiled with OpenSSL 3.0 or

newer. On the contrary, scram-sha-256 (actually PKCS5_PBKDF2_HMAC) is

available since OpenSSL 1.0.0 (2015).

All the improved hash functions require NaviServer with its tight

integration to the crypto functions of OpenSSL.

[1] https://openacs.org/forums/message-view?message_id=5522562

Options
    • -14
    • +103
    ./security-procs.tcl
  2. … 6 more files in changeset.
Tuesday 30 Mar 2021
4:43 pm

hectorr

Mark 'sec_get_random_cached_token_id' as public, as it is used in 'acs-subsite'

Options
    • -2
    • +2
    ./security-procs.tcl
Monday 22 Mar 2021
12:00 pm

gustafn

Improve robustness over invalid configurations

Previouly, the configuration of invalid hostnames (i.e. hostnames,

which cannot be resolved via the OS means) for a network driver

lead to runtime errors under certain conditions.

Options
    • -48
    • +59
    ./security-procs.tcl
Monday 22 Feb 2021
3:35 pm

antoniop

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -6
    • +6
    ./security-procs.tcl
  2. … 2 more files in changeset.
Friday 19 Feb 2021
11:11 am

gustafn

remove protection "private", since function has to be called from other packages

Options
    • -4
    • +4
    ./security-procs.tcl
  2. … 6 more files in changeset.
Thursday 18 Feb 2021
3:41 pm

gustafn

mark functions called only internally as private

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 15 more files in changeset.
Wednesday 17 Feb 2021
9:52 pm

gustafn

improve comment

Options
    • -4
    • +4
    ./security-procs.tcl
Saturday 06 Feb 2021
9:43 pm

gustafn

avoid array notation for per_thread caches to ease flushing

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 5 more files in changeset.