• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Make this template more robust to the casual invocation from the outside

This should actually be moved to the lib directory, as it is intended as an include

Whitespace changes

Make spelling consistent

    • -1
    • +1
    ./catalog/acs-subsite.de_DE.ISO-8859-1.xml
Replace message keys inside message keys. Many thanks to Monika Andergassen.

    • -1
    • +1
    ./catalog/acs-subsite.de_DE.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/acs-subsite.en_US.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/acs-subsite.it_IT.ISO-8859-1.xml
Harden page contract

Make script more robust to agents that won't specify the tmpfile via using the api to retrieve the file information

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 30 more files in changeset.
tmpfile page contract filter reform:

do not allow acs-subsite TmpDir parameter to define where the tmpfolder is located anymore. This MUST be the one configured in the server-wide configuration. Tmpfiles cannot be in a subfolder of the tmpfolder, they MUST be direct children instead. A tmpfile MUST exist beforehand and be owned, be readable and writable by the user running the nsd process. This complies with the definition of a tmpfile by AolServer/NaviServer when they are created to store content coming from a file upload.

  1. … 4 more files in changeset.
Moved styling to site-master.css

  1. … 1 more file in changeset.
Extend test depending on the setting of EmailForgottenPasswordP

    • -18
    • +51
    ./tcl/test/acs-subsite-procs.tcl
Fix missing variable, test the bug

Add page contract

Localize subsites UI on the homepage

Improve translations

    • -5
    • +5
    ./catalog/acs-subsite.it_IT.ISO-8859-1.xml
Improve translation

    • -1
    • +1
    ./catalog/acs-subsite.it_IT.ISO-8859-1.xml
Fixed variable name

150px is not enough. In general, these setting should be performed via style files.

passing properties consistently with @....;literal@

    • -1
    • +1
    ./www/admin/attributes/value-delete.adp
    • -1
    • +1
    ./www/admin/group-types/groups-display.adp
    • -1
    • +1
    ./www/admin/groups/elements-display.adp
    • -1
    • +1
    ./www/admin/groups/rel-type-remove.adp
    • -1
    • +1
    ./www/admin/parties/add-select-type.adp
  1. … 39 more files in changeset.
add more free basic icons to ease switching

    • binary
    ./www/shared/images/eye-slash16.png
file csv16.png was initially added on branch oacs-5-10.

    • binary
    ./www/shared/images/csv16.png
file text16.png was initially added on branch oacs-5-10.

    • binary
    ./www/shared/images/text16.png
file list16.png was initially added on branch oacs-5-10.

    • binary
    ./www/shared/images/list16.png
file folder.gif was initially added on branch oacs-5-10.

    • binary
    ./www/shared/images/folder.gif
file file.gif was initially added on branch oacs-5-10.

    • binary
    ./www/shared/images/file.gif
file eye16.png was initially added on branch oacs-5-10.

    • binary
    ./www/shared/images/eye16.png
file eye-slash16.png was initially added on branch oacs-5-10.

    • binary
    ./www/shared/images/eye-slash16.png
file download16.png was initially added on branch oacs-5-10.

    • binary
    ./www/shared/images/download16.png
Make use of uniform styling based on adp:icon

  1. … 18 more files in changeset.
New parameter for acs-subsite "CSSToolkit"

- potential values: empty ("", default), "bootstrap" (referring to Bootstrap 3) and

"bootstrap5" (referring to Bootstrap 5)

- When the value is empty then the CSS toolkit is determined based on

the name of the theme of the current subsite. When this name

contains bootstrap5 then "bootstrap5" is chosen as toolkit, when it conntains

bootstrap3, then "bootstrap" otherwise it is left empty.

New parameter for acs-subsite "IconSet"

- potential values: empty ("", default), "classic" (old-style gif/png images),

"glyphicons" (Part of Bootstrap 3), and "bootstrap-icons" (usable

for all themes).

- When the value is empty then the iconset is determined

based on the CSSToolkit and/or the installation of the

"bootstrap-icons" OpenACS packages. When the toolkit is "bootstrap"

this indicates "Bootstrap 3", and "glyphicons" are used. When the

"bootstrap-icons" package is installed, it is used, otherwise the

"classic" iconset is used.

- bumped version number of acs-subsite to 5.10.1d2

Fixes for Oracle 19c: boolean types in query

This fixes the following bug for Oracle:

[13/Feb/2022:17:53:36][8701.7f9f62f0b700][-conn:oacs-5-10-0:default:0:0-] Error: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00920: invalid relational operator

:

: SQL:

:

: select p.package_id,

: p.instance_name,

: n.node_id,

: n.name,

: :subsite_url || n.name as url,

: (select count(*)

: from group_approved_member_map m

: where m.rel_type = 'membership_rel'

: and m.group_id = ag.group_id) as num_members,

: (select min(r2.member_state)

: from group_member_map m2,

: membership_rels r2

: where m2.group_id = ag.group_id

: and m2.member_id = :untrusted_user_id

: and r2.rel_id = m2.rel_id) as member_state,

: g.group_id,

: g.join_policy

: from site_nodes n,

: apm_packages p,

: application_groups ag,

: groups g

: where n.parent_id = :subsite_node_id

: and p.package_id = n.object_id

: and p.package_key in ('acs-subsite')

: and ag.package_id = p.package_id

: and g.group_id = ag.group_id

: and (g.join_policy !>>>!!= 'closed' or acs_permission.permission_p(p.package_id, :untrusted_user_id, 'read'))

: order by lower(instance_name)

: