• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Avoid unnecesary existence checks

Reduce divergencies between oracle and postgres codebase

    • -48
    • +7
    ./acs-service-contract-procs-oracle.xql
    • -45
    • +6
    ./acs-service-contract-procs-postgresql.xql
    • -0
    • +19
    ./acs-service-contract-procs.xql
Fix unbalanced parenthesis

Fix proc metadata + Whitespace

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 474 more files in changeset.
Reduce query duplication

    • -15
    • +2
    ./acs-service-contract-procs-oracle.xql
    • -16
    • +2
    ./acs-service-contract-procs-postgresql.xql
Prefer 'lappend' to 'set ... concat' for appending elements to lists + Whitespace changes

  1. … 3 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 70 more files in changeset.
simplify code and make it more consistent

  1. … 5 more files in changeset.
Fix typos

  1. … 42 more files in changeset.
fix typos

  1. … 14 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7828 more files in changeset.
Standardize spellings of names

  1. … 11 more files in changeset.
.xql-file reform of acs-service-contract

- remove sql statements from the code, where these are provided via .xql

- prefer empty sql statements over various forms of *SQL*

- remove unneeded sql queries

acs_sc::msg_type::delete.delete_by_id

-remove unneeded files

tcl/acs-service-contract-init-oracle.xql

tcl/acs-service-contract-init-postgresql.xql

www/binding-uninstall-postgresql.xql

    • -14
    • +0
    ./acs-service-contract-init-oracle.xql
    • -13
    • +0
    ./acs-service-contract-init-postgresql.xql
  1. … 1 more file in changeset.
- fix incorrect parens (many thanks to Frank Bergmann, see http://openacs.org/forums/message-view?message_id=4870527)

- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 749 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

    • -28
    • +26
    ./acs-service-contract-procs.tcl
  1. … 2543 more files in changeset.
- fix api-doc variable @creation-date

- fix invalid @param declaration for API browser

  1. … 4 more files in changeset.
- use list instead of quoted strings in util_memoize to avoid surprises with empty strings etc.

  1. … 2 more files in changeset.
- simply expressions

- don't abbreviate "info" subcommands

- bump version number

  1. … 2 more files in changeset.
- use "lassign" instead of "foreach ... break" idiom

  1. … 5 more files in changeset.
- allow startup of the server in cases, where the configuration was messed up (change suggested by Frank in http://openacs.org/forums/message-view?message_id=4082371)

- document the non-deprecated functions, not the deprecated ones

  1. … 4 more files in changeset.
- get rid of deprecated calls to acs_sc_call in regression test

    • -20
    • +16
    ./acs-service-contract-procs.tcl
- abstract in check for existance of a command whether this is scripted or not

- use a more modern tcl command set

  1. … 12 more files in changeset.
- Fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command

"::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered

the few occurances. The fix works as well with Tcl 8.4. The proper

fix for 8.5 would be to use instead of the function the expand

operator {*}

  1. … 3 more files in changeset.
- Fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command

"::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered

the few occurances. The fix works as well with Tcl 8.4. The proper

fix for 8.5 would be to use instead of the function the expand

operator {*}

  1. … 3 more files in changeset.
- fix for Tcl 8.5: OpenACS did overwrite the Tcl built-in command "::apply" and broke therefore all scripts/libraries using it.

Changed the name of the OpenACS function to "ad_apply" and altered the few occurances.

The fix works as well with Tcl 8.4. The proper fix for 8.5 would be to use instead of the function the expand operator {*}

  1. … 3 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 365 more files in changeset.
Added documentation to acs-sc procs.