• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Claim additional coverage

Increase proc coverage

    • -1
    • +37
    ./test/acs-service-contract-procs.tcl
Make the operation api take care of the deletion of its own message types

Also test the drop/recreation of an already existing operation, currently failing

    • -32
    • +29
    ./test/acs-service-contract-procs.tcl
Increase proc coverage

    • -2
    • +89
    ./test/acs-service-contract-procs.tcl
Reduce logging as we do downstream

Whitespace cleanup

preserve comments hinting to ad_apply and apply whitespace changes

  1. … 2 more files in changeset.
Deprecate ad_apply, made obsolete in modern Tcl by the expansion operator "{*}"

  1. … 4 more files in changeset.
Fix typo

complete listing of covered procs in test cases

  1. … 14 more files in changeset.
mark functions called only internally as private

  1. … 14 more files in changeset.
Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 58 more files in changeset.
Improve sql portability

  1. … 5 more files in changeset.
Remove leftover xql files

    • -14
    • +0
    ./acs-service-contract-init-oracle.xql
    • -13
    • +0
    ./acs-service-contract-init-postgresql.xql
Reduce divergency between oracle and postgres codebase

    • -12
    • +0
    ./acs-service-contract-procs-oracle.xql
    • -12
    • +0
    ./acs-service-contract-procs-postgresql.xql
Reduce divergency between oracle and postgres codebase, resolve ancient TODOs, reinstate lost query

Bring files on oacs-5-10 in sync with HEAD

    • -70
    • +71
    ./acs-service-contract-procs.tcl
  1. … 15 more files in changeset.
Whitespace changes

    • -69
    • +68
    ./acs-service-contract-procs.tcl
Add @see and fix typo in proc doc

fix typo

reduce verbosity

add new proc "acs_sc_update_alias_wrappers" to allow refetching of wrapper functions

acs_sc::impl::get_id: in case, no such implementation is available, return empty. This makes it possible to use this function to test for existance.

  1. … 1 more file in changeset.
Fix @param names

  1. … 1 more file in changeset.
make tested API calls explicit

    • -3
    • +11
    ./test/acs-service-contract-procs.tcl
improve spelling

  1. … 12 more files in changeset.
Avoid unnecesary existence checks

Reduce divergencies between oracle and postgres codebase

    • -48
    • +7
    ./acs-service-contract-procs-oracle.xql
    • -45
    • +6
    ./acs-service-contract-procs-postgresql.xql
    • -0
    • +19
    ./acs-service-contract-procs.xql
Fix unbalanced parenthesis