acs-content-repository

  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Complete content::folder api coverage

    • -1
    • +52
    ./tcl/test/content-item-test-procs.tcl
Whitespace cleanup

    • -16
    • +14
    ./tcl/test/content-item-test-procs.tcl
Fix content::extlink::delete: this actually just means to delete the content item

Test public content::extlink api: this test will expose that content::extlink::delete is broken (wrong stored procedure called)

    • -0
    • +115
    ./tcl/test/content-extlink-procs.tcl
file content-extlink-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/content-extlink-procs.tcl
Deprecate content::folder::get_folder_from_package as it assumes there will be one folder per package, not true in general

Replace its only occurrence in the codebase with a local reimplementation (expecting the assessment package to comply with this restriction and not have more than 1 folder per package instance)

  1. … 1 more file in changeset.
Deprecate a proc broken since we have memory of it (~17 years)

Whitespace cleanup

    • -7
    • +7
    ./tcl/test/content-folder-test-procs.tcl
Remove leftover public api: the underlying database api was obsolete and removed 5 years ago by git commit d91c99f522588a41bd8614ba815162a81940b08a

    • -189
    • +0
    ./tcl/content-permission-procs.tcl
Make apm callback private

improve spelling: move closer to the linux documentation recommendations

  1. … 27 more files in changeset.
Fix for plausible file checking in cr_delete_orphans

The code checks for files, which are not conforming to the naming conventions,

and intends to skip these. ... but a "continue" was missing.

Many thanks to Franz Penz

Fix typo

file upgrade-5.10.0d11-5.10.0d12.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
use SQL functions (instead of plpgsql) defined as stabe and strict for

* content_folder__is_folder

* content_folder__is_sub_folder, and

* content_folder__is_empty

... having as well more sane constructs returning boolean values

    • -262
    • +241
    ./sql/postgresql/content-folder.sql
file upgrade-5.10.0d10-5.10.0d11.sql was initially added on branch oacs-5-10.

improve performance of content_folder__is_sub_folder

    • -40
    • +15
    ./sql/postgresql/content-folder.sql
file upgrade-5.10.0d9-5.10.0d10.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d9-5.10.0d10.sql
Add oracle upgrade logic for previous attribute datatype discrepancy package upgrades, and fix typo in postgres upgrade script

    • -0
    • +21
    ./sql/oracle/upgrade/upgrade-5.10.0d8-5.10.0d9.sql
  1. … 2 more files in changeset.
file upgrade-5.10.0d8-5.10.0d9.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0d8-5.10.0d9.sql
file upgrade-5.10.0d8-5.10.0d9.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d8-5.10.0d9.sql
Fix attribute datatype discrepancy, introduced in 2006 but never fixed for already existing instances.

Original datatype change:

https://fisheye.openacs.org/changelog/OpenACS?cs=MAIN%3Avictorg%3A20060727200933

https://github.com/openacs/openacs-core/commit/7e30fa270483dcbc866ffbf6f5cf4f30447987cb

  1. … 2 more files in changeset.
Whitespace cleanup

Reduce divergency between oracle and postgres codebase, bring portable sql inline

    • -37
    • +0
    ./tcl/revision-procs-postgresql.xql
Rename ReturnHeaders proc to comply with OpenACS naming convention, create deprecated wrapper, replace occurrences

  1. … 10 more files in changeset.
Whitespace cleanup

Move CR search callbacks to new namespace in compliance with OpenACS naming convention, create deprecated wrappers, update service contract tables

file upgrade-5.10.0d7-5.10.0d8.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0d7-5.10.0d8.sql
Prefer bind variables, use portable idioms