• last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve validation of email address and user-id used as source for email address

  1. … 1 more file in changeset.
Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

  1. … 7 more files in changeset.
make using page-filter "object_id" backwards compatible by allowing it to be used also during update scripts

  1. … 1 more file in changeset.
improve log message

check_expired_certificates: automated certificate nenewal for letsencrypt

This change reduce maintenance effort by automating certificate

renewal. When the NaviServer letsencrypt module is installed and

configured, the background operation check_expired_certificates will

automatically update the certificates when these expire soon (as

defined by the "ExpireCertificateWarningPeriod" parameter of

acs-admin). When a recent version of NaviServer is used that supports

certificate refetch on SIGHUP, the new certificates are automatically

updated without a server restart.

Prerequisites:

- Recent version of letsencrypt NaviServer module installed (0.6)

and configured

- Recent version of NaviServer (currently Bitbucket tip) for automated

certificate reloading

When the recent letsencrypt module is not installed,

check_expired_certificates sends expiration warnings as usual.

Therefore, it is also useful for sites using certificates from

different sources.

This new functionality was used for latest certificate renewal on

openacs.org.

Prefer portable limit idiom, streamline query, "bad postgres" does not need this...

whitespace changes (remove tabs)

    • -7
    • +7
    ./www/apm/packages-install-3-oracle.xql
    • -9
    • +9
    ./www/apm/packages-install-3-postgresql.xql
    • -21
    • +21
    ./www/apm/version-dependencies-oracle.xql
    • -23
    • +23
    ./www/apm/version-dependencies-postgresql.xql
    • -18
    • +14
    ./www/apm/version-dependencies.xql
    • -8
    • +7
    ./www/apm/version-dependency-add-2.xql
    • -17
    • +17
    ./www/apm/packages/index-oracle.xql
    • -15
    • +15
    ./www/apm/packages/index-postgresql.xql
  1. … 3 more files in changeset.
Remove obsolete files, initially deleted in oacs-5-8 branch, 8 years ago, which somehow managed to survive

    • -76
    • +0
    ./www/apm/version-generate-diffs.tcl
    • -13
    • +0
    ./www/apm/version-generate-diffs.xql
Remove obsolete file, initially deleted in oacs-5-8 branch, 8 years ago, which somehow managed to survive

Remove ancient test for 'acs-admin', which uses obsolete API and don't work anymore

    • -129
    • +0
    ./www/test/signed-cookies-test-2.tcl
    • -14
    • +0
    ./www/test/signed-cookies-test-2.xql
Use the new 'url' input type widget

  1. … 1 more file in changeset.
reduce public footprint

  1. … 1 more file in changeset.
mark functions called only internally as private

  1. … 15 more files in changeset.
prefer ns_dbquotevalue over db_quote, mark latter as deprecated

  1. … 3 more files in changeset.
improve listing of test coverage

  1. … 17 more files in changeset.
make listing of tested procs more complete

  1. … 6 more files in changeset.
in newer versions of tar, the option "-C" is position dependent

make end of options explicit

  1. … 41 more files in changeset.
Let admin manage notifications of a user

Otherwise, we have currently no user-interface to e.g. unsubscribe the notifications of a user

to avoid sending mails to a domain (which might be in user by some other organization).

show HEAD branch and oacs-5-10 development branch

improve line-breaks

Fix typo in proc doc

Split up basic user information (one.tcl) and the users contributions (one-contributions)

Without this change, one.tcl becomes unusable for large sites, where some

users have literally millions of objects (e.g. admins migrating some data).

We have seen the query running for several hours. Maybe, one should

limit also in the splitted case the number of presented contributions

file one-contributions.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/users/one-contributions.adp
file one-contributions.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/users/one-contributions.tcl
Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

    • -2
    • +2
    ./www/apm/version-callback-add-edit.tcl
  1. … 54 more files in changeset.
use bind variables instead of tcl variable substition in xql fullqueries

  1. … 15 more files in changeset.
Fix proc doc

reduce debugging output

fix listing of batch run

- make links clickable

- modernize Tcl code