• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
made includelet "categories" folder aware (on can pass "parent" in form of a page-ref to the includelet)

refactored some of the code to increase reusability

    • -30
    • +1
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
make treeview more compact

Deprecated trivial private ad_user_login wrapper, which is already a public api

Promote logics in auth::authentication::Authenticate to a public api, which unfortunately cannot be the same due to the inconsistent naming, hence we have to create a new alias

Rationale:

- the proc provides some value to the user by choosing the right contract implementation depending on the authority

- we found occurrences in other packages downstream, and as internally this proc is calling only public api, one could just duplicate the whole thing and be compliant with our standards, which is not an improvement IMO

- the proc was already tested and documented

Update doc following the acs_named_objects phasing out, this escaped the commit back in the days

Remove leftover

Refactoring, as proctoring files are not only pictures, make api public, write automated test

break overlong lines

stick to content-repository API instead of duplicating code here.

Use better timing idiom

Fixed var name and add warning for 'cr_file_name' being empty (the latter ported from downstream, originally made by Günter Ernst)

new function: ::content::revision::export_to_filesystem

This change moves functionality from file-storage to acs-content-repository.

all application packages should be free of internals, such as the storage

type. Storage_type should be handeled in the content-repository package.

We are not yet done, there is still more to do in this respect in

the file-storage package.

break overlong lines

improve comments

make actions changed from the background state-safe

    • -3
    • +3
    /openacs-4/packages/xowf/lib/inclass-exam.wf
Implement a checksum + cache mechanism to check whether user is sending the same file multiple times:

this is needed to address the problem of timeouts, where the server might process a request even when the client has given up and rescheduled the upload. We now store the latest checksum that has been received and compare it with the new picture.

file proctoring-support-init.tcl was initially added on branch oacs-5-10.

Whitespace changes + Editor hints

Replace deprecated API

Update spanish message keys

Update spanish message keys

    • -0
    • +4
    /openacs-4/packages/xolp/catalog/xolp.es_ES.ISO-8859-1.xml
Improve fix: do not even fetch the context_id for revisions, so we do not touch it when saving

Make sure that the context_id of a CRItem is always fetched from that of the item, rather than the revision, otherwise we could break object_id = context_id constraint on saving

write mutual overwrites to the system log

improve spelling

  1. … 3 more files in changeset.
improve listing of covered methods

added support for pagination buttons, visited buttons and flagged buttons

    • -12
    • +32
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
added support for avoiding quoting of labels (e.g. in buttons)

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
make question manager configurable

fix regression test which was broken due to last change (move of links to answer panel)

    • -2
    • +2
    /openacs-4/packages/xowf/lib/inclass-exam.wf