• last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
whitespace changes

fix for issue #3440: problem with SQL queries in db_transactions after some db_multirows

the was a problem with with db_handle management in complex setups,

where a db_multirow iterating over more than one tuple causes

some other queries in the transaction to fail. See as well

the new test case added to the regression test.

Many thanks to Keith Paskett for reporting and the good test case!

https://openacs.org/bugtracker/openacs/bug?format=table&bug_number=3440

    • -131
    • +152
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
file db-proc-test-procs.tcl was initially added on branch oacs-5-10.

update comments concering CSP "report-to" directive

Move logics to create forum notification type to tcl to:

- reduce code duplication

- make it simpler to extend forums with new notification types

This reform was triggered by a downstream request, where users would like a new kind of notification for forum moderators that triggers also when a forum message has not been approved

update jquery versions (part 2)

    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/resource-init.tcl
file jquery-3.5.1.js was initially added on branch oacs-5-10.

file jquery-3.5.1.min.js was initially added on branch oacs-5-10.

Complete a long standing transition (before 5.5): rely on callbacks intead of service contracts to implement FTS datasource logics in the forums package

    • -2
    • +2
    /openacs-4/packages/forums/forums.info
update jquery versions

Whitespace changes

Fix typo in version number

add multiple to page contract

whitespace cleanup

improve SQL quoting

improve SQL quoting

    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/atjob-procs.tcl
improve quoting

improve SQL quoting

whitespace cleanup

whitespace changes

improve SQL quoting

improve SQL quoting and source code documentation

improve SQL quoting

    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
improve variable names

use ns_dbquotelist

prefer dict over array

use "ns_dbquotelist" to quote tcl list

use ns_dbquotelist to convert Tcl list to sql

improve documentation

provide compatibility function ns_dbquotelist, which is available in newer versions of NaviServer

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info