OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 145
Last Commit: 05 Apr
Commits this week: 0
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 18 Jun 2019
9:18 pm

gustafn

provide a default for pass_through option

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/member-state-change.tcl
8:38 pm

hectorr

Add column 'attachments_allowed_p' to 'forums_forums', to be used to allow/disallow attachments on a per forum basis. Currently, the attachment logic is package instance wise, so if the forums instance has an attachment instance mounted below, then attachments are assumed to be enabled for all forums in that package instance. The idea with this change is to check for both the attachments instance mounted under a particular forum instance, and the 'attachments_allowed_p' column on 'forums_forums', to decide if attachments are enabled or not (both should be true). Next step would be to rewrite the logic to achieve that.

Options
    • -5
    • +5
    /openacs-4/packages/forums/forums.info
    • -0
    • +6
    /openacs-4/packages/forums/sql/oracle/forums-forums-create.sql
    • -0
    • +15
    /openacs-4/packages/forums/sql/oracle/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
    • -1
    • +4
    /openacs-4/packages/forums/sql/postgresql/forums-forums-create.sql
    • -0
    • +10
    /openacs-4/packages/forums/sql/postgresql/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
8:38 pm

hectorr

file upgrade-1.3.1d12-1.3.1d13.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/forums/sql/oracle/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
    • -0
    • +0
    /openacs-4/packages/forums/sql/postgresql/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
6:41 pm

hectorr

Trailing whitespace cleanup

Options
    • -1
    • +1
    /openacs-4/packages/richtext-ckeditor4/tcl/ckfinder-init.tcl
    • -2
    • +2
    /openacs-4/packages/richtext-ckeditor4/tcl/ckfinder-procs.tcl
6:41 pm

hectorr

Use 'ckfinder::file_attach' instead of 'ckfinder::image_attach', which is not implemented.

Options
    • -4
    • +4
    /openacs-4/packages/richtext-ckeditor4/tcl/ckfinder-init.tcl
6:23 pm

hectorr

Make doc and logging consistent with implementation (image_attach -> file_attach)

Options
    • -3
    • +3
    /openacs-4/packages/richtext-ckeditor4/tcl/ckfinder-procs.tcl
6:10 pm

antoniop

Fix translation

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/catalog/acs-kernel.de_DE.ISO-8859-1.xml
3:48 pm

antoniop

Keep accepting empty values as proper ids, as deprecated ad_var_type_check_integer_p would have done

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl
3:37 pm

antoniop

Specify an explicit format that clock scan can recognize, otherwise results will be unexpected (port from downstream)

Options
    • -2
    • +2
    /openacs-4/packages/xml-rpc/tcl/validator-procs.tcl
3:05 pm

antoniop

Use provided email only when a party exists, in all other cases keep the previous behavior (fixes automated tests)

Options
    • -5
    • +3
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
2:56 pm

hectorr

Fix regression on enabling/disabling locales

Options
    • -2
    • +3
    /openacs-4/packages/acs-lang/www/admin/index.tcl
2:32 pm

antoniop

Use a german gender-neutral wording for "members"

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -1
    • +1
    /openacs-4/packages/acs-kernel/catalog/acs-kernel.de_DE.ISO-8859-1.xml
Monday 17 Jun 2019
5:47 pm

gustafn

make object adressing more consistent

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
1:31 pm

trenner

fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
12:22 pm

gustafn

improve spelling

Options
    • -1
    • +1
    /openacs-4/packages/file-storage/catalog/file-storage.en_US.ISO-8859-1.xml
12:15 pm

gustafn

replace hardcoded /tmp by API function [ad_tmpdir]

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/image-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/tcl/email-image-procs.tcl
    • -0
    • +1
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/spellcheck-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/openacs-kernel-procs.tcl
    • -1
    • +1
    /openacs-4/packages/evaluation-portlet/tcl/test/tclwebtest-procs.tcl
    • -1
    • +1
    /openacs-4/packages/file-storage/tcl/test/tclwebtest-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/http-client-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/syndicate-procs.tcl
12:14 pm

gustafn

template::reset_request_vars must be executed for all requests in the cleanup

this is already happening via "ns_ictl trace freeconn", but we keep

for the time being this as a reminder, when merging with different versions, etc.

Options
    • -2
    • +8
    /openacs-4/packages/acs-templating/tcl/acs-integration-procs.tcl
Sunday 16 Jun 2019
10:07 pm

gustafn

don't hardcode /tmp/

Options
    • -4
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
9:58 pm

gustafn

simplify file delivery modes

Options
    • -8
    • +6
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
8:51 pm

gustafn

don't start accidentially thread via monitoring

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/index.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/running.tcl
3:12 pm

gustafn

improve spelling

Options
    • -1
    • +1
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-test-procs.tcl
3:11 pm

gustafn

replace deprecated function ad_var_type_check_number_p which was used improperly

Options
    • -9
    • +18
    /openacs-4/packages/acs-lang/www/admin/set-system-timezone.tcl
2:50 pm

gustafn

replace deprecated functions ad_var_type_check_integerlist_p and ad_var_type_check_number_p

Options
    • -3
    • +5
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/legacy-inbound-procs.tcl
2:33 pm

gustafn

replace deprecated ad_var_type_check_number_p by "string is double -strict "

Options
    • -5
    • +5
    /openacs-4/packages/evaluation/www/admin/evaluations/evaluate-students-2.tcl
    • -4
    • +4
    /openacs-4/packages/evaluation/www/admin/evaluations/evaluate-students.tcl
    • -3
    • +3
    /openacs-4/packages/evaluation/www/admin/evaluations/grades-sheet-parse.tcl
    • -2
    • +2
    /openacs-4/packages/evaluation/www/admin/evaluations/one-evaluation-edit.tcl
    • -1
    • +1
    /openacs-4/packages/evaluation/www/admin/grades/distribution-edit-2.tcl
2:22 pm

gustafn

Mark value checking functions from before ad_page_contract as deprecated

(see also issue #3407)

A 16 years old comment says:

This is some old security crud from before we had ad_page_contract

check_for_form_variable_naughtiness

ad_var_type_check_integer_p

ad_var_type_check_safefilename_p

ad_var_type_check_dirname_p

ad_var_type_check_number_p

ad_var_type_check_word_p

ad_var_type_check_nocheck_p

ad_var_type_check_noquote_p

ad_var_type_check_integerlist_p

Options
    • -12
    • +18
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
2:01 pm

gustafn

fix seplling errors

Options
    • -2
    • +2
    /openacs-4/packages/assessment/assessment.info
    • -9
    • +9
    /openacs-4/packages/assessment/catalog/assessment.en_US.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/assessment/www/index-oracle.xql
    • -1
    • +1
    /openacs-4/packages/assessment/www/index-postgresql.xql
    • -2
    • +2
    /openacs-4/packages/assessment/www/index.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/www/index.xql
1:49 pm

gustafn

fix spelling errors

Options
    • -3
    • +3
    /openacs-4/packages/evaluation/catalog/evaluation.en_US.ISO-8859-1.xml
    • -5
    • +5
    /openacs-4/packages/evaluation/www/admin/evaluations/evaluate-students-2.tcl
    • -1
    • +1
    /openacs-4/packages/evaluation/www/admin/evaluations/grades-sheet-explanation.adp
    • -2
    • +2
    /openacs-4/packages/evaluation/www/admin/evaluations/one-evaluation-edit.tcl
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
1:40 pm

gustafn

whitespace changes

Options
    • -2
    • +1
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl
1:38 pm

gustafn

avoid usage of ad_var_type_check_integer_p

(use Tcl idiom "string is integer -strict" instead)

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -4
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl
1:33 pm

gustafn

fix typos in message catalog and bump version number to force reload

Options
    • -2
    • +2
    /openacs-4/packages/evaluation/evaluation.info
    • -2
    • +2
    /openacs-4/packages/evaluation/catalog/evaluation.en_US.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/evaluation/catalog/evaluation.es_ES.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/evaluation/catalog/evaluation.pt_BR.ISO-8859-1.xml
    • -2
    • +2
    /openacs-4/packages/evaluation/www/admin/tasks/task-add-edit.tcl