OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 19
Total Committers: 145
Last Commit: 17:08
Commits this week: 19
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 21 Apr 2023
6:15 pm

antoniop

Extend the test to cover also cornercase behavior concerning overwriting of files

Options
    • -1
    • +38
    /openacs-4/packages/acs-tcl/tcl/test/utilities-procs.tcl
5:34 pm

antoniop

Test zipping and unzipping utilities

Options
    • -0
    • +37
    /openacs-4/packages/acs-tcl/tcl/test/utilities-procs.tcl
2:43 pm

antoniop

Make test less tautological

Options
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
2:41 pm

antoniop

Test for psql only when this is expected

Options
    • -12
    • +20
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
2:27 pm

antoniop

Prefer OS-agnostic path separator, add cvs to the exec dependencies

Options
    • -4
    • +4
    /openacs-4/packages/acs-admin/tcl/apm-admin-procs.tcl
    • -3
    • +4
    /openacs-4/packages/acs-admin/tcl/test/acs-admin-procs.tcl
1:25 pm

antoniop

Cleanup copy paste error

Options
    • -1
    • +0
    /openacs-4/packages/caldav/tcl/test/caldav-test-procs.tcl
12:42 pm

gustafn

Removed untested and unmaintained code

Options
    • -15
    • +0
    /openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
    • -17
    • +0
    /openacs-4/packages/acs-automated-testing/www/rebuild-server.tcl
    • -1
    • +8
    /openacs-4/packages/acs-automated-testing/www/doc/usage.adp
    • -1
    • +8
    /openacs-4/packages/acs-automated-testing/www/doc/usage.html
    • -1
    • +6
    /openacs-4/packages/acs-automated-testing/www/doc/xml/using.xml
Thursday 20 Apr 2023
5:49 pm

antoniop

Fallback to the location of the psql executable when a pgbin was not explicitly defined in the config file (which is allowed)

Options
    • -2
    • +15
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
5:36 pm

antoniop

Prefer exec-free variant

Options
    • -3
    • +1
    /openacs-4/packages/assessment/tcl/as-item-procs.tcl
    • -15
    • +1
    /openacs-4/packages/assessment/tcl/test/as-assessment-procs.tcl
5:21 pm

antoniop

Cleanup copy paste

Options
    • -2
    • +0
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
5:16 pm

antoniop

Test external command dependencies

Options
    • -0
    • +20
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
    • -0
    • +14
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
5:04 pm

antoniop

Test external command dependencies

Options
    • -0
    • +21
    /openacs-4/packages/search/tcl/test/search-procs.tcl
    • -0
    • +15
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
4:58 pm

antoniop

Prefer exec-free alternative

Options
    • -1
    • +1
    /openacs-4/packages/scorm-importer/tcl/import-utils-procs.tcl
4:57 pm

antoniop

Test external command dependencies

Options
    • -0
    • +20
    /openacs-4/packages/scorm-importer/tcl/test/scorm-importer-test-procs.tcl
4:52 pm

antoniop

Improve documentation

Options
    • -0
    • +6
    /openacs-4/packages/proctoring-support/lib/proctoring-upload.tcl
4:47 pm

antoniop

Test external command dependency for the package

Options
    • -1
    • +25
    /openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
4:32 pm

antoniop

Test external command dependencies

Options
    • -0
    • +15
    /openacs-4/packages/captcha/tcl/test/captcha-procs.tcl
4:27 pm

antoniop

Add library header

Options
    • -0
    • +5
    /openacs-4/packages/caldav/tcl/test/caldav-test-procs.tcl
4:25 pm

antoniop

file boomerang-test-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/boomerang/tcl/test/boomerang-test-procs.tcl
4:22 pm

antoniop

Test external command dependencies

Options
    • -1
    • +15
    /openacs-4/packages/assessment/tcl/test/as-assessment-procs.tcl
    • -0
    • +19
    /openacs-4/packages/boomerang/tcl/test/boomerang-test-procs.tcl
    • -0
    • +16
    /openacs-4/packages/caldav/tcl/test/caldav-test-procs.tcl
4:18 pm

antoniop

Test external command dependencies

This will currently fail because of a bug in db_get_pgbin

Options
    • -0
    • +25
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
3:57 pm

antoniop

Test external command line dependencies

Options
    • -0
    • +14
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-test-procs.tcl
    • -1
    • +15
    /openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
3:34 pm

antoniop

Prefer binary from parameter as everywhere else

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/image-procs.tcl
3:32 pm

antoniop

Test external command line dependencies

Options
    • -1
    • +17
    /openacs-4/packages/acs-content-repository/tcl/test/acs-content-repository-procs.tcl
3:24 pm

antoniop

Test optional external command dependencies

Options
    • -0
    • +15
    /openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
2:57 pm

antoniop

Add further dependency to test

Options
    • -1
    • +2
    /openacs-4/packages/acs-admin/tcl/test/acs-admin-procs.tcl
2:55 pm

antoniop

Test that external command line dependencies are executable

Options
    • -1
    • +20
    /openacs-4/packages/acs-admin/tcl/test/acs-admin-procs.tcl
10:13 am

gustafn

Added optional "-name" to xowiki::update_item_index

This attribute was missing from the changeble attributes

of the xowiki_form_instance_item_index

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Wednesday 19 Apr 2023
7:31 pm

gustafn

improved parameter checking

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
7:19 pm

gustafn

Undo part of the recent cache-deactivation for attribute definitions

When all calls for "db_attribute_defined" are performed without

caching, this results in a huge amount of additional SQL queries,

since these tests are performed during blueprint definition as well

during every blueprint reload of every db attribute. On a small site

with just 6 connection threads (2 monitor, 2 default, 2 slow), this

results during startup with 969 additional SQL queries, a reload of

xowiki causes an additional 1063 of such queries. When a site defines

much more connection threads ((the LEARN site has e.g. 85 connection

threads defined), these DB attribute testing operations will result in

10K+ of mostly useless SQL queries. As a consequence of this, the

startup of the server will become slower, reloads will become slower

etc., which is bad especially for large sites.

The new implementation seems to fix the original problem case (running

xotcl_core_tutorial_4 multiple times). If there is still a problem

with installing xolp [2] this problem should be analyzed and fixed

probably there. If necessary, a proper bug report would be appreciated

to reduce guessing work.

[1] https://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-10%3Aantoniop%3A20230310183055

[2] https://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-10%3Aantoniop%3A20230317160241

Options
    • -10
    • +29
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl