OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 145
Last Commit: 05 Apr
Commits this week: 0
Total Lines of Code (LoC): 6,873,112
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 20 Apr 2023
4:57 pm

antoniop

Test external command dependencies

Options
    • -0
    • +20
    /openacs-4/packages/scorm-importer/tcl/test/scorm-importer-test-procs.tcl
4:52 pm

antoniop

Improve documentation

Options
    • -0
    • +6
    /openacs-4/packages/proctoring-support/lib/proctoring-upload.tcl
4:47 pm

antoniop

Test external command dependency for the package

Options
    • -1
    • +25
    /openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
4:32 pm

antoniop

Test external command dependencies

Options
    • -0
    • +15
    /openacs-4/packages/captcha/tcl/test/captcha-procs.tcl
4:27 pm

antoniop

Add library header

Options
    • -0
    • +5
    /openacs-4/packages/caldav/tcl/test/caldav-test-procs.tcl
4:25 pm

antoniop

file boomerang-test-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/boomerang/tcl/test/boomerang-test-procs.tcl
4:22 pm

antoniop

Test external command dependencies

Options
    • -1
    • +15
    /openacs-4/packages/assessment/tcl/test/as-assessment-procs.tcl
    • -0
    • +19
    /openacs-4/packages/boomerang/tcl/test/boomerang-test-procs.tcl
    • -0
    • +16
    /openacs-4/packages/caldav/tcl/test/caldav-test-procs.tcl
4:18 pm

antoniop

Test external command dependencies

This will currently fail because of a bug in db_get_pgbin

Options
    • -0
    • +25
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
3:57 pm

antoniop

Test external command line dependencies

Options
    • -0
    • +14
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-test-procs.tcl
    • -1
    • +15
    /openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
3:34 pm

antoniop

Prefer binary from parameter as everywhere else

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/image-procs.tcl
3:32 pm

antoniop

Test external command line dependencies

Options
    • -1
    • +17
    /openacs-4/packages/acs-content-repository/tcl/test/acs-content-repository-procs.tcl
3:24 pm

antoniop

Test optional external command dependencies

Options
    • -0
    • +15
    /openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
2:57 pm

antoniop

Add further dependency to test

Options
    • -1
    • +2
    /openacs-4/packages/acs-admin/tcl/test/acs-admin-procs.tcl
2:55 pm

antoniop

Test that external command line dependencies are executable

Options
    • -1
    • +20
    /openacs-4/packages/acs-admin/tcl/test/acs-admin-procs.tcl
10:13 am

gustafn

Added optional "-name" to xowiki::update_item_index

This attribute was missing from the changeble attributes

of the xowiki_form_instance_item_index

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Wednesday 19 Apr 2023
7:31 pm

gustafn

improved parameter checking

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
7:19 pm

gustafn

Undo part of the recent cache-deactivation for attribute definitions

When all calls for "db_attribute_defined" are performed without

caching, this results in a huge amount of additional SQL queries,

since these tests are performed during blueprint definition as well

during every blueprint reload of every db attribute. On a small site

with just 6 connection threads (2 monitor, 2 default, 2 slow), this

results during startup with 969 additional SQL queries, a reload of

xowiki causes an additional 1063 of such queries. When a site defines

much more connection threads ((the LEARN site has e.g. 85 connection

threads defined), these DB attribute testing operations will result in

10K+ of mostly useless SQL queries. As a consequence of this, the

startup of the server will become slower, reloads will become slower

etc., which is bad especially for large sites.

The new implementation seems to fix the original problem case (running

xotcl_core_tutorial_4 multiple times). If there is still a problem

with installing xolp [2] this problem should be analyzed and fixed

probably there. If necessary, a proper bug report would be appreciated

to reduce guessing work.

[1] https://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-10%3Aantoniop%3A20230310183055

[2] https://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-10%3Aantoniop%3A20230317160241

Options
    • -10
    • +29
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
6:57 pm

gustafn

Use the usual idiom for checking if the connection is active

... why in the first place was this change necessary? Who calls this

in which way this www-*method without a connection?

Options
    • -3
    • +5
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
4:34 pm

antoniop

Address issue in downstream pipeline, which should not really happen in practice (yet it might) and update documentation

Options
    • -8
    • +17
    /openacs-4/packages/fs-portlet/www/fs-contents-portlet.tcl
Monday 17 Apr 2023
2:43 pm

antoniop

Port of downstream fix: check by the element's content, not the element itself

Options
    • -5
    • +8
    /openacs-4/packages/static-portlet/www/element.tcl
Friday 14 Apr 2023
5:46 pm

antoniop

Streamline idiom

Options
    • -7
    • +10
    /openacs-4/packages/fs-portlet/www/fs-portlet.tcl
5:21 pm

antoniop

Test ad_change_password

Options
    • -0
    • +29
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
4:03 pm

antoniop

Prefer cached api

Options
    • -4
    • +5
    /openacs-4/packages/calendar/tcl/calendar-procs.tcl
    • -3
    • +5
    /openacs-4/packages/forums/tcl/forums-procs.tcl
4:02 pm

antoniop

Add notes about api

Options
    • -5
    • +21
    /openacs-4/packages/acs-tcl/tcl/site-node-apm-integration-procs.tcl
3:25 pm

antoniop

Prefer cached api

Options
    • -4
    • +6
    /openacs-4/packages/dotlrn/www/register.tcl
    • -2
    • +7
    /openacs-4/packages/dotlrn/www/spam.tcl
    • -4
    • +6
    /openacs-4/packages/dotlrn/www/weblog-control-panel.tcl
    • -3
    • +6
    /openacs-4/packages/dotlrn/www/weblog-new.tcl
2:53 pm

antoniop

Prefer cached api

Options
    • -18
    • +20
    /openacs-4/packages/dotlrn-fs/tcl/dotlrn-fs-procs.tcl
2:42 pm

antoniop

Whitespace cleanup

Options
    • -30
    • +30
    /openacs-4/packages/dotlrn-fs/tcl/dotlrn-fs-procs.tcl
2:37 pm

antoniop

Prefer cached api, document behavior

Options
    • -2
    • +11
    /openacs-4/packages/fs-portlet/www/fs-admin-portlet.tcl
Thursday 13 Apr 2023
2:42 pm

antoniop

Port of downstream fix, provide a default for param_action (same as portal::add_element_parameters)

Options
    • -1
    • +1
    /openacs-4/packages/chat-portlet/tcl/chat-portlet-procs.tcl
Wednesday 12 Apr 2023
5:11 pm

antoniop

Also test that no missing message keys are there when rendering the portlet

Options
    • -0
    • +4
    /openacs-4/packages/news-aggregator-portlet/tcl/test/news-aggegator-procs.tcl